Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 345741002: trytond: Improve translation handling for plain text templates

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by EdbO
Modified:
3 months, 2 weeks ago
Reviewers:
pokoli, ced, dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fix comments #

Total comments: 4

Patch Set 3 : Refactor based on the comments #

Total comments: 2

Patch Set 4 : Split callback function, remove dict as default #

Total comments: 16

Patch Set 5 : Update to tip, fix some remarks #

Total comments: 2

Patch Set 6 : Fix remarks, add translator to report context #

Patch Set 7 : Fix isort error #

Total comments: 6

Patch Set 8 : Fix comments, add changelog #

Patch Set 9 : Remove double space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/translation.py View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -3 lines 0 comments Download
M trytond/report/__init__.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/report/report.py View 1 2 3 4 5 6 7 8 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 32
EdbO
1 year, 10 months ago (2021-04-03 16:02:55 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/345741002
1 year, 10 months ago (2021-04-03 16:12:18 UTC) #2
ced
https://codereview.tryton.org/345741002/diff/345751002/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/345741002/diff/345751002/CHANGELOG#newcode1 CHANGELOG:1: * Improve translation handling for plain text templates No ...
1 year, 10 months ago (2021-04-05 14:39:58 UTC) #3
EdbO
1 year, 10 months ago (2021-04-06 10:22:59 UTC) #4
EdbO
Fixed the comments. Because we use only the '_' for translation, I decided to only ...
1 year, 10 months ago (2021-04-06 10:25:22 UTC) #5
reviewbot
https://codereview.tryton.org/345741002/diff/361521004/trytond/ir/translation.py#newcode47 trytond/ir/translation.py:47: expected 2 blank lines, found 1 URL: https://codereview.tryton.org/345741002
1 year, 10 months ago (2021-04-06 10:50:44 UTC) #6
pokoli
https://codereview.tryton.org/345741002/diff/361521004/trytond/report/report.py File trytond/report/report.py (right): https://codereview.tryton.org/345741002/diff/361521004/trytond/report/report.py#newcode305 trytond/report/report.py:305: report_context.setdefault('_', translate) Should we use GETTEXT FUNCTIONS from translate?
1 year, 10 months ago (2021-04-06 12:04:01 UTC) #7
EdbO
https://codereview.tryton.org/345741002/diff/361521004/trytond/report/report.py File trytond/report/report.py (right): https://codereview.tryton.org/345741002/diff/361521004/trytond/report/report.py#newcode305 trytond/report/report.py:305: report_context.setdefault('_', translate) On 2021/04/06 12:04:01, pokoli wrote: > Should ...
1 year, 10 months ago (2021-04-06 15:14:34 UTC) #8
ced
https://codereview.tryton.org/345741002/diff/361521004/trytond/ir/translation.py File trytond/ir/translation.py (right): https://codereview.tryton.org/345741002/diff/361521004/trytond/ir/translation.py#newcode45 trytond/ir/translation.py:45: GETTEXT_FUNCTIONS = ('_') I think it makes more sense ...
1 year, 10 months ago (2021-04-06 15:21:36 UTC) #9
EdbO
1 year, 10 months ago (2021-04-07 18:26:55 UTC) #10
EdbO
https://codereview.tryton.org/345741002/diff/317051002/trytond/report/report.py File trytond/report/report.py (left): https://codereview.tryton.org/345741002/diff/317051002/trytond/report/report.py#oldcode291 trytond/report/report.py:291: Maybe it's better to split the _callback_loader? For the ...
1 year, 10 months ago (2021-04-07 18:32:02 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/345741002
1 year, 10 months ago (2021-04-07 18:48:52 UTC) #12
dave
https://codereview.tryton.org/345741002/diff/317051002/trytond/ir/translation.py File trytond/ir/translation.py (right): https://codereview.tryton.org/345741002/diff/317051002/trytond/ir/translation.py#newcode946 trytond/ir/translation.py:946: def extract_report_genshi(template_class, keywords=None, options={}): You need to be careful ...
1 year, 10 months ago (2021-04-07 20:40:08 UTC) #13
EdbO
1 year, 9 months ago (2021-04-08 09:53:57 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/345741002
1 year, 9 months ago (2021-04-08 09:54:41 UTC) #15
ced
Missing a changelog entry. https://codereview.tryton.org/345741002/diff/357691002/trytond/ir/translation.py File trytond/ir/translation.py (right): https://codereview.tryton.org/345741002/diff/357691002/trytond/ir/translation.py#newcode950 trytond/ir/translation.py:950: keywords=keywords, comment_tags=None, options=options): Why not ...
1 year, 8 months ago (2021-05-27 21:41:52 UTC) #16
EdbO
4 months ago (2022-10-03 15:41:56 UTC) #17
EdbO
https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py File trytond/report/report.py (right): https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py#newcode91 trytond/report/report.py:91: GETTEXT_FUNCTIONS = ('_', 'gettext') On 2021/05/27 21:41:51, ced wrote: ...
4 months ago (2022-10-03 15:52:30 UTC) #18
ced
https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py File trytond/report/report.py (right): https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py#newcode292 trytond/report/report.py:292: translator = Translator(lambda text: translate(text)) On 2022/10/03 15:52:29, EdbO ...
4 months ago (2022-10-03 16:04:32 UTC) #19
reviewbot
ERROR: /tmp/reviewbot-6a36p0mx/trytond/report/__init__.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/345741002
4 months ago (2022-10-03 16:13:20 UTC) #20
EdbO
https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py File trytond/report/report.py (right): https://codereview.tryton.org/345741002/diff/357691002/trytond/report/report.py#newcode292 trytond/report/report.py:292: translator = Translator(lambda text: translate(text)) On 2022/10/03 16:04:31, ced ...
4 months ago (2022-10-03 18:52:34 UTC) #21
EdbO
On 2021/05/27 21:41:52, ced wrote: > Missing a changelog entry. In the first patch set ...
4 months ago (2022-10-03 18:59:33 UTC) #22
EdbO
4 months ago (2022-10-03 19:00:41 UTC) #23
reviewbot
ERROR: /tmp/reviewbot-eonp9pbr/trytond/report/__init__.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/345741002
4 months ago (2022-10-03 19:08:25 UTC) #24
EdbO
4 months ago (2022-10-03 20:38:12 UTC) #25
reviewbot
checks OK URL: https://codereview.tryton.org/345741002
4 months ago (2022-10-03 20:41:23 UTC) #26
ced
https://codereview.tryton.org/345741002/diff/425811003/trytond/ir/translation.py File trytond/ir/translation.py (right): https://codereview.tryton.org/345741002/diff/425811003/trytond/ir/translation.py#newcode986 trytond/ir/translation.py:986: keywords=keywords, comment_tags=None, options=options): You can not change the API ...
4 months ago (2022-10-03 21:25:36 UTC) #27
ced
On 2022/10/03 18:59:33, EdbO wrote: > On 2021/05/27 21:41:52, ced wrote: > > Missing a ...
4 months ago (2022-10-03 21:26:45 UTC) #28
EdbO
4 months ago (2022-10-04 09:33:08 UTC) #29
reviewbot
https://codereview.tryton.org/345741002/diff/435911045/trytond/report/report.py#newcode331 trytond/report/report.py:331: multiple spaces after operator URL: https://codereview.tryton.org/345741002
4 months ago (2022-10-04 09:37:30 UTC) #30
EdbO
3 months, 2 weeks ago (2022-10-17 08:44:49 UTC) #31
reviewbot
3 months, 2 weeks ago (2022-10-17 09:03:59 UTC) #32
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted