Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(424)

Issue 34861002: stock: Add help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by pokoli
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 50

Patch Set 2 : Fix ced's comments and update to tip #

Patch Set 3 : Improve inventory location help #

Patch Set 4 : Fix some syntax errors #

Patch Set 5 : Update to tip #

Total comments: 37
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -85 lines) Patch
M configuration.py View 1 7 chunks +7 lines, -0 lines 3 comments Download
M inventory.py View 1 2 3 2 chunks +25 lines, -13 lines 5 comments Download
M location.py View 1 7 chunks +23 lines, -12 lines 3 comments Download
M move.py View 1 2 3 4 5 chunks +19 lines, -10 lines 4 comments Download
M period.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M product.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M shipment.py View 1 2 3 26 chunks +96 lines, -47 lines 22 comments Download

Messages

Total messages: 13
pokoli
8 months ago (2017-03-27 13:22:23 UTC) #1
reviewbot
https://codereview.tryton.org/34861002/diff/1/move.py#newcode751 move.py:751: E127 continuation line over-indented for visual indent https://codereview.tryton.org/34861002/diff/1/shipment.py#newcode882 shipment.py:882: E901 SyntaxError: invalid syntax ...
8 months ago (2017-03-27 13:32:29 UTC) #2
ced
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") Not sure ...
1 month, 3 weeks ago (2017-10-02 22:17:43 UTC) #3
pokoli
Fix ced's comments and update to tip
1 month, 3 weeks ago (2017-10-04 09:09:47 UTC) #4
reviewbot
https://codereview.tryton.org/34861002/diff/20001/move.py#newcode1052 move.py:1052: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 3 weeks ago (2017-10-04 09:16:17 UTC) #5
pokoli
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") On 2017/10/02 ...
1 month, 3 weeks ago (2017-10-04 09:28:37 UTC) #6
ced
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") On 2017/10/04 ...
1 month, 3 weeks ago (2017-10-04 09:36:14 UTC) #7
pokoli
Improve inventory location help
1 month, 3 weeks ago (2017-10-04 09:43:12 UTC) #8
pokoli
Fix some syntax errors
1 month, 3 weeks ago (2017-10-04 09:57:52 UTC) #9
reviewbot
https://codereview.tryton.org/34861002/diff/60001/move.py#newcode1052 move.py:1052: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 3 weeks ago (2017-10-04 10:18:06 UTC) #10
pokoli
Update to tip
3 weeks, 3 days ago (2017-10-31 08:51:47 UTC) #11
reviewbot
https://codereview.tryton.org/34861002/diff/80001/move.py#newcode1057 move.py:1057: E712 comparison to True should be 'if cond is not True:' or 'if ...
3 weeks, 3 days ago (2017-10-31 09:17:00 UTC) #12
ced
1 week, 4 days ago (2017-11-13 18:20:49 UTC) #13
https://codereview.tryton.org/34861002/diff/80001/configuration.py
File configuration.py (right):

https://codereview.tryton.org/34861002/diff/80001/configuration.py#newcode18
configuration.py:18: help="Stores moves pending to recieve on internal
shipments.",
receive

https://codereview.tryton.org/34861002/diff/80001/configuration.py#newcode18
configuration.py:18: help="Stores moves pending to recieve on internal
shipments.",
I do not think it is right to describe using a state. The description is no more
accurate if the moves are done.

https://codereview.tryton.org/34861002/diff/80001/configuration.py#newcode51
configuration.py:51: help="Used to generate the supplier shipment number.",
is it not better: the number of supplier shipment.
idem for all below.

https://codereview.tryton.org/34861002/diff/80001/inventory.py
File inventory.py (right):

https://codereview.tryton.org/34861002/diff/80001/inventory.py#newcode45
inventory.py:45: help=("The location to move the quantites from/to."))
parenthesis are not needed.

https://codereview.tryton.org/34861002/diff/80001/inventory.py#newcode45
inventory.py:45: help=("The location to move the quantites from/to."))
"from/to" is strange.
…to move the difference of quantity.

https://codereview.tryton.org/34861002/diff/80001/inventory.py#newcode49
inventory.py:49: help="Add lines to specify quantities for different products.")
for each product.

https://codereview.tryton.org/34861002/diff/80001/inventory.py#newcode286
inventory.py:286: help="The product which the quantity belongs to.")
I do not find this helpful.

https://codereview.tryton.org/34861002/diff/80001/inventory.py#newcode298
inventory.py:298: help="The real quantity on the location.")
…in the location

https://codereview.tryton.org/34861002/diff/80001/location.py
File location.py (right):

https://codereview.tryton.org/34861002/diff/80001/location.py#newcode93
location.py:93: help="Where the outgoing goods are packed before sending them.")
sending -> shipping

https://codereview.tryton.org/34861002/diff/80001/location.py#newcode118
location.py:118: "If empty the Storage is used."))
Maybe: Leave empty to use the Storage.

https://codereview.tryton.org/34861002/diff/80001/location.py#newcode599
location.py:599: help="The target warehouse of the lead time.")
I do not think from and to need an help. The lead time help explain it clearly.

https://codereview.tryton.org/34861002/diff/80001/move.py
File move.py (right):

https://codereview.tryton.org/34861002/diff/80001/move.py#newcode167
move.py:167: help="The product which is moved.")
The moved product.

https://codereview.tryton.org/34861002/diff/80001/move.py#newcode182
move.py:182: help="The quantity of goods that is moved.")
of moved goods.

https://codereview.tryton.org/34861002/diff/80001/move.py#newcode188
move.py:188: help="The location where the products will move from.")
I think help should always be at "present" time.

https://codereview.tryton.org/34861002/diff/80001/move.py#newcode213
move.py:213: help="When the goods have been moved.")
are moved.

https://codereview.tryton.org/34861002/diff/80001/shipment.py
File shipment.py (right):

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode76
shipment.py:76: help="When the goods have been recieved.")
…are received.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode95
shipment.py:95: help="The supplier identification of this shipment.")
It is not necessary from the supplier, it could be from the carrier.
So I think it is better to stay vague.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode143
shipment.py:143: help="Select moves to receive goods from supplier."),
I think it is better: Select goods to receive.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode160
shipment.py:160: help="Edit moves to store the received goods."),
Edit where to store the goods.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode538
shipment.py:538: help="When the goods have been returned.")
are returned

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode560
shipment.py:560: help="The supplier identification of this shipment return.")
not necessary the supplier

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode609
shipment.py:609: help="Edit goods to be returned to the supplier.")
Add goods to return.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode880
shipment.py:880: help="When the goods have been sent.")
are sent

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode941
shipment.py:941: help="Edit moves to be sent to the customer."),
Edit moves to send.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode961
shipment.py:961: help="Edit moves to specify from where the goods are picked."),
Normally it is more about editing the quantity than where because the
assignation process select the where.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1486
shipment.py:1486: help="When the goods have returned.")
are returned

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1520
shipment.py:1520: help="The customer identification of this shipment.")
Not necessary the customer, can be the carrier for example.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1527
shipment.py:1527: help="The warehouse to where the goods are returned.")
warehouse where

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1545
shipment.py:1545: help="Edit moves to receive goods from the customer."),
Edit goods to receive.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1562
shipment.py:1562: help="Edit moves to store goods on the warehouse."),
Edit goods to store.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1945
shipment.py:1945: help="When the goods have been received on the target
location.")
are received to …

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1957
shipment.py:1957: help="When the goods have been sent from the source
location.")
are sent from…

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode1965
shipment.py:1965: "location."))
You may break the line after "sent"

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode2040
shipment.py:2040: help="Add moves to transfer goods between source and target
location.")
Add goods to send.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode2062
shipment.py:2062: help="Add moves to send goods from source location."),
Add goods to send

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode2084
shipment.py:2084: help="Add moves to receive goods on target location."),
Edit goods to receive.

https://codereview.tryton.org/34861002/diff/80001/shipment.py#newcode2507
shipment.py:2507: help="Use this address for delivering goods.")
for shipping.

I think we should avoid to describe using the same radical as the label.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922