Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 34861002: stock: Add help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by pokoli
Modified:
10 months, 2 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 50

Patch Set 2 : Fix ced's comments and update to tip #

Patch Set 3 : Improve inventory location help #

Patch Set 4 : Fix some syntax errors #

Patch Set 5 : Update to tip #

Total comments: 37

Patch Set 6 : Fix ced's comments #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -82 lines) Patch
M configuration.py View 1 2 3 4 5 7 chunks +7 lines, -0 lines 1 comment Download
M inventory.py View 1 2 3 4 5 2 chunks +23 lines, -12 lines 2 comments Download
M location.py View 1 2 3 4 5 7 chunks +19 lines, -10 lines 0 comments Download
M move.py View 1 2 3 4 5 5 chunks +19 lines, -10 lines 2 comments Download
M period.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M product.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M shipment.py View 1 2 3 4 5 26 chunks +95 lines, -47 lines 9 comments Download

Messages

Total messages: 16
pokoli
1 year, 7 months ago (2017-03-27 13:22:23 UTC) #1
reviewbot
https://codereview.tryton.org/34861002/diff/1/move.py#newcode751 move.py:751: E127 continuation line over-indented for visual indent https://codereview.tryton.org/34861002/diff/1/shipment.py#newcode882 shipment.py:882: E901 SyntaxError: invalid syntax ...
1 year, 7 months ago (2017-03-27 13:32:29 UTC) #2
ced
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") Not sure ...
1 year, 1 month ago (2017-10-02 22:17:43 UTC) #3
pokoli
Fix ced's comments and update to tip
1 year, 1 month ago (2017-10-04 09:09:47 UTC) #4
reviewbot
https://codereview.tryton.org/34861002/diff/20001/move.py#newcode1052 move.py:1052: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 year, 1 month ago (2017-10-04 09:16:17 UTC) #5
pokoli
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") On 2017/10/02 ...
1 year, 1 month ago (2017-10-04 09:28:37 UTC) #6
ced
https://codereview.tryton.org/34861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/34861002/diff/1/inventory.py#newcode36 inventory.py:36: help="The location where the inventory is done.") On 2017/10/04 ...
1 year, 1 month ago (2017-10-04 09:36:14 UTC) #7
pokoli
Improve inventory location help
1 year, 1 month ago (2017-10-04 09:43:12 UTC) #8
pokoli
Fix some syntax errors
1 year, 1 month ago (2017-10-04 09:57:52 UTC) #9
reviewbot
https://codereview.tryton.org/34861002/diff/60001/move.py#newcode1052 move.py:1052: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 year, 1 month ago (2017-10-04 10:18:06 UTC) #10
pokoli
Update to tip
1 year ago (2017-10-31 08:51:47 UTC) #11
reviewbot
https://codereview.tryton.org/34861002/diff/80001/move.py#newcode1057 move.py:1057: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 year ago (2017-10-31 09:17:00 UTC) #12
ced
https://codereview.tryton.org/34861002/diff/80001/configuration.py File configuration.py (right): https://codereview.tryton.org/34861002/diff/80001/configuration.py#newcode18 configuration.py:18: help="Stores moves pending to recieve on internal shipments.", receive ...
1 year ago (2017-11-13 18:20:49 UTC) #13
pokoli
Fix ced's comments
11 months, 3 weeks ago (2017-11-27 10:00:33 UTC) #14
reviewbot
https://codereview.tryton.org/34861002/diff/100001/move.py#newcode1057 move.py:1057: E712 comparison to True should be 'if cond is not True:' or 'if ...
11 months, 3 weeks ago (2017-11-27 10:03:40 UTC) #15
ced
10 months, 2 weeks ago (2018-01-02 12:30:24 UTC) #16
https://codereview.tryton.org/34861002/diff/100001/configuration.py
File configuration.py (right):

https://codereview.tryton.org/34861002/diff/100001/configuration.py#newcode18
configuration.py:18: help="Stores transit products on internal shipments.",
I still think this could be better described. The user may not understand what
is a "transit product".
I would suggest:

"Stores temporary products from internal shipments in transit between
warehouses."

https://codereview.tryton.org/34861002/diff/100001/inventory.py
File inventory.py (right):

https://codereview.tryton.org/34861002/diff/100001/inventory.py#newcode45
inventory.py:45: help="The location to move the quantites from")
Still hard to understand. Which quantities?

https://codereview.tryton.org/34861002/diff/100001/inventory.py#newcode49
inventory.py:49: help="Add lines to specify quantities for each product.")
Does it really need a help? For me, this sentence does not help, indeed I think
it makes it worth.

https://codereview.tryton.org/34861002/diff/100001/move.py
File move.py (right):

https://codereview.tryton.org/34861002/diff/100001/move.py#newcode182
move.py:182: help="The quantity of moved goods.")
Used above "moved product".

https://codereview.tryton.org/34861002/diff/100001/move.py#newcode192
move.py:192: help="Location where the product are sent to.")
Strange to use above "move from" and here "sent to". It should be consistent.

https://codereview.tryton.org/34861002/diff/100001/shipment.py
File shipment.py (right):

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode95
shipment.py:95: help="The external identification of this shipment.")
We have a standard sentence for that:
https://discuss.tryton.org/t/how-to-write-tooltips/212

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode143
shipment.py:143: help="Select goods to receive."),
goods vs products

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode160
shipment.py:160: help="Edit where to store the goods."),
idem

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode538
shipment.py:538: help="When the goods are returned.")
idem

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode560
shipment.py:560: help="The external identification of this shipment return.")
See https://discuss.tryton.org/t/how-to-write-tooltips/212

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode609
shipment.py:609: help="Add goods to return.")
idem goods vs products

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode880
shipment.py:880: help="When the goods are sent.")
idem

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode1963
shipment.py:1963: depends=['state'], help=("When the goods are expected to be
sent "
would start 'help=' on a new line.

https://codereview.tryton.org/34861002/diff/100001/shipment.py#newcode2039
shipment.py:2039: help="Add goods to sent.")
to send
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766