Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 355381002: party_relationship: Add start and end dates to relation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by raimon
Modified:
7 months, 2 weeks ago
Reviewers:
ced, yangoon, albert, pokoli, rietveld-bot, dave, reviewbot
Visibility:
Public.

Description

issue4440 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Patch Set 2 : Update start date from create_date #

Total comments: 15

Patch Set 3 : Rename start/end to start/end_date #

Total comments: 2

Patch Set 4 : Quote labels #

Patch Set 5 : Quote labels #

Total comments: 2

Patch Set 6 : Label #

Total comments: 4

Patch Set 7 : Remove required #

Total comments: 3

Patch Set 8 : Domain eval + changelog #

Total comments: 5

Patch Set 9 : Add active field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -9 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M party.py View 1 2 3 4 5 6 7 8 3 chunks +59 lines, -2 lines 0 comments Download
M view/relation_form.xml View 1 2 3 4 5 6 7 8 1 chunk +14 lines, -7 lines 0 comments Download
M view/relation_tree.xml View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 44
raimon
1 year, 6 months ago (2021-07-09 08:05:47 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/355381002
1 year, 6 months ago (2021-07-09 08:16:34 UTC) #2
raimon
1 year, 6 months ago (2021-07-09 08:19:13 UTC) #3
pokoli
We need a CHANGELOG entry https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) ...
1 year, 6 months ago (2021-07-09 08:43:34 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/355381002
1 year, 6 months ago (2021-07-09 08:51:20 UTC) #5
yangoon
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/09 08:43:34, pokoli wrote: ...
1 year, 6 months ago (2021-07-09 11:28:53 UTC) #6
pokoli
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/09 11:28:53, yangoon wrote: ...
1 year, 6 months ago (2021-07-09 11:35:30 UTC) #7
yangoon
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/09 11:35:30, pokoli wrote: ...
1 year, 6 months ago (2021-07-09 11:53:49 UTC) #8
raimon
1 year, 6 months ago (2021-07-12 06:47:39 UTC) #9
pokoli
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/09 08:43:34, pokoli wrote: ...
1 year, 6 months ago (2021-07-12 06:52:35 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/355381002
1 year, 6 months ago (2021-07-12 06:55:40 UTC) #11
raimon
1 year, 6 months ago (2021-07-12 06:56:19 UTC) #12
raimon
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/09 08:43:34, pokoli wrote: ...
1 year, 6 months ago (2021-07-12 06:56:24 UTC) #13
raimon
1 year, 6 months ago (2021-07-12 06:57:19 UTC) #14
pokoli
https://codereview.tryton.org/355381002/diff/353721002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 party.py:52: start = fields.Date('Start', required=True) On 2021/07/12 06:56:24, raimon wrote: ...
1 year, 6 months ago (2021-07-12 06:59:23 UTC) #15
pokoli
https://codereview.tryton.org/355381002/diff/338461002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/338461002/party.py#newcode52 party.py:52: start_date = fields.Date("Start", required=True) I think it's better labeled: ...
1 year, 6 months ago (2021-07-12 07:02:56 UTC) #16
raimon
On 2021/07/12 07:02:56, pokoli wrote: > https://codereview.tryton.org/355381002/diff/338461002/party.py > File party.py (right): > > https://codereview.tryton.org/355381002/diff/338461002/party.py#newcode52 > ...
1 year, 6 months ago (2021-07-12 07:12:06 UTC) #17
raimon
1 year, 6 months ago (2021-07-12 07:12:59 UTC) #18
reviewbot
flake8 OK URL: https://codereview.tryton.org/355381002
1 year, 6 months ago (2021-07-12 07:16:17 UTC) #19
yangoon
On 2021/07/09 11:53:49, yangoon wrote: > https://codereview.tryton.org/355381002/diff/353721002/party.py > File party.py (right): > > https://codereview.tryton.org/355381002/diff/353721002/party.py#newcode52 > ...
1 year, 6 months ago (2021-07-12 07:46:15 UTC) #20
pokoli
On 2021/07/12 07:12:06, raimon wrote: > On 2021/07/12 07:02:56, pokoli wrote: > > https://codereview.tryton.org/355381002/diff/338461002/party.py > ...
1 year, 6 months ago (2021-07-12 08:14:43 UTC) #21
pokoli
On 2021/07/12 07:46:15, yangoon wrote: > On 2021/07/09 11:53:49, yangoon wrote: > > https://codereview.tryton.org/355381002/diff/353721002/party.py > ...
1 year, 6 months ago (2021-07-12 08:17:39 UTC) #22
ced
For me it is missing a mechanism that prevent to use the relation outside the ...
1 year, 6 months ago (2021-07-12 08:36:52 UTC) #23
raimon
1 year, 6 months ago (2021-07-12 10:59:56 UTC) #24
reviewbot
flake8 OK URL: https://codereview.tryton.org/355381002
1 year, 6 months ago (2021-07-12 11:24:23 UTC) #25
pokoli
I think the distance functions fields should take in account the dates of the relation. ...
1 year, 6 months ago (2021-07-12 12:36:39 UTC) #26
yangoon
On 2021/07/12 08:17:39, pokoli wrote: > On 2021/07/12 07:46:15, yangoon wrote: > > On 2021/07/09 ...
1 year, 6 months ago (2021-07-12 18:12:57 UTC) #27
dave
https://codereview.tryton.org/355381002/diff/344521002/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/355381002/diff/344521002/CHANGELOG#newcode1 CHANGELOG:1: * Add start/end date relationship date relationship -> date ...
1 year, 6 months ago (2021-07-12 22:01:42 UTC) #28
raimon
On 2021/07/12 18:12:57, yangoon wrote: > On 2021/07/12 08:17:39, pokoli wrote: > > On 2021/07/12 ...
1 year, 6 months ago (2021-07-13 05:42:58 UTC) #29
yangoon
On 2021/07/13 05:42:58, raimon wrote: > On 2021/07/12 18:12:57, yangoon wrote: > > On 2021/07/12 ...
1 year, 6 months ago (2021-07-13 07:16:52 UTC) #30
raimon
1 year, 6 months ago (2021-07-13 08:25:17 UTC) #31
reviewbot
https://codereview.tryton.org/355381002/diff/373081002/party.py#newcode53 party.py:53: continuation line over-indented for visual indent https://codereview.tryton.org/355381002/diff/373081002/party.py#newcode58 party.py:58: continuation line over-indented for visual ...
1 year, 6 months ago (2021-07-13 08:49:57 UTC) #32
pokoli
On 2021/07/13 07:16:52, yangoon wrote: > On 2021/07/13 05:42:58, raimon wrote: > > On 2021/07/12 ...
1 year, 6 months ago (2021-07-13 09:19:39 UTC) #33
albert
https://codereview.tryton.org/355381002/diff/373081002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/373081002/party.py#newcode52 party.py:52: If(Eval('start_date') & Eval('end_date'), Being pyson typed, shouldn't it be: ...
1 year, 6 months ago (2021-07-13 09:36:32 UTC) #34
ced
https://codereview.tryton.org/355381002/diff/373081002/party.py File party.py (right): https://codereview.tryton.org/355381002/diff/373081002/party.py#newcode52 party.py:52: If(Eval('start_date') & Eval('end_date'), On 2021/07/13 09:36:32, albert wrote: > ...
1 year, 6 months ago (2021-07-13 09:37:12 UTC) #35
ced
Still missing a mechanism to prevent to use the relation when it is not more ...
1 year, 5 months ago (2021-08-13 09:17:40 UTC) #36
raimon
On 2021/08/13 09:17:40, ced wrote: > Still missing a mechanism to prevent to use the ...
1 year, 5 months ago (2021-08-16 14:40:31 UTC) #37
ced
On 2021/08/16 14:40:31, raimon wrote: > On 2021/08/13 09:17:40, ced wrote: > > Still missing ...
1 year, 5 months ago (2021-08-16 15:30:19 UTC) #38
ced
8 months ago (2022-05-31 14:05:44 UTC) #39
albert
LGTM
8 months ago (2022-05-31 14:29:24 UTC) #40
reviewbot
checks OK URL: https://codereview.tryton.org/355381002
8 months ago (2022-05-31 14:31:22 UTC) #41
raimon
LGTM
8 months ago (2022-06-01 07:55:50 UTC) #42
rietveld-bot_tryton.org
New changeset e3ef2a617aa3 by Cédric Krier in branch 'default': Add start and end dates to ...
7 months, 2 weeks ago (2022-06-21 08:23:49 UTC) #43
rietveld-bot_tryton.org
7 months, 2 weeks ago (2022-06-21 08:23:59 UTC) #44
New changeset 3832e8b0dcd5 by Cédric Krier in branch 'default':
Add start and end dates to relation
https://hg.tryton.org/tryton-env/rev/3832e8b0dcd5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted