Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 35611002: sao: Add position and count label on one2many widget and tree view (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 2 weeks ago by perilla
Modified:
4 months, 3 weeks ago
Reviewers:
pokoli, reviewbot, xcodinas, ced, rietveld-bot
Visibility:
Public.

Description

issue6738 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Patch Set 2 : send position and count from screen #

Patch Set 3 : add label on tree views too #

Total comments: 3

Patch Set 4 : this.group.length -> this.search_count #

Total comments: 3

Patch Set 5 : instead of send label from attributtes at creation, use set_label_count on same place that gtk clie… #

Patch Set 6 : implement update label function out of screen #

Patch Set 7 : using record_message function #

Patch Set 8 : dont check save button, because activate_save is not implemented yet #

Patch Set 9 : use callback function to send data, update to tip #

Patch Set 10 : tab label like in tryton #

Patch Set 11 : label count on tab using badge #

Patch Set 12 : better position of count label #

Patch Set 13 : update to tip #

Total comments: 20

Patch Set 14 : apply ced comments #

Patch Set 15 : update to tip #

Total comments: 10

Patch Set 16 : apply ced comments #

Patch Set 17 : add margin bottom #

Patch Set 18 : add margin left on badge #

Patch Set 19 : addin margin bottom on badge #

Total comments: 4

Patch Set 20 : update to tip, and put badge between previous and next buttons #

Patch Set 21 : Set status to board, fix badge and use badge on one2many #

Total comments: 3

Patch Set 22 : Add missing index_path when view is a tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -13 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
M src/model.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +13 lines, -0 lines 0 comments Download
M src/sao.less View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +16 lines, -0 lines 0 comments Download
M src/screen.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +17 lines, -1 line 0 comments Download
M src/tab.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +30 lines, -1 line 0 comments Download
M src/view/form.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 8 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 56
perilla
11 months, 2 weeks ago (2017-09-02 13:07:49 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 2 weeks ago (2017-09-02 13:18:52 UTC) #2
perilla
send position and count from screen
11 months, 2 weeks ago (2017-09-05 16:13:32 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 2 weeks ago (2017-09-05 16:21:45 UTC) #4
perilla
add label on tree views too
11 months, 2 weeks ago (2017-09-05 17:59:19 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 2 weeks ago (2017-09-05 18:21:43 UTC) #6
ced
https://tryton-rietveld.appspot.com/35611002/diff/40001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/35611002/diff/40001/src/screen.js#newcode631 src/screen.js:631: this.label_count = attributes.label_count || null; For me, it is ...
11 months, 2 weeks ago (2017-09-05 18:35:01 UTC) #7
perilla
this.group.length -> this.search_count
11 months, 2 weeks ago (2017-09-05 18:48:17 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 2 weeks ago (2017-09-05 18:52:22 UTC) #9
pokoli
https://tryton-rietveld.appspot.com/35611002/diff/60001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/35611002/diff/60001/src/screen.js#newcode943 src/screen.js:943: if (this.label_count !== null){ You should probably have a ...
11 months, 2 weeks ago (2017-09-06 08:19:19 UTC) #10
ced
https://tryton-rietveld.appspot.com/35611002/diff/60001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/35611002/diff/60001/src/screen.js#newcode943 src/screen.js:943: if (this.label_count !== null){ On 2017/09/06 08:19:18, pokoli wrote: ...
11 months, 2 weeks ago (2017-09-06 09:48:28 UTC) #11
perilla
instead of send label from attributtes at creation, use set_label_count on same place that gtk ...
11 months, 2 weeks ago (2017-09-06 16:30:16 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 2 weeks ago (2017-09-06 16:54:51 UTC) #13
perilla
implement update label function out of screen
11 months, 1 week ago (2017-09-11 20:07:44 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 1 week ago (2017-09-11 20:21:40 UTC) #15
perilla
using record_message function
11 months, 1 week ago (2017-09-12 16:33:32 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 1 week ago (2017-09-12 16:42:24 UTC) #17
perilla
dont check save button, because activate_save is not implemented yet
11 months, 1 week ago (2017-09-13 15:26:46 UTC) #18
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
11 months, 1 week ago (2017-09-13 15:46:17 UTC) #19
perilla
use callback function to send data, update to tip
10 months, 3 weeks ago (2017-09-27 19:16:06 UTC) #20
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
10 months, 3 weeks ago (2017-09-27 19:39:15 UTC) #21
perilla
tab label like in tryton
10 months, 1 week ago (2017-10-14 11:49:51 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
10 months, 1 week ago (2017-10-14 12:07:14 UTC) #23
perilla
label count on tab using badge
10 months, 1 week ago (2017-10-14 12:26:12 UTC) #24
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
10 months, 1 week ago (2017-10-14 12:48:19 UTC) #25
perilla
better position of count label
10 months ago (2017-10-18 20:11:10 UTC) #26
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
10 months ago (2017-10-18 20:16:12 UTC) #27
perilla
6 months, 1 week ago (2018-02-10 04:57:36 UTC) #28
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
6 months, 1 week ago (2018-02-10 05:23:20 UTC) #29
ced
https://codereview.tryton.org/35611002/diff/240001/src/screen.js File src/screen.js (right): https://codereview.tryton.org/35611002/diff/240001/src/screen.js#newcode946 src/screen.js:946: if(record){ space after 'if' https://codereview.tryton.org/35611002/diff/240001/src/tab.js File src/tab.js (right): https://codereview.tryton.org/35611002/diff/240001/src/tab.js#newcode434 ...
6 months ago (2018-02-12 23:41:59 UTC) #30
perilla
6 months ago (2018-02-13 13:08:47 UTC) #31
perilla
https://codereview.tryton.org/35611002/diff/240001/src/screen.js File src/screen.js (right): https://codereview.tryton.org/35611002/diff/240001/src/screen.js#newcode946 src/screen.js:946: if(record){ On 2018/02/12 23:41:58, ced wrote: > space after ...
6 months ago (2018-02-13 13:15:39 UTC) #32
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
6 months ago (2018-02-13 13:15:45 UTC) #33
perilla
update to tip
5 months ago (2018-03-20 04:09:41 UTC) #34
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
5 months ago (2018-03-20 04:21:41 UTC) #35
ced
https://codereview.tryton.org/35611002/diff/280001/src/tab.js File src/tab.js (right): https://codereview.tryton.org/35611002/diff/280001/src/tab.js#newcode428 src/tab.js:428: 'class': 'badge hidden-xs' I do not think it should ...
5 months ago (2018-03-20 18:43:09 UTC) #36
perilla
https://codereview.tryton.org/35611002/diff/280001/src/tab.js File src/tab.js (right): https://codereview.tryton.org/35611002/diff/280001/src/tab.js#newcode428 src/tab.js:428: 'class': 'badge hidden-xs' On 2018/03/20 18:43:09, ced wrote: > ...
5 months ago (2018-03-21 06:53:20 UTC) #37
perilla
5 months ago (2018-03-21 06:56:49 UTC) #38
perilla
5 months ago (2018-03-21 07:10:54 UTC) #39
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
5 months ago (2018-03-21 07:12:47 UTC) #40
perilla
5 months ago (2018-03-21 07:15:46 UTC) #41
perilla
5 months ago (2018-03-21 07:34:10 UTC) #42
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
5 months ago (2018-03-21 07:44:45 UTC) #43
ced
https://codereview.tryton.org/35611002/diff/280001/src/tab.js File src/tab.js (right): https://codereview.tryton.org/35611002/diff/280001/src/tab.js#newcode430 src/tab.js:430: this.el.find('#title-header').append(this.status_label); On 2018/03/21 06:53:19, perilla wrote: > On 2018/03/20 ...
5 months ago (2018-03-21 08:52:55 UTC) #44
ced
Please do not update the review with tiny changes. It makes harder to track them. ...
5 months ago (2018-03-21 08:56:21 UTC) #45
ced
I suggested on IRC[1] to put the counter in the toolbar between the next and ...
4 months, 4 weeks ago (2018-03-22 09:45:35 UTC) #46
perilla
4 months, 4 weeks ago (2018-03-22 15:32:15 UTC) #47
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
4 months, 4 weeks ago (2018-03-22 15:48:23 UTC) #48
ced
Set status to board, fix badge and use badge on one2many
4 months, 4 weeks ago (2018-03-22 22:24:51 UTC) #49
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
4 months, 4 weeks ago (2018-03-22 22:46:37 UTC) #50
xcodinas
https://codereview.tryton.org/35611002/diff/390001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/35611002/diff/390001/src/view/form.js#newcode2676 src/view/form.js:2676: 'class': 'btn hidden-xs', Why not making it like a ...
4 months, 4 weeks ago (2018-03-23 13:49:31 UTC) #51
ced
https://codereview.tryton.org/35611002/diff/390001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/35611002/diff/390001/src/view/form.js#newcode2676 src/view/form.js:2676: 'class': 'btn hidden-xs', On 2018/03/23 13:49:31, xcodinas wrote: > ...
4 months, 4 weeks ago (2018-03-23 14:21:47 UTC) #52
ced
https://codereview.tryton.org/35611002/diff/390001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/35611002/diff/390001/src/view/form.js#newcode2676 src/view/form.js:2676: 'class': 'btn hidden-xs', On 2018/03/23 14:21:46, ced wrote: > ...
4 months, 4 weeks ago (2018-03-23 14:23:14 UTC) #53
ced
Add missing index_path when view is a tree
4 months, 4 weeks ago (2018-03-23 14:40:02 UTC) #54
reviewbot
flake8 OK URL: https://codereview.tryton.org/35611002
4 months, 4 weeks ago (2018-03-23 14:54:56 UTC) #55
rietveld-bot_tryton.org
4 months, 3 weeks ago (2018-03-23 23:22:08 UTC) #56
New changeset e19282c20d57 by Cédric Krier in branch 'default':
Add position and count label on one2many widget and tree view
http://hg.tryton.org/sao/rev/e19282c20d57
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69