Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(412)

Issue 35761002: tryton: Remove support of GTK+ 2.0

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by ced
Modified:
2 days, 6 hours ago
Reviewers:
reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update freeze #

Patch Set 3 : Missing parenthesis #

Patch Set 4 : Add missing lib and keep gtkrc #

Patch Set 5 : Update darwin #

Patch Set 6 : Fix rpaths on darwin #

Patch Set 7 : Merge win32 and darwin #

Patch Set 8 : Simplify code #

Patch Set 9 : flake8 #

Patch Set 10 : Add missing ssl and use os.path.join #

Patch Set 11 : Remove old gtkrc and include Adwaita icons #

Patch Set 12 : Set XDG_DATA_DIRS to find icons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -207 lines) Patch
M CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/tryton View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -3 lines 0 comments Download
R darwin/gtk-2.0/gtkrc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -2 lines 0 comments Download
A darwin/gtk-3.0/gdk-pixbuf.loaders View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A darwin/gtk-3.0/gtk.immodules View 1 2 3 4 5 6 1 chunk +24 lines, -24 lines 0 comments Download
M doc/installation.rst View 1 chunk +0 lines, -1 line 0 comments Download
M setup.py View 1 chunk +1 line, -1 line 0 comments Download
M setup-freeze.py View 1 2 3 4 5 6 7 8 9 10 2 chunks +77 lines, -35 lines 0 comments Download
M tryton/client.py View 1 2 3 4 5 6 7 8 2 chunks +149 lines, -146 lines 0 comments Download
R win32/gtk-2.0/gtk.immodules View 1 0 chunks +-1 lines, --1 lines 0 comments Download
R win32/gtk-2.0/gtkrc View 1 4 5 6 7 8 9 10 0 chunks +-1 lines, --1 lines 0 comments Download
A win32/gtk-3.0/gdk-pixbuf.loaders View 1 2 3 4 5 6 7 8 9 10 0 chunks +-1 lines, --1 lines 0 comments Download
A win32/gtk-3.0/gtk.immodules View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 23
ced
1 week, 6 days ago (2017-11-11 15:34:29 UTC) #1
reviewbot
https://codereview.tryton.org/35761002/diff/1/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/1/tryton/client.py#newcode26 tryton/client.py:26: E402 module level import not at ...
1 week, 6 days ago (2017-11-11 15:37:34 UTC) #2
ced
Update freeze
1 week, 6 days ago (2017-11-11 17:28:15 UTC) #3
reviewbot
https://codereview.tryton.org/35761002/diff/20001/setup-freeze.py#newcode3 setup-freeze.py:3: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/20001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/20001/tryton/client.py#newcode26 ...
1 week, 6 days ago (2017-11-11 17:29:31 UTC) #4
ced
Missing parenthesis
1 week, 6 days ago (2017-11-11 17:29:43 UTC) #5
reviewbot
https://codereview.tryton.org/35761002/diff/40001/setup-freeze.py#newcode3 setup-freeze.py:3: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/40001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/40001/tryton/client.py#newcode26 ...
1 week, 6 days ago (2017-11-11 18:11:22 UTC) #6
ced
Add missing lib and keep gtkrc
1 week, 6 days ago (2017-11-11 18:19:11 UTC) #7
reviewbot
https://codereview.tryton.org/35761002/diff/60001/setup-freeze.py#newcode3 setup-freeze.py:3: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/60001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/60001/tryton/client.py#newcode26 ...
1 week, 6 days ago (2017-11-11 18:35:30 UTC) #8
ced
Update darwin
1 week, 6 days ago (2017-11-11 18:58:36 UTC) #9
reviewbot
https://codereview.tryton.org/35761002/diff/80001/setup-freeze.py#newcode3 setup-freeze.py:3: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/80001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/80001/tryton/client.py#newcode26 ...
1 week, 6 days ago (2017-11-11 19:10:43 UTC) #10
ced
Fix rpaths on darwin
1 week, 5 days ago (2017-11-12 21:58:18 UTC) #11
reviewbot
https://codereview.tryton.org/35761002/diff/100001/setup-freeze.py#newcode5 setup-freeze.py:5: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/100001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/100001/tryton/client.py#newcode26 ...
1 week, 5 days ago (2017-11-12 22:03:53 UTC) #12
ced
Merge win32 and darwin
1 week, 5 days ago (2017-11-12 22:40:16 UTC) #13
reviewbot
https://codereview.tryton.org/35761002/diff/120001/setup-freeze.py#newcode5 setup-freeze.py:5: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/120001/setup-freeze.py#newcode48 setup-freeze.py:48: E302 expected 2 blank lines, found ...
1 week, 5 days ago (2017-11-12 22:40:38 UTC) #14
ced
Simplify code
1 week, 5 days ago (2017-11-12 22:51:40 UTC) #15
reviewbot
https://codereview.tryton.org/35761002/diff/140001/setup-freeze.py#newcode5 setup-freeze.py:5: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/140001/tryton/client.py#newcode182 tryton/client.py:182: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/140001/tryton/client.py#newcode26 ...
1 week, 5 days ago (2017-11-12 23:06:11 UTC) #16
ced
flake8
1 week, 5 days ago (2017-11-13 00:10:55 UTC) #17
ced
Add missing ssl and use os.path.join
1 week, 5 days ago (2017-11-13 00:22:41 UTC) #18
reviewbot
https://codereview.tryton.org/35761002/diff/110013/setup-freeze.py#newcode5 setup-freeze.py:5: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/110013/tryton/client.py#newcode190 tryton/client.py:190: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/110013/tryton/client.py#newcode26 ...
1 week, 5 days ago (2017-11-13 00:33:35 UTC) #19
ced
Remove old gtkrc and include Adwaita icons
2 days, 7 hours ago (2017-11-22 18:28:20 UTC) #20
reviewbot
https://codereview.tryton.org/35761002/diff/180001/setup-freeze.py#newcode5 setup-freeze.py:5: F401 'user' imported but unused https://codereview.tryton.org/35761002/diff/180001/tryton/client.py#newcode190 tryton/client.py:190: F401 'goocalendar' imported but unused https://codereview.tryton.org/35761002/diff/180001/tryton/client.py#newcode26 ...
2 days, 6 hours ago (2017-11-22 18:44:19 UTC) #21
ced
Set XDG_DATA_DIRS to find icons
2 days, 6 hours ago (2017-11-22 18:49:49 UTC) #22
reviewbot
2 days, 6 hours ago (2017-11-22 19:21:33 UTC) #23
https://codereview.tryton.org/35761002/diff/200001/setup-freeze.py#newcode5
setup-freeze.py:5:
F401 'user' imported but unused

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode190
tryton/client.py:190:
F401 'goocalendar' imported but unused

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode26
tryton/client.py:26:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode107
tryton/client.py:107:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode176
tryton/client.py:176:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode187
tryton/client.py:187:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode194
tryton/client.py:194:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode195
tryton/client.py:195:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode197
tryton/client.py:197:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode198
tryton/client.py:198:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode199
tryton/client.py:199:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode200
tryton/client.py:200:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode201
tryton/client.py:201:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode202
tryton/client.py:202:
E402 module level import not at top of file

https://codereview.tryton.org/35761002/diff/200001/tryton/client.py#newcode203
tryton/client.py:203:
E402 module level import not at top of file

URL: https://codereview.tryton.org/35761002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922