Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)

Issue 357911002: tryton-env: Get directly the string value of Selection fields in non editable tree views

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by nicoe
Modified:
4 months, 2 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

tryton-env: Get directly the string value of Selection fields in non editable tree views issue10331

Patch Set 1 #

Total comments: 13

Patch Set 2 : Fix remarks #

Total comments: 8

Patch Set 3 : Fix remarks #

Patch Set 4 : Set related value #

Total comments: 37

Patch Set 5 : Fix remarks #

Patch Set 6 : Add CHANGELOG #

Total comments: 9

Patch Set 7 : Update to tip #

Total comments: 34

Patch Set 8 : Fix remarks #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -54 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M sao/src/model.js View 1 2 3 4 5 6 7 3 chunks +13 lines, -3 lines 1 comment Download
M sao/src/view/tree.js View 1 2 3 4 5 6 7 1 chunk +32 lines, -21 lines 1 comment Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M tryton/tryton/common/selection.py View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/record.py View 1 2 3 4 5 6 7 2 chunks +13 lines, -6 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/list_gtk/widget.py View 1 2 3 4 5 6 7 1 chunk +11 lines, -5 lines 1 comment Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 1 comment Download
M trytond/trytond/model/fields/selection.py View 1 2 3 4 5 6 7 2 chunks +26 lines, -17 lines 0 comments Download
M trytond/trytond/model/modelsql.py View 1 2 3 4 5 6 7 4 chunks +20 lines, -2 lines 3 comments Download
M trytond/trytond/tests/test_field_selection.py View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 28
nicoe
1 year, 9 months ago (2021-04-23 06:55:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 9 months ago (2021-04-23 07:29:21 UTC) #2
ced
https://codereview.tryton.org/357911002/diff/355311002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/357911002/diff/355311002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1032 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1032: if self.view._editable: For me it should use the public ...
1 year, 9 months ago (2021-04-25 22:28:27 UTC) #3
nicoe
https://codereview.tryton.org/357911002/diff/355311002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/357911002/diff/355311002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1032 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1032: if self.view._editable: On 2021/04/25 22:28:27, ced wrote: > For ...
1 year, 9 months ago (2021-04-27 17:06:23 UTC) #4
nicoe
1 year, 9 months ago (2021-04-27 17:12:23 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 9 months ago (2021-04-27 17:25:19 UTC) #6
ced
https://codereview.tryton.org/357911002/diff/336101002/sao/src/view/tree.js File sao/src/view/tree.js (right): https://codereview.tryton.org/357911002/diff/336101002/sao/src/view/tree.js#newcode2285 sao/src/view/tree.js:2285: if (this.tree && this.tree.editable) { I think if tree ...
1 year, 8 months ago (2021-05-16 17:05:33 UTC) #7
nicoe
1 year, 8 months ago (2021-05-19 13:24:06 UTC) #8
nicoe
https://codereview.tryton.org/357911002/diff/336101002/sao/src/view/tree.js File sao/src/view/tree.js (right): https://codereview.tryton.org/357911002/diff/336101002/sao/src/view/tree.js#newcode2285 sao/src/view/tree.js:2285: if (this.tree && this.tree.editable) { On 2021/05/16 17:05:32, ced ...
1 year, 8 months ago (2021-05-19 13:24:20 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 8 months ago (2021-05-19 13:30:38 UTC) #10
nicoe
1 year, 7 months ago (2021-06-18 17:48:14 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 7 months ago (2021-06-18 17:56:57 UTC) #12
ced
Missing changelog entry https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js#newcode723 sao/src/model.js:723: ((fdescription.loading || 'eager') == 'eager')) { ...
1 year, 5 months ago (2021-08-08 16:31:27 UTC) #13
nicoe
https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js#newcode723 sao/src/model.js:723: ((fdescription.loading || 'eager') == 'eager')) { On 2021/08/08 16:31:26, ...
1 year, 5 months ago (2021-09-02 15:35:19 UTC) #14
nicoe
1 year, 5 months ago (2021-09-02 15:35:34 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 5 months ago (2021-09-02 15:39:25 UTC) #16
nicoe
1 year, 5 months ago (2021-09-02 15:40:20 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/357911002
1 year, 5 months ago (2021-09-02 16:03:58 UTC) #18
ced
https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/357911002/diff/344371002/sao/src/model.js#newcode723 sao/src/model.js:723: ((fdescription.loading || 'eager') == 'eager')) { On 2021/09/02 15:35:18, ...
1 year, 5 months ago (2021-09-02 16:24:18 UTC) #19
ced
https://codereview.tryton.org/357911002/diff/353871002/sao/CHANGELOG File sao/CHANGELOG (right): https://codereview.tryton.org/357911002/diff/353871002/sao/CHANGELOG#newcode1 sao/CHANGELOG:1: * Get directly the string value of Selection fields ...
1 year, 4 months ago (2021-09-22 21:55:48 UTC) #20
nicoe
6 months, 4 weeks ago (2022-07-08 12:45:24 UTC) #21
reviewbot
patch is not applicable URL: https://codereview.tryton.org/357911002
6 months, 4 weeks ago (2022-07-08 13:16:04 UTC) #22
ced
https://codereview.tryton.org/357911002/diff/443391003/sao/CHANGELOG File sao/CHANGELOG (right): https://codereview.tryton.org/357911002/diff/443391003/sao/CHANGELOG#newcode1 sao/CHANGELOG:1: * Get directly the string value of Selection fields ...
6 months, 2 weeks ago (2022-07-18 21:07:24 UTC) #23
nicoe
https://codereview.tryton.org/357911002/diff/443391003/sao/CHANGELOG File sao/CHANGELOG (right): https://codereview.tryton.org/357911002/diff/443391003/sao/CHANGELOG#newcode1 sao/CHANGELOG:1: * Get directly the string value of Selection fields ...
4 months, 2 weeks ago (2022-09-17 08:09:40 UTC) #24
nicoe
4 months, 2 weeks ago (2022-09-17 08:10:35 UTC) #25
reviewbot
checks OK URL: https://codereview.tryton.org/357911002
4 months, 2 weeks ago (2022-09-17 08:21:45 UTC) #26
ced
https://codereview.tryton.org/357911002/diff/443391003/trytond/trytond/tests/test_field_selection.py File trytond/trytond/tests/test_field_selection.py (right): https://codereview.tryton.org/357911002/diff/443391003/trytond/trytond/tests/test_field_selection.py#newcode249 trytond/trytond/tests/test_field_selection.py:249: Selection = Pool().get('test.selection') On 2022/09/17 08:09:40, nicoe wrote: > ...
4 months, 2 weeks ago (2022-09-17 09:50:53 UTC) #27
ced
4 months, 2 weeks ago (2022-09-17 14:47:56 UTC) #28
Missing documentation about the new read API, the new function on Selection and
MultiSelection fields.
Missing test for multiselection fields.

https://codereview.tryton.org/357911002/diff/433501003/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/357911002/diff/433501003/sao/src/model.js#newco...
sao/src/model.js:838: field = this.model.fields[name];
I think it will be better to define it as const here.

https://codereview.tryton.org/357911002/diff/433501003/sao/src/view/tree.js
File sao/src/view/tree.js (right):

https://codereview.tryton.org/357911002/diff/433501003/sao/src/view/tree.js#n...
sao/src/view/tree.js:2572: update_text: function(cell, record) {
The same could be done here.

https://codereview.tryton.org/357911002/diff/433501003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right):

https://codereview.tryton.org/357911002/diff/433501003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1135: def
get_textual_value(self, record):
The same could be done here.

https://codereview.tryton.org/357911002/diff/433501003/trytond/CHANGELOG
File trytond/CHANGELOG (right):

https://codereview.tryton.org/357911002/diff/433501003/trytond/CHANGELOG#newc...
trytond/CHANGELOG:1: * Eagerly read string value of selection field
trytond is not reading eargerly but expose selection string to read API so the
changelog should be about that.

https://codereview.tryton.org/357911002/diff/433501003/trytond/trytond/model/...
File trytond/trytond/model/modelsql.py (right):

https://codereview.tryton.org/357911002/diff/433501003/trytond/trytond/model/...
trytond/trytond/model/modelsql.py:980: for row, instance in zip(rows, targets):
why not named instance target?

https://codereview.tryton.org/357911002/diff/433501003/trytond/trytond/model/...
trytond/trytond/model/modelsql.py:983: value =
fields.Selection.get_selection_string(
Why not access the method from the field like field.get_selection_string()

https://codereview.tryton.org/357911002/diff/433501003/trytond/trytond/model/...
trytond/trytond/model/modelsql.py:988:
value.append(fields.Selection.get_selection_string(
idem
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted