Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 36021002: account_asset: Make asset line fields readonly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 1 week ago by pokoli
Modified:
9 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M asset.py View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4
pokoli
9 months, 1 week ago (2018-03-13 14:34:15 UTC) #1
reviewbot
https://codereview.tryton.org/36021002/diff/1/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/36021002/diff/1/asset.py#newcode911 asset.py:911: E731 ...
9 months, 1 week ago (2018-03-13 14:51:34 UTC) #2
ced
LGTM
9 months ago (2018-03-22 22:47:54 UTC) #3
rietveld-bot_tryton.org
9 months ago (2018-03-23 09:18:05 UTC) #4
New changeset b296c1fb9ab7 by Sergi Almacellas Abellana in branch 'default':
Make asset line fields readonly
http://hg.tryton.org/modules/account_asset/rev/b296c1fb9ab7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766