Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)

Issue 36281002: currency: Add help text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by pokoli
Modified:
3 weeks, 4 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix some typos #

Total comments: 7

Patch Set 3 : Fix ced's comments #

Patch Set 4 : Add help for sign possition #

Total comments: 4

Patch Set 5 : Fix ced's comments #

Patch Set 6 : Update to tip #

Total comments: 5

Patch Set 7 : Fix ced's comments #

Patch Set 8 : update to tip #

Patch Set 9 : Add missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M currency.py View 1 2 3 4 5 6 7 8 2 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 22
pokoli
11 months ago (2017-03-27 11:27:26 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
11 months ago (2017-03-27 11:33:32 UTC) #2
pokoli
Fix some typos
11 months ago (2017-03-28 08:29:24 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
11 months ago (2017-03-28 08:38:17 UTC) #4
ced
https://codereview.tryton.org/36281002/diff/20001/currency.py File currency.py (right): https://codereview.tryton.org/36281002/diff/20001/currency.py#newcode40 currency.py:40: help="Add a separator for each number of digits in ...
4 months, 3 weeks ago (2017-10-02 18:47:31 UTC) #5
pokoli
Fix ced's comments
4 months, 3 weeks ago (2017-10-04 09:42:08 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
4 months, 3 weeks ago (2017-10-04 09:42:42 UTC) #7
pokoli
Add help for sign possition
3 months, 2 weeks ago (2017-11-10 09:18:15 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
3 months, 2 weeks ago (2017-11-10 09:36:01 UTC) #9
ced
https://codereview.tryton.org/36281002/diff/60001/currency.py File currency.py (right): https://codereview.tryton.org/36281002/diff/60001/currency.py#newcode26 currency.py:26: help="The numeric 3 chars ISO currency code.") it is ...
3 months, 2 weeks ago (2017-11-13 11:24:15 UTC) #10
pokoli
Fix ced's comments
3 months, 1 week ago (2017-11-14 11:59:27 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
3 months, 1 week ago (2017-11-14 12:08:42 UTC) #12
pokoli
Update to tip
3 months ago (2017-11-27 09:46:09 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
3 months ago (2017-11-27 10:03:35 UTC) #14
ced
https://codereview.tryton.org/36281002/diff/100001/currency.py File currency.py (right): https://codereview.tryton.org/36281002/diff/100001/currency.py#newcode23 currency.py:23: help="The symbol which identifies the currency.") I would say ...
2 months, 1 week ago (2017-12-19 23:05:34 UTC) #15
pokoli
Fix ced's comments
2 months, 1 week ago (2017-12-20 15:05:58 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
2 months, 1 week ago (2017-12-20 15:12:00 UTC) #17
pokoli
update to tip
1 month ago (2018-01-22 09:10:58 UTC) #18
pokoli
Add missing import
1 month ago (2018-01-22 09:13:26 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/36281002
1 month ago (2018-01-22 09:39:39 UTC) #20
ced
LGTM
1 month ago (2018-01-23 17:48:57 UTC) #21
rietveld-bot_tryton.org
3 weeks, 4 days ago (2018-01-31 15:05:36 UTC) #22
New changeset 857ce9396823 by Sergi Almacellas Abellana in branch 'default':
Add help text
http://hg.tryton.org/modules/currency/rev/857ce9396823
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922