Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 36311002: production_split: Remove stale stock moves (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by nblock
Modified:
1 year, 11 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing scenario #

Total comments: 8

Patch Set 3 : Copy without inputs and outputs #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
M production.py View 1 2 3 chunks +9 lines, -0 lines 2 comments Download
A tests/scenario_production_split.rst View 1 1 chunk +123 lines, -0 lines 0 comments Download
M tests/test_production_split.py View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9
nblock
1 year, 11 months ago (2017-04-10 09:37:21 UTC) #1
nblock
1 year, 11 months ago (2017-04-10 09:38:24 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/36311002
1 year, 11 months ago (2017-04-10 09:41:24 UTC) #3
ced
https://tryton-rietveld.appspot.com/36311002/diff/10003/production.py File production.py (right): https://tryton-rietveld.appspot.com/36311002/diff/10003/production.py#newcode54 production.py:54: self.outputs = None This seems wrong to remove existing ...
1 year, 11 months ago (2017-04-10 10:01:06 UTC) #4
nblock
https://tryton-rietveld.appspot.com/36311002/diff/10003/production.py File production.py (right): https://tryton-rietveld.appspot.com/36311002/diff/10003/production.py#newcode54 production.py:54: self.outputs = None On 2017/04/10 10:01:06, ced wrote: > ...
1 year, 11 months ago (2017-04-10 10:50:44 UTC) #5
nblock
Copy without inputs and outputs
1 year, 11 months ago (2017-04-10 10:52:07 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/36311002
1 year, 11 months ago (2017-04-10 11:06:54 UTC) #7
ced
https://tryton-rietveld.appspot.com/36311002/diff/10003/tests/test_production_split.py File tests/test_production_split.py (right): https://tryton-rietveld.appspot.com/36311002/diff/10003/tests/test_production_split.py#newcode45 tests/test_production_split.py:45: production.outputs = [] On 2017/04/10 10:50:44, nblock wrote: > ...
1 year, 11 months ago (2017-04-10 11:25:21 UTC) #8
nblock
1 year, 11 months ago (2017-04-10 12:18:42 UTC) #9
Avoid itertools.chain()
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766