Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(416)

Issue 36451002: tryton: Reset record to its original state when discarding the popup window

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by nicoe
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add changelog #

Total comments: 14

Patch Set 3 : Fix icon when the record will be deleted #

Total comments: 1

Patch Set 4 : Correctly set icon in popup and fix issue with on_change on fields #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/model/record.py View 1 2 3 1 chunk +8 lines, -0 lines 1 comment Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 1 chunk +6 lines, -2 lines 1 comment Download
M tryton/gui/window/win_form.py View 1 2 3 3 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 11
nicoe
4 months, 2 weeks ago (2017-07-10 12:54:30 UTC) #1
nicoe
Add changelog
4 months, 2 weeks ago (2017-07-10 12:55:19 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
4 months, 2 weeks ago (2017-07-10 13:04:29 UTC) #3
ced
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) should not signal be False? https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) ...
4 months, 2 weeks ago (2017-07-10 14:49:13 UTC) #4
nicoe
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) On 2017/07/10 14:49:12, ced wrote: > should not ...
2 months ago (2017-09-22 12:10:29 UTC) #5
nicoe
Fix icon when the record will be deleted
2 months ago (2017-09-22 12:10:55 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
2 months ago (2017-09-22 12:24:47 UTC) #7
ced
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) On 2017/09/22 12:10:29, nicoe wrote: > On 2017/07/10 ...
2 months ago (2017-09-25 20:21:31 UTC) #8
nicoe
Correctly set icon in popup and fix issue with on_change on fields
1 month, 4 weeks ago (2017-09-26 15:56:25 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
1 month, 4 weeks ago (2017-09-26 16:15:27 UTC) #10
ced
1 week, 4 days ago (2017-11-13 10:06:04 UTC) #11
https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form...
File tryton/gui/window/view_form/model/record.py (right):

https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form...
tryton/gui/window/view_form/model/record.py:512: self.on_change_with(fieldnames)
Should we really need to call on_change's?
Normally the value should be consistent?
Indeed it is only the parent's on_change that should be needed, for example to
update the total_amount of the sale.

https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form...
File tryton/gui/window/view_form/screen/screen.py (right):

https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form...
tryton/gui/window/view_form/screen/screen.py:589:
self.current_record.signal('record-changed')
I think the signal should be triggered in reset method.

https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/win_form.py
File tryton/gui/window/win_form.py (right):

https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/win_form....
tryton/gui/window/win_form.py:58: self._initial_value =
self.screen.current_record.get_eval()
Should not the initial value be stored after the display?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922