Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 36451002: tryton: Reset record to its original state when discarding the popup window (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by nicoe
Modified:
4 months, 4 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add changelog #

Total comments: 14

Patch Set 3 : Fix icon when the record will be deleted #

Total comments: 1

Patch Set 4 : Correctly set icon in popup and fix issue with on_change on fields #

Total comments: 6

Patch Set 5 : move signal and trigger on parent onchanges #

Patch Set 6 : fix typo #

Total comments: 2

Patch Set 7 : Always store initial_value when not creating a new record #

Patch Set 8 : better test on winform init #

Patch Set 9 : fix on_change call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/model/record.py View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -2 lines 0 comments Download
M tryton/gui/window/win_form.py View 1 2 3 4 5 6 7 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 27
nicoe
1 year, 1 month ago (2017-07-10 12:54:30 UTC) #1
nicoe
Add changelog
1 year, 1 month ago (2017-07-10 12:55:19 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
1 year, 1 month ago (2017-07-10 13:04:29 UTC) #3
ced
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) should not signal be False? https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) ...
1 year, 1 month ago (2017-07-10 14:49:13 UTC) #4
nicoe
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) On 2017/07/10 14:49:12, ced wrote: > should not ...
11 months ago (2017-09-22 12:10:29 UTC) #5
nicoe
Fix icon when the record will be deleted
11 months ago (2017-09-22 12:10:55 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
11 months ago (2017-09-22 12:24:47 UTC) #7
ced
https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://tryton-rietveld.appspot.com/36451002/diff/20001/tryton/gui/window/view_form/model/record.py#newcode508 tryton/gui/window/view_form/model/record.py:508: self.set(value) On 2017/09/22 12:10:29, nicoe wrote: > On 2017/07/10 ...
10 months, 3 weeks ago (2017-09-25 20:21:31 UTC) #8
nicoe
Correctly set icon in popup and fix issue with on_change on fields
10 months, 3 weeks ago (2017-09-26 15:56:25 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
10 months, 3 weeks ago (2017-09-26 16:15:27 UTC) #10
ced
https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form/model/record.py#newcode512 tryton/gui/window/view_form/model/record.py:512: self.on_change_with(fieldnames) Should we really need to call on_change's? Normally ...
9 months, 1 week ago (2017-11-13 10:06:04 UTC) #11
nicoe
https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): https://codereview.tryton.org/36451002/diff/60001/tryton/gui/window/view_form/model/record.py#newcode512 tryton/gui/window/view_form/model/record.py:512: self.on_change_with(fieldnames) On 2017/11/13 10:06:03, ced wrote: > Should we ...
8 months, 1 week ago (2017-12-09 16:31:06 UTC) #12
nicoe
move signal and trigger on parent onchanges
8 months, 1 week ago (2017-12-09 16:44:07 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
8 months, 1 week ago (2017-12-09 16:48:00 UTC) #14
nicoe
fix typo
8 months, 1 week ago (2017-12-11 09:59:46 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
8 months, 1 week ago (2017-12-11 10:18:14 UTC) #16
ced
https://codereview.tryton.org/36451002/diff/100001/tryton/gui/window/win_form.py File tryton/gui/window/win_form.py (right): https://codereview.tryton.org/36451002/diff/100001/tryton/gui/window/win_form.py#newcode276 tryton/gui/window/win_form.py:276: if not new and self.screen.current_record.id < 0: Should not ...
6 months ago (2018-02-13 17:56:45 UTC) #17
nicoe
https://codereview.tryton.org/36451002/diff/100001/tryton/gui/window/win_form.py File tryton/gui/window/win_form.py (right): https://codereview.tryton.org/36451002/diff/100001/tryton/gui/window/win_form.py#newcode276 tryton/gui/window/win_form.py:276: if not new and self.screen.current_record.id < 0: On 2018/02/13 ...
5 months, 3 weeks ago (2018-02-28 14:41:54 UTC) #18
nicoe
Always store initial_value when not creating a new record
5 months, 3 weeks ago (2018-02-28 17:42:47 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
5 months, 3 weeks ago (2018-02-28 17:44:43 UTC) #20
ced
LGTM but waiting sao patch.
5 months, 3 weeks ago (2018-02-28 17:55:23 UTC) #21
nicoe
better test on winform init
5 months ago (2018-03-21 18:04:16 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
4 months, 4 weeks ago (2018-03-21 18:21:33 UTC) #23
ced
LGTM
4 months, 4 weeks ago (2018-03-21 18:32:18 UTC) #24
nicoe
fix on_change call
4 months, 4 weeks ago (2018-03-22 12:44:15 UTC) #25
reviewbot
flake8 OK URL: https://codereview.tryton.org/36451002
4 months, 4 weeks ago (2018-03-22 12:55:06 UTC) #26
rietveld-bot_tryton.org
4 months, 4 weeks ago (2018-03-23 15:38:47 UTC) #27
New changeset 455556b78d08 by Nicolas ?vrard in branch 'default':
Reset record to its original state when discarding the popup window
http://hg.tryton.org/tryton/rev/455556b78d08
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69