Issue 364601002: country: Support pycountry 22.1.10

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 364601002: country: Support pycountry 22.1.10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year ago by raimon

Modified:
1 year ago

Reviewers:
udono, reviewbot, rietveld-bot, ced, pokoli

Visibility:
Public.

More Reviews

Description

issue11128 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 2 : Add changelog entry #

Created: 1 year ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	CHANGELOG	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	country.py	View		4 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

pokoli

The commit message should include a verb. Also we need a CHANGELOG entry

1 year ago (2022-01-17 11:24:14 UTC) #4

pokoli

https://codereview.tryton.org/364601002/diff/374671002/country.py File country.py (right): https://codereview.tryton.org/364601002/diff/374671002/country.py#newcode200 country.py:200: ('popularates', 'Popularates'), This should be removed. See: https://discuss.tryton.org/t/pycountry-22-1-11-new-subdivision-types-break-country-importation-script/4924?u=pokoli for ...

1 year ago (2022-01-17 11:25:56 UTC) #5

ced

1 year ago (2022-01-17 17:27:51 UTC) #6

rietveld-bot_tryton.org

1 year ago (2022-01-20 22:10:02 UTC) #9

New changeset b80f8e665d09 by Raimon Esteve in branch 'default':
Support pycountry 22.1.10
https://hg.tryton.org/modules/country/rev/b80f8e665d09

Expand All Messages | Collapse All Messages