Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 364601002: country: Support pycountry 22.1.10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by raimon
Modified:
1 year ago
Reviewers:
udono, reviewbot, rietveld-bot, ced, pokoli
Visibility:
Public.

Description

issue11128 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add changelog entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M country.py View 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 9
raimon
1 year ago (2022-01-11 10:09:25 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/364601002
1 year ago (2022-01-11 10:15:45 UTC) #2
udono
LGTM
1 year ago (2022-01-12 08:22:31 UTC) #3
pokoli
The commit message should include a verb. Also we need a CHANGELOG entry
1 year ago (2022-01-17 11:24:14 UTC) #4
pokoli
https://codereview.tryton.org/364601002/diff/374671002/country.py File country.py (right): https://codereview.tryton.org/364601002/diff/374671002/country.py#newcode200 country.py:200: ('popularates', 'Popularates'), This should be removed. See: https://discuss.tryton.org/t/pycountry-22-1-11-new-subdivision-types-break-country-importation-script/4924?u=pokoli for ...
1 year ago (2022-01-17 11:25:56 UTC) #5
ced
https://codereview.tryton.org/364601002/diff/374671002/country.py File country.py (right): https://codereview.tryton.org/364601002/diff/374671002/country.py#newcode200 country.py:200: ('popularates', 'Popularates'), On 2022/01/17 11:25:56, pokoli wrote: > This ...
1 year ago (2022-01-17 17:27:51 UTC) #6
ced
1 year ago (2022-01-17 17:49:32 UTC) #7
reviewbot
checks OK URL: https://codereview.tryton.org/364601002
1 year ago (2022-01-17 18:12:42 UTC) #8
rietveld-bot_tryton.org
1 year ago (2022-01-20 22:10:02 UTC) #9
New changeset b80f8e665d09 by Raimon Esteve in branch 'default':
Support pycountry 22.1.10
https://hg.tryton.org/modules/country/rev/b80f8e665d09
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted