Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 36621002: trytond: Ensure that all buttons are registered in ir.model.button (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 4 weeks ago by pokoli
Modified:
2 months, 2 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove button cache and support missing button #

Patch Set 3 : Update to tip, and fix typo #

Patch Set 4 : Update to tip #

Patch Set 5 : Reupload without neste for easier review #

Total comments: 1

Patch Set 6 : Simplify element setting code #

Patch Set 7 : Update docs #

Total comments: 3

Patch Set 8 : Add cache for buttons #

Total comments: 3

Patch Set 9 : -Cache only attributes, do not depend on context #

Total comments: 2

Patch Set 10 : Fix comments and add new buttons #

Total comments: 1

Patch Set 11 : Note that ir.model.button values can be overriden #

Unified diffs Side-by-side diffs Delta from patch set Stats (+868 lines, -293 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/views/index.rst View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -2 lines 0 comments Download
M trytond/ir/cron.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/ir/model.py View 1 2 3 4 5 6 7 8 9 6 chunks +32 lines, -0 lines 0 comments Download
M trytond/ir/model.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/ir/module.xml View 1 chunk +31 lines, -0 lines 0 comments Download
M trytond/ir/ui/form.rnc View 1 chunk +1 line, -2 lines 0 comments Download
M trytond/ir/ui/form.rng View 1 2 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/ui/tree.rnc View 1 chunk +1 line, -2 lines 0 comments Download
M trytond/ir/ui/tree.rng View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/ui/view.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/ir/view/cron_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/model_button_form.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/ir/view/model_data_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/model_data_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/ui_view_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/model/modelview.py View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account/fiscalyear.xml View 1 2 3 5 6 7 8 9 1 chunk +32 lines, -0 lines 0 comments Download
M trytond/modules/account/journal.xml View 1 2 3 5 6 7 8 9 1 chunk +15 lines, -0 lines 0 comments Download
M trytond/modules/account/move.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account/period.xml View 1 2 3 5 6 7 8 9 1 chunk +26 lines, -0 lines 0 comments Download
M trytond/modules/account/view/fiscalyear_form.xml View 1 2 3 5 6 7 8 9 1 chunk +2 lines, -4 lines 0 comments Download
M trytond/modules/account/view/fiscalyear_list_close.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -4 lines 0 comments Download
M trytond/modules/account/view/move_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account/view/move_tree.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account/view/period_list_close.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -4 lines 0 comments Download
M trytond/modules/account_asset/asset.xml View 1 2 3 5 6 7 8 9 1 chunk +31 lines, -0 lines 0 comments Download
M trytond/modules/account_asset/view/asset_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -14 lines 0 comments Download
M trytond/modules/account_deposit/invoice.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/account_deposit/view/invoice_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account_invoice/invoice.xml View 1 2 3 4 5 6 7 8 9 5 chunks +8 lines, -0 lines 0 comments Download
M trytond/modules/account_invoice/view/invoice_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -11 lines 0 comments Download
M trytond/modules/account_invoice/view/invoice_tree.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -5 lines 0 comments Download
M trytond/modules/account_invoice_correction/invoice.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account_invoice_correction/view/invoice_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account_payment/account.xml View 1 2 3 5 6 7 8 9 3 chunks +3 lines, -0 lines 0 comments Download
M trytond/modules/account_payment/payment.xml View 1 2 3 5 6 7 8 9 4 chunks +4 lines, -0 lines 0 comments Download
M trytond/modules/account_payment/view/move_line_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -5 lines 0 comments Download
M trytond/modules/account_payment/view/payment_form.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/account_payment/view/payment_list.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/account_payment_clearing/payment.xml View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_sepa/payment.xml View 1 2 3 5 6 7 8 9 2 chunks +64 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_sepa/view/mandate_form.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -5 lines 0 comments Download
M trytond/modules/account_payment_sepa/view/message_form.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/account_payment_sepa/view/message_list.xml View 1 2 3 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/account_payment_sepa/view/payment_group_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account_payment_stripe/payment.xml View 1 2 3 4 5 6 7 8 9 3 chunks +25 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_stripe/view/account_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M trytond/modules/account_payment_stripe/view/customer_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/account_payment_stripe/view/customer_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/account_payment_stripe/view/payment_form.xml View 1 2 3 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/account_payment_stripe/view/payment_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -4 lines 0 comments Download
M trytond/modules/account_statement/statement.xml View 1 2 3 4 5 6 7 8 9 5 chunks +17 lines, -0 lines 0 comments Download
M trytond/modules/account_statement/view/statement_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -7 lines 0 comments Download
M trytond/modules/account_stock_landed_cost/account.xml View 1 2 3 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
M trytond/modules/account_stock_landed_cost/view/landed_cost_form.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/modules/commission/commission.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/commission/view/commission_list.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/product_price_list_dates/product.xml View 1 2 3 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/modules/product_price_list_dates/view/price_list_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/production/production.xml View 1 2 3 5 6 7 8 9 7 chunks +12 lines, -0 lines 0 comments Download
M trytond/modules/production/view/production_form.xml View 1 2 3 5 6 7 8 9 1 chunk +7 lines, -12 lines 0 comments Download
M trytond/modules/production_split/production.xml View 1 2 3 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/modules/production_split/view/production_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/production_work/view/work_cycle_form.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/modules/production_work/work.xml View 1 2 3 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
M trytond/modules/project_invoice/view/work_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/project_invoice/work.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/purchase/purchase.xml View 1 2 3 4 5 6 7 8 9 6 chunks +30 lines, -0 lines 0 comments Download
M trytond/modules/purchase/view/purchase_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -16 lines 0 comments Download
M trytond/modules/purchase_request/purchase_request.xml View 1 2 3 5 6 7 8 9 1 chunk +8 lines, -1 line 0 comments Download
M trytond/modules/purchase_request/view/purchase_request_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/purchase_requisition/purchase.xml View 1 2 3 5 6 7 8 9 2 chunks +5 lines, -0 lines 0 comments Download
M trytond/modules/purchase_requisition/view/purchase_requisition_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -6 lines 0 comments Download
M trytond/modules/sale/sale.xml View 1 2 3 4 5 6 7 8 9 5 chunks +28 lines, -0 lines 0 comments Download
M trytond/modules/sale/view/sale_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -14 lines 0 comments Download
M trytond/modules/sale_complaint/complaint.xml View 1 2 3 5 6 7 8 9 6 chunks +6 lines, -0 lines 0 comments Download
M trytond/modules/sale_complaint/view/complaint_form.xml View 1 2 3 5 6 7 8 9 1 chunk +6 lines, -6 lines 0 comments Download
M trytond/modules/sale_opportunity/opportunity.xml View 1 2 3 5 6 7 8 9 5 chunks +5 lines, -0 lines 0 comments Download
M trytond/modules/sale_opportunity/view/opportunity_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -11 lines 0 comments Download
M trytond/modules/sale_subscription/subscription.xml View 1 2 3 5 6 7 8 9 3 chunks +16 lines, -0 lines 0 comments Download
M trytond/modules/sale_subscription/view/subscription_form.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/sale_supply_drop_shipment/stock.xml View 1 2 3 5 6 7 8 9 4 chunks +15 lines, -4 lines 0 comments Download
M trytond/modules/sale_supply_drop_shipment/view/shipment_drop_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -5 lines 0 comments Download
M trytond/modules/stock/inventory.xml View 1 2 3 5 6 7 8 9 3 chunks +9 lines, -0 lines 0 comments Download
M trytond/modules/stock/move.xml View 1 2 3 4 5 6 7 8 9 1 chunk +22 lines, -0 lines 0 comments Download
M trytond/modules/stock/period.xml View 1 2 3 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M trytond/modules/stock/shipment.xml View 1 2 3 5 6 7 8 9 25 chunks +31 lines, -0 lines 0 comments Download
M trytond/modules/stock/view/inventory_form.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -5 lines 0 comments Download
M trytond/modules/stock/view/move_form.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/modules/stock/view/move_tree.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/modules/stock/view/period_form.xml View 1 2 3 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/stock/view/shipment_in_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/stock/view/shipment_in_return_form.xml View 1 2 3 5 6 7 8 9 1 chunk +5 lines, -5 lines 0 comments Download
M trytond/modules/stock/view/shipment_internal_form.xml View 1 2 3 5 6 7 8 9 1 chunk +6 lines, -6 lines 0 comments Download
M trytond/modules/stock/view/shipment_out_form.xml View 1 2 3 5 6 7 8 9 1 chunk +6 lines, -7 lines 0 comments Download
M trytond/modules/stock/view/shipment_out_return_form.xml View 1 2 3 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M trytond/modules/stock_forecast/forecast.xml View 1 2 3 5 6 7 8 9 4 chunks +8 lines, -0 lines 0 comments Download
M trytond/modules/stock_forecast/view/forecast_form.xml View 1 2 3 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/modules/stock_package_shipping/stock.xml View 1 2 3 5 6 7 8 9 1 chunk +8 lines, -10 lines 0 comments Download
M trytond/modules/stock_package_shipping/view/shipment_out_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/stock_split/stock.xml View 1 2 3 4 5 6 7 8 9 2 chunks +23 lines, -0 lines 0 comments Download
M trytond/modules/stock_split/view/move_form.xml View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/stock_split/view/shipment_split_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/web_user/user.xml View 1 2 3 5 6 7 8 9 1 chunk +11 lines, -0 lines 0 comments Download
M trytond/modules/web_user/view/user_form.xml View 1 2 3 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/res/ir.xml View 1 chunk +16 lines, -40 lines 0 comments Download
M trytond/res/user.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M trytond/res/view/user_application_form.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/res/view/user_application_list.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/tests/test_modelview.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M trytond/tests/test_tryton.py View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 63
pokoli
7 months, 4 weeks ago (2017-09-23 21:16:35 UTC) #1
reviewbot
https://codereview.tryton.org/36621002/diff/1/trytond/tests/test_tryton.py#newcode601 trytond/tests/test_tryton.py:601: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/1/trytond/tests/test_tryton.py#newcode602 trytond/tests/test_tryton.py:602: E731 ...
7 months, 4 weeks ago (2017-09-23 21:21:53 UTC) #2
ced
https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/model.py File trytond/ir/model.py (right): https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/model.py#newcode799 trytond/ir/model.py:799: cls._button_cache.set(key, button.id) There are not much optimization here: the ...
7 months, 3 weeks ago (2017-09-25 20:48:22 UTC) #3
pokoli
Remove button cache and support missing button
7 months, 3 weeks ago (2017-09-26 13:09:24 UTC) #4
pokoli
https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/ui/form.rng File trytond/ir/ui/form.rng (right): https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/ui/form.rng#newcode368 trytond/ir/ui/form.rng:368: <attribute name="toolbar" a:defaultValue="0"> On 2017/09/25 20:48:22, ced wrote: > ...
7 months, 3 weeks ago (2017-09-26 13:09:27 UTC) #5
reviewbot
https://codereview.tryton.org/36621002/diff/20001/trytond/tests/test_tryton.py#newcode601 trytond/tests/test_tryton.py:601: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/20001/trytond/tests/test_tryton.py#newcode602 trytond/tests/test_tryton.py:602: E731 ...
7 months, 3 weeks ago (2017-09-26 13:11:26 UTC) #6
pokoli
Update to tip, and fix typo
7 months, 3 weeks ago (2017-09-30 17:05:19 UTC) #7
reviewbot
https://codereview.tryton.org/36621002/diff/40001/trytond/tests/test_tryton.py#newcode618 trytond/tests/test_tryton.py:618: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/40001/trytond/tests/test_tryton.py#newcode619 trytond/tests/test_tryton.py:619: E731 ...
7 months, 3 weeks ago (2017-09-30 17:10:25 UTC) #8
pokoli
Update to tip
6 months, 1 week ago (2017-11-10 08:57:02 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/36621002
6 months, 1 week ago (2017-11-10 09:10:28 UTC) #10
pokoli
Reupload without neste for easier review
6 months, 1 week ago (2017-11-10 10:05:36 UTC) #11
ced
https://codereview.tryton.org/36621002/diff/80001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/80001/trytond/model/modelview.py#newcode553 trytond/model/modelview.py:553: element.set(attr, value) Probably more readable like this: for...: if ...
6 months, 1 week ago (2017-11-10 10:09:24 UTC) #12
pokoli
Simplify element setting code
6 months, 1 week ago (2017-11-10 10:24:59 UTC) #13
reviewbot
https://codereview.tryton.org/36621002/diff/100001/trytond/tests/test_tryton.py#newcode623 trytond/tests/test_tryton.py:623: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/100001/trytond/tests/test_tryton.py#newcode624 trytond/tests/test_tryton.py:624: E731 ...
6 months, 1 week ago (2017-11-10 10:38:02 UTC) #14
ced
Missing doc update
6 months, 1 week ago (2017-11-10 10:48:59 UTC) #15
pokoli
Update docs
6 months, 1 week ago (2017-11-10 10:54:36 UTC) #16
reviewbot
https://codereview.tryton.org/36621002/diff/120001/trytond/tests/test_tryton.py#newcode623 trytond/tests/test_tryton.py:623: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/120001/trytond/tests/test_tryton.py#newcode624 trytond/tests/test_tryton.py:624: E731 ...
6 months, 1 week ago (2017-11-10 11:02:13 UTC) #17
ced
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) For performance reason, this should be managed ...
5 months, 3 weeks ago (2017-11-27 11:46:35 UTC) #18
pokoli
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) On 2017/11/27 11:46:35, ced wrote: > For ...
5 months, 3 weeks ago (2017-11-27 13:07:49 UTC) #19
ced
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) On 2017/11/27 13:07:49, pokoli wrote: > On ...
5 months, 3 weeks ago (2017-11-27 13:45:21 UTC) #20
pokoli
Add cache for buttons
5 months, 3 weeks ago (2017-11-27 15:20:47 UTC) #21
reviewbot
https://codereview.tryton.org/36621002/diff/130001/trytond/tests/test_tryton.py#newcode631 trytond/tests/test_tryton.py:631: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/130001/trytond/tests/test_tryton.py#newcode632 trytond/tests/test_tryton.py:632: E731 ...
5 months, 3 weeks ago (2017-11-27 15:37:35 UTC) #22
ced
https://codereview.tryton.org/36621002/diff/130001/trytond/ir/model.py File trytond/ir/model.py (right): https://codereview.tryton.org/36621002/diff/130001/trytond/ir/model.py#newcode739 trytond/ir/model.py:739: _button_cache = Cache('ir.model.button') I do not think it should ...
4 months, 2 weeks ago (2018-01-02 12:36:28 UTC) #23
pokoli
-Cache only attributes, do not depend on context
3 months, 3 weeks ago (2018-01-24 16:11:44 UTC) #24
reviewbot
https://codereview.tryton.org/36621002/diff/150001/trytond/tests/test_tryton.py#newcode637 trytond/tests/test_tryton.py:637: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/150001/trytond/tests/test_tryton.py#newcode638 trytond/tests/test_tryton.py:638: E731 ...
3 months, 3 weeks ago (2018-01-24 16:36:21 UTC) #25
ced
https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py File trytond/ir/model.py (right): https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcode853 trytond/ir/model.py:853: key = (model, name) The key should contain the ...
2 months, 3 weeks ago (2018-02-27 00:05:09 UTC) #26
pokoli
Fix comments and add new buttons
2 months, 3 weeks ago (2018-02-28 11:59:05 UTC) #27
reviewbot
patch is not applicable URL: https://codereview.tryton.org/36621002
2 months, 3 weeks ago (2018-02-28 12:14:00 UTC) #28
ced
https://codereview.tryton.org/36621002/diff/170001/doc/topics/views/index.rst File doc/topics/views/index.rst (right): https://codereview.tryton.org/36621002/diff/170001/doc/topics/views/index.rst#newcode347 doc/topics/views/index.rst:347: * ``help``: see in common-attributes-help_. Indeed they can still ...
2 months, 3 weeks ago (2018-02-28 15:46:50 UTC) #29
pokoli
Note that ir.model.button values can be overriden
2 months, 3 weeks ago (2018-02-28 16:59:11 UTC) #30
ced
LGTM
2 months, 3 weeks ago (2018-02-28 17:18:38 UTC) #31
reviewbot
patch is not applicable URL: https://codereview.tryton.org/36621002
2 months, 3 weeks ago (2018-02-28 17:23:43 UTC) #32
rietveld-bot_tryton.org
New changeset 83757dc87808 by Sergi Almacellas Abellana in branch 'default': Ensure that all buttons are ...
2 months, 2 weeks ago (2018-03-01 11:59:24 UTC) #33
rietveld-bot_tryton.org
New changeset 75f7d4cb0fbf by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:29 UTC) #34
rietveld-bot_tryton.org
New changeset bfd7f75ca0cb by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:32 UTC) #35
rietveld-bot_tryton.org
New changeset 1a209a178206 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:35 UTC) #36
rietveld-bot_tryton.org
New changeset 5cf3640ae145 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:40 UTC) #37
rietveld-bot_tryton.org
New changeset cc3b7e404866 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:41 UTC) #38
rietveld-bot_tryton.org
New changeset 5a5e84a302d5 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:45 UTC) #39
rietveld-bot_tryton.org
New changeset 1176da9202bd by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:47 UTC) #40
rietveld-bot_tryton.org
New changeset 4ed8e029c139 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:49 UTC) #41
rietveld-bot_tryton.org
New changeset f8805ab5e29d by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:54 UTC) #42
rietveld-bot_tryton.org
New changeset 6586237b5f8a by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 11:59:57 UTC) #43
rietveld-bot_tryton.org
New changeset c8724dbd90ca by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:06 UTC) #44
rietveld-bot_tryton.org
New changeset b321fabd7d3c by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:16 UTC) #45
rietveld-bot_tryton.org
New changeset 242b81644187 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:29 UTC) #46
rietveld-bot_tryton.org
New changeset ba3c1c1e4d0b by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:34 UTC) #47
rietveld-bot_tryton.org
New changeset b1264b80cf81 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:38 UTC) #48
rietveld-bot_tryton.org
New changeset 78e7b71ce9d4 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:41 UTC) #49
rietveld-bot_tryton.org
New changeset 62fecb4a4a3f by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:44 UTC) #50
rietveld-bot_tryton.org
New changeset ca15a59c14d1 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:47 UTC) #51
rietveld-bot_tryton.org
New changeset e6ac7151e40a by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:51 UTC) #52
rietveld-bot_tryton.org
New changeset 4de32c8e1568 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:53 UTC) #53
rietveld-bot_tryton.org
New changeset 8d9a7f10cf5e by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:00:56 UTC) #54
rietveld-bot_tryton.org
New changeset 1d04c484b6fa by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:00 UTC) #55
rietveld-bot_tryton.org
New changeset 086f805b892e by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:02 UTC) #56
rietveld-bot_tryton.org
New changeset 543991600421 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:08 UTC) #57
rietveld-bot_tryton.org
New changeset 7ec6f0035e3c by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:11 UTC) #58
rietveld-bot_tryton.org
New changeset f5e02ae4fd6d by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:15 UTC) #59
rietveld-bot_tryton.org
New changeset 038ea2ff97ec by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:18 UTC) #60
rietveld-bot_tryton.org
New changeset 34a9612c2e6a by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:24 UTC) #61
rietveld-bot_tryton.org
New changeset 22da6f650b18 by Sergi Almacellas Abellana in branch 'default': Register all buttons are registered ...
2 months, 2 weeks ago (2018-03-01 12:01:29 UTC) #62
rietveld-bot_tryton.org
2 months, 2 weeks ago (2018-03-01 12:01:37 UTC) #63
New changeset cb87f4bb161f by Sergi Almacellas Abellana in branch 'default':
Register all buttons are registered in ir.model.button
http://hg.tryton.org/modules/web_user/rev/cb87f4bb161f
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922