Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(182)

Issue 36621002: trytond: Ensure that all buttons are registered in ir.model.button

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by pokoli
Modified:
1 month ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove button cache and support missing button #

Patch Set 3 : Update to tip, and fix typo #

Patch Set 4 : Update to tip #

Patch Set 5 : Reupload without neste for easier review #

Total comments: 1

Patch Set 6 : Simplify element setting code #

Patch Set 7 : Update docs #

Total comments: 3

Patch Set 8 : Add cache for buttons #

Total comments: 3

Patch Set 9 : -Cache only attributes, do not depend on context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -58 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/views/index.rst View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -2 lines 0 comments Download
M trytond/ir/cron.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/ir/model.py View 1 2 3 4 5 6 7 8 6 chunks +32 lines, -0 lines 0 comments Download
M trytond/ir/model.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/ir/module.xml View 1 chunk +31 lines, -0 lines 0 comments Download
M trytond/ir/ui/form.rnc View 1 chunk +1 line, -2 lines 0 comments Download
M trytond/ir/ui/form.rng View 1 2 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/ui/tree.rnc View 1 chunk +1 line, -2 lines 0 comments Download
M trytond/ir/ui/tree.rng View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/ui/view.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/ir/view/cron_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/model_button_form.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/ir/view/model_data_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/model_data_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/ir/view/ui_view_form.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/model/modelview.py View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/res/ir.xml View 1 chunk +16 lines, -40 lines 0 comments Download
M trytond/res/user.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M trytond/res/view/user_application_form.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/res/view/user_application_list.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/tests/test_modelview.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M trytond/tests/test_tryton.py View 1 2 3 4 5 6 7 8 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 25
pokoli
5 months ago (2017-09-23 21:16:35 UTC) #1
reviewbot
https://codereview.tryton.org/36621002/diff/1/trytond/tests/test_tryton.py#newcode601 trytond/tests/test_tryton.py:601: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/1/trytond/tests/test_tryton.py#newcode602 trytond/tests/test_tryton.py:602: E731 ...
5 months ago (2017-09-23 21:21:53 UTC) #2
ced
https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/model.py File trytond/ir/model.py (right): https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/model.py#newcode799 trytond/ir/model.py:799: cls._button_cache.set(key, button.id) There are not much optimization here: the ...
5 months ago (2017-09-25 20:48:22 UTC) #3
pokoli
Remove button cache and support missing button
5 months ago (2017-09-26 13:09:24 UTC) #4
pokoli
https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/ui/form.rng File trytond/ir/ui/form.rng (right): https://tryton-rietveld.appspot.com/36621002/diff/1/trytond/ir/ui/form.rng#newcode368 trytond/ir/ui/form.rng:368: <attribute name="toolbar" a:defaultValue="0"> On 2017/09/25 20:48:22, ced wrote: > ...
5 months ago (2017-09-26 13:09:27 UTC) #5
reviewbot
https://codereview.tryton.org/36621002/diff/20001/trytond/tests/test_tryton.py#newcode601 trytond/tests/test_tryton.py:601: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/20001/trytond/tests/test_tryton.py#newcode602 trytond/tests/test_tryton.py:602: E731 ...
5 months ago (2017-09-26 13:11:26 UTC) #6
pokoli
Update to tip, and fix typo
4 months, 4 weeks ago (2017-09-30 17:05:19 UTC) #7
reviewbot
https://codereview.tryton.org/36621002/diff/40001/trytond/tests/test_tryton.py#newcode618 trytond/tests/test_tryton.py:618: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/40001/trytond/tests/test_tryton.py#newcode619 trytond/tests/test_tryton.py:619: E731 ...
4 months, 4 weeks ago (2017-09-30 17:10:25 UTC) #8
pokoli
Update to tip
3 months, 2 weeks ago (2017-11-10 08:57:02 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/36621002
3 months, 2 weeks ago (2017-11-10 09:10:28 UTC) #10
pokoli
Reupload without neste for easier review
3 months, 2 weeks ago (2017-11-10 10:05:36 UTC) #11
ced
https://codereview.tryton.org/36621002/diff/80001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/80001/trytond/model/modelview.py#newcode553 trytond/model/modelview.py:553: element.set(attr, value) Probably more readable like this: for...: if ...
3 months, 2 weeks ago (2017-11-10 10:09:24 UTC) #12
pokoli
Simplify element setting code
3 months, 2 weeks ago (2017-11-10 10:24:59 UTC) #13
reviewbot
https://codereview.tryton.org/36621002/diff/100001/trytond/tests/test_tryton.py#newcode623 trytond/tests/test_tryton.py:623: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/100001/trytond/tests/test_tryton.py#newcode624 trytond/tests/test_tryton.py:624: E731 ...
3 months, 2 weeks ago (2017-11-10 10:38:02 UTC) #14
ced
Missing doc update
3 months, 2 weeks ago (2017-11-10 10:48:59 UTC) #15
pokoli
Update docs
3 months, 2 weeks ago (2017-11-10 10:54:36 UTC) #16
reviewbot
https://codereview.tryton.org/36621002/diff/120001/trytond/tests/test_tryton.py#newcode623 trytond/tests/test_tryton.py:623: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/120001/trytond/tests/test_tryton.py#newcode624 trytond/tests/test_tryton.py:624: E731 ...
3 months, 2 weeks ago (2017-11-10 11:02:13 UTC) #17
ced
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) For performance reason, this should be managed ...
3 months ago (2017-11-27 11:46:35 UTC) #18
pokoli
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) On 2017/11/27 11:46:35, ced wrote: > For ...
3 months ago (2017-11-27 13:07:49 UTC) #19
ced
https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py File trytond/model/modelview.py (right): https://codereview.tryton.org/36621002/diff/120001/trytond/model/modelview.py#newcode545 trytond/model/modelview.py:545: ], limit=1) On 2017/11/27 13:07:49, pokoli wrote: > On ...
3 months ago (2017-11-27 13:45:21 UTC) #20
pokoli
Add cache for buttons
3 months ago (2017-11-27 15:20:47 UTC) #21
reviewbot
https://codereview.tryton.org/36621002/diff/130001/trytond/tests/test_tryton.py#newcode631 trytond/tests/test_tryton.py:631: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/36621002/diff/130001/trytond/tests/test_tryton.py#newcode632 trytond/tests/test_tryton.py:632: E731 ...
3 months ago (2017-11-27 15:37:35 UTC) #22
ced
https://codereview.tryton.org/36621002/diff/130001/trytond/ir/model.py File trytond/ir/model.py (right): https://codereview.tryton.org/36621002/diff/130001/trytond/ir/model.py#newcode739 trytond/ir/model.py:739: _button_cache = Cache('ir.model.button') I do not think it should ...
1 month, 3 weeks ago (2018-01-02 12:36:28 UTC) #23
pokoli
-Cache only attributes, do not depend on context
1 month ago (2018-01-24 16:11:44 UTC) #24
reviewbot
1 month ago (2018-01-24 16:36:21 UTC) #25
https://codereview.tryton.org/36621002/diff/150001/trytond/tests/test_tryton....
trytond/tests/test_tryton.py:637:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/36621002/diff/150001/trytond/tests/test_tryton....
trytond/tests/test_tryton.py:638:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcode97
trytond/ir/model.py:97:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcod...
trytond/ir/model.py:249:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcod...
trytond/ir/model.py:454:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcod...
trytond/ir/model.py:644:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcod...
trytond/ir/model.py:644:
E203 whitespace before ','

https://codereview.tryton.org/36621002/diff/150001/trytond/ir/model.py#newcod...
trytond/ir/model.py:1085:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/36621002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922