Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 36861002: stock: Set inventory lines readonly until inventory date and location are filled (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by mrichez
Modified:
7 months, 2 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Date and location fields are required but become readonly when you start filling lines manually even if those fields are not filled. When you save your inventory, you have to delete all your lines to fill those mandatory fields... issue6978

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use global STATES #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M inventory.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8
mrichez
7 months, 3 weeks ago (2017-11-30 14:47:24 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/36861002
7 months, 3 weeks ago (2017-11-30 15:08:13 UTC) #2
ced
The description could explain why it is needed. https://codereview.tryton.org/36861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/36861002/diff/1/inventory.py#newcode45 inventory.py:45: 'readonly': ...
7 months, 3 weeks ago (2017-12-02 11:29:12 UTC) #3
mrichez
https://codereview.tryton.org/36861002/diff/1/inventory.py File inventory.py (right): https://codereview.tryton.org/36861002/diff/1/inventory.py#newcode45 inventory.py:45: 'readonly': ((Eval('state') != 'draft') | ~Eval('location') On 2017/12/02 11:29:12, ...
7 months, 3 weeks ago (2017-12-04 09:18:18 UTC) #4
mrichez
Use global STATES
7 months, 3 weeks ago (2017-12-04 09:19:26 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/36861002
7 months, 3 weeks ago (2017-12-04 09:43:38 UTC) #6
ced
LGTM
7 months, 2 weeks ago (2017-12-10 11:44:12 UTC) #7
rietveld-bot_tryton.org
7 months, 2 weeks ago (2017-12-10 11:45:16 UTC) #8
New changeset 625ac84f8cba by Maxime Richez in branch 'default':
Set inventory lines readonly until inventory date and location are filled
http://hg.tryton.org/modules/stock/rev/625ac84f8cba
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69