Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 37001002: trytond: Use proper SQL types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by ced
Modified:
1 year ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

- When recreating the table to drop a column, the correct SQL type must be converted by the database. - SQLite uses BOOLEAN as base type for BOOL issue7120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M trytond/backend/sqlite/database.py View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/backend/sqlite/table.py View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4
ced
1 year, 1 month ago (2018-02-07 11:46:05 UTC) #1
reviewbot
https://codereview.tryton.org/37001002/diff/1/trytond/backend/sqlite/database.py#newcode24 trytond/backend/sqlite/database.py:24: E402 module level import not at top of file https://codereview.tryton.org/37001002/diff/1/trytond/backend/sqlite/database.py#newcode25 trytond/backend/sqlite/database.py:25: E402 module ...
1 year, 1 month ago (2018-02-07 11:58:55 UTC) #2
rietveld-bot_tryton.org
New changeset abc19def23db by Cédric Krier in branch 'default': Use proper SQL types http://hg.tryton.org/trytond/rev/abc19def23db
1 year ago (2018-02-19 18:07:33 UTC) #3
rietveld-bot_tryton.org
1 year ago (2018-02-25 00:02:43 UTC) #4
New changeset 6f471f768301 by Cédric Krier in branch '4.6':
Use proper SQL types
http://hg.tryton.org/trytond/rev/6f471f768301


New changeset d9aa4b42a99e by Cédric Krier in branch '4.4':
Use proper SQL types
http://hg.tryton.org/trytond/rev/d9aa4b42a99e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766