Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 370091002: tryton-env: Use field's description instead of name in header when exporting from the print toolbar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by Davidoff
Modified:
2 months, 2 weeks ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue9301

Patch Set 1 #

Total comments: 7

Patch Set 2 : Add a classmethod that computes field_description for each exported field #

Patch Set 3 : Update to tip #

Total comments: 7

Patch Set 4 : Reduce number of searches, use proper naming and remove unnecessary tests #

Patch Set 5 : Update to tip #

Total comments: 4

Patch Set 6 : Call directly record.name.split('/'), rename model variable to field where necessary and remove unn… #

Patch Set 7 : Remove whitespaces #

Patch Set 8 : Fix missing pokoli remarks #

Total comments: 6

Patch Set 9 : Test the presence of the key instead of getting it, relation -> model, and delete unnecessary code #

Patch Set 10 : Remove unused import and correct indentation #

Total comments: 6

Patch Set 11 : Remove line break and use dict comprehension #

Patch Set 12 : Save fields' descriptions and relations #

Total comments: 1

Patch Set 13 : Remove print #

Patch Set 14 : Make patch applicable #

Patch Set 15 : Add whitespace after ',' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/tab.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -1 line 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/form.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -1 line 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/export.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +18 lines, -0 lines 0 comments Download
M trytond/trytond/ir/model.py View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +20 lines, -7 lines 0 comments Download
M trytond/trytond/model/modelview.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 37
Davidoff
9 months, 3 weeks ago (2021-10-22 08:00:07 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/370091002
9 months, 3 weeks ago (2021-10-22 08:13:08 UTC) #2
pokoli
https://codereview.tryton.org/370091002/diff/373971003/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/373971003/trytond/trytond/ir/export.py#newcode62 trytond/trytond/ir/export.py:62: @fields.depends('name') depends is not required if it's not an ...
8 months, 2 weeks ago (2021-11-25 10:10:20 UTC) #3
ced
It is missing changelog entries. https://codereview.tryton.org/370091002/diff/373971003/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/373971003/trytond/trytond/ir/export.py#newcode71 trytond/trytond/ir/export.py:71: value, = ModelField.search([ On ...
8 months ago (2021-12-12 23:36:00 UTC) #4
Davidoff
Add a classmethod that computes field_description for each exported field
7 months, 1 week ago (2021-12-30 09:41:34 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/370091002
7 months, 1 week ago (2021-12-30 09:50:04 UTC) #6
Davidoff
Update to tip
7 months, 1 week ago (2021-12-30 10:07:00 UTC) #7
reviewbot
checks OK URL: https://codereview.tryton.org/370091002
7 months, 1 week ago (2021-12-30 10:15:00 UTC) #8
pokoli
https://codereview.tryton.org/370091002/diff/377841003/tryton/CHANGELOG File tryton/CHANGELOG (right): https://codereview.tryton.org/370091002/diff/377841003/tryton/CHANGELOG#newcode1 tryton/CHANGELOG:1: * Use field's description instead of name in header ...
7 months, 1 week ago (2022-01-03 09:55:29 UTC) #9
Davidoff
Reduce number of searches, use proper naming and remove unnecessary tests
7 months ago (2022-01-07 09:25:21 UTC) #10
reviewbot
patch is not applicable URL: https://codereview.tryton.org/370091002
7 months ago (2022-01-07 09:45:35 UTC) #11
Davidoff
Update to tip
7 months ago (2022-01-07 09:54:02 UTC) #12
reviewbot
checks OK URL: https://codereview.tryton.org/370091002
7 months ago (2022-01-07 10:15:50 UTC) #13
pokoli
https://codereview.tryton.org/370091002/diff/395281002/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/395281002/trytond/trytond/ir/export.py#newcode79 trytond/trytond/ir/export.py:79: elif '/' in record.name: there is no need to ...
7 months ago (2022-01-07 10:35:26 UTC) #14
Davidoff
Call directly record.name.split('/'), rename model variable to field where necessary and remove unnecessary code
7 months ago (2022-01-07 12:52:01 UTC) #15
reviewbot
https://codereview.tryton.org/370091002/diff/389661002/trytond/trytond/ir/export.py#newcode74 trytond/trytond/ir/export.py:74: blank line contains whitespace URL: https://codereview.tryton.org/370091002
7 months ago (2022-01-07 13:18:48 UTC) #16
Davidoff
Remove whitespaces
7 months ago (2022-01-10 08:21:59 UTC) #17
Davidoff
Fix missing pokoli remarks
7 months ago (2022-01-10 08:52:00 UTC) #18
reviewbot
checks OK URL: https://codereview.tryton.org/370091002
7 months ago (2022-01-10 08:56:38 UTC) #19
pokoli
https://codereview.tryton.org/370091002/diff/385751002/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/385751002/trytond/trytond/ir/export.py#newcode69 trytond/trytond/ir/export.py:69: models_fields = defaultdict(dict) defaultdict is not needed now https://codereview.tryton.org/370091002/diff/385751002/trytond/trytond/ir/export.py#newcode72 ...
7 months ago (2022-01-10 09:00:19 UTC) #20
Davidoff
Test the presence of the key instead of getting it, relation -> model, and delete ...
7 months ago (2022-01-10 09:16:38 UTC) #21
reviewbot
https://codereview.tryton.org/370091002/diff/384051002/trytond/trytond/ir/export.py#newcode4 trytond/trytond/ir/export.py:4: 'collections.defaultdict' imported but unused https://codereview.tryton.org/370091002/diff/384051002/trytond/trytond/ir/export.py#newcode77 trytond/trytond/ir/export.py:77: continuation line missing indentation or outdented URL: ...
7 months ago (2022-01-10 09:18:52 UTC) #22
Davidoff
Remove unused import and correct indentation
7 months ago (2022-01-10 09:27:34 UTC) #23
reviewbot
checks OK URL: https://codereview.tryton.org/370091002
7 months ago (2022-01-10 09:51:12 UTC) #24
ced
https://codereview.tryton.org/370091002/diff/378011002/sao/src/tab.js File sao/src/tab.js (right): https://codereview.tryton.org/370091002/diff/378011002/sao/src/tab.js#newcode1551 sao/src/tab.js:1551: 'export_fields.'].map(function(field) { It is probably nicer to break on ...
6 months ago (2022-02-10 23:25:16 UTC) #25
Davidoff
https://codereview.tryton.org/370091002/diff/378011002/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/378011002/trytond/trytond/ir/export.py#newcode75 trytond/trytond/ir/export.py:75: (f.name, f) for f in ModelField.search([ On 2022/02/10 23:25:16, ...
5 months, 3 weeks ago (2022-02-15 12:00:13 UTC) #26
ced
https://codereview.tryton.org/370091002/diff/378011002/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py (right): https://codereview.tryton.org/370091002/diff/378011002/trytond/trytond/ir/export.py#newcode75 trytond/trytond/ir/export.py:75: (f.name, f) for f in ModelField.search([ On 2022/02/15 12:00:13, ...
5 months, 3 weeks ago (2022-02-15 12:05:08 UTC) #27
Davidoff
Remove line break and use dict comprehension
5 months, 3 weeks ago (2022-02-15 12:06:22 UTC) #28
reviewbot
patch is not applicable URL: https://codereview.tryton.org/370091002
5 months, 3 weeks ago (2022-02-15 12:25:02 UTC) #29
Davidoff
Save fields' descriptions and relations
5 months, 3 weeks ago (2022-02-16 08:14:38 UTC) #30
pokoli
https://codereview.tryton.org/370091002/diff/380351002/trytond/trytond/ir/model.py File trytond/trytond/ir/model.py (right): https://codereview.tryton.org/370091002/diff/380351002/trytond/trytond/ir/model.py#newcode380 trytond/trytond/ir/model.py:380: print(key, name, relation) print should be removed
5 months, 3 weeks ago (2022-02-16 08:18:34 UTC) #31
Davidoff
Remove print
5 months, 3 weeks ago (2022-02-16 08:21:49 UTC) #32
reviewbot
patch is not applicable URL: https://codereview.tryton.org/370091002
5 months, 3 weeks ago (2022-02-16 08:27:59 UTC) #33
Davidoff
Make patch applicable
5 months, 3 weeks ago (2022-02-16 09:32:15 UTC) #34
reviewbot
https://codereview.tryton.org/370091002/diff/391581002/trytond/trytond/ir/export.py#newcode71 trytond/trytond/ir/export.py:71: missing whitespace after ',' URL: https://codereview.tryton.org/370091002
5 months, 3 weeks ago (2022-02-16 09:35:41 UTC) #35
Davidoff
Add whitespace after ','
5 months, 3 weeks ago (2022-02-16 09:43:35 UTC) #36
reviewbot
5 months, 3 weeks ago (2022-02-16 09:52:26 UTC) #37
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted