Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 370861002: tryton-env: Request a column size recomputation on treeview realization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 3 weeks ago by nicoe
Modified:
9 months, 3 weeks ago
Reviewers:
mrichez, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix remarks #

Total comments: 23

Patch Set 3 : Fix remarks #

Patch Set 4 : Use bytes instead of str #

Patch Set 5 : Fix arguments passed to underlying setter #

Patch Set 6 : Use queue_resize when view hasn't been realized yet #

Total comments: 2

Patch Set 7 : Use scope to store realized status #

Patch Set 8 : Fix method signature & treeview getter #

Total comments: 1

Patch Set 9 : Fix function call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tryton/tryton/gui/window/view_form/view/list_gtk/widget.py View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 39
nicoe
11 months, 3 weeks ago (2022-02-10 19:00:48 UTC) #1
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/370861002
11 months, 3 weeks ago (2022-02-10 19:04:36 UTC) #2
ced
https://codereview.tryton.org/370861002/diff/397291002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/397291002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode53 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:53: os.path.join(PIXMAPS_DIR, 'empty.png')) Could we use svg to reduce the ...
11 months, 3 weeks ago (2022-02-10 19:10:21 UTC) #3
nicoe
11 months, 3 weeks ago (2022-02-15 18:24:33 UTC) #4
nicoe
https://codereview.tryton.org/370861002/diff/397291002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/397291002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode53 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:53: os.path.join(PIXMAPS_DIR, 'empty.png')) On 2022/02/10 19:10:20, ced wrote: > Could ...
11 months, 3 weeks ago (2022-02-15 18:24:58 UTC) #5
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/370861002
11 months, 3 weeks ago (2022-02-15 18:54:11 UTC) #6
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/data/pixmaps/empty.svg File tryton/tryton/data/pixmaps/empty.svg (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/data/pixmaps/empty.svg#newcode5 tryton/tryton/data/pixmaps/empty.svg:5: width="64.000000pt" height="64.000000pt" viewBox="0 0 64.000000 64.000000" should not it ...
11 months, 2 weeks ago (2022-02-16 14:07:19 UTC) #7
nicoe
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/data/pixmaps/empty.svg File tryton/tryton/data/pixmaps/empty.svg (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/data/pixmaps/empty.svg#newcode13 tryton/tryton/data/pixmaps/empty.svg:13: </svg> On 2022/02/16 14:07:18, ced wrote: > It seems ...
11 months, 2 weeks ago (2022-02-16 18:29:21 UTC) #8
nicoe
11 months, 2 weeks ago (2022-02-16 18:35:45 UTC) #9
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/16 18:29:21, nicoe wrote: > ...
11 months, 2 weeks ago (2022-02-16 18:36:48 UTC) #10
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/370861002
11 months, 2 weeks ago (2022-02-16 18:56:23 UTC) #11
nicoe
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/16 18:36:48, ced wrote: > ...
11 months, 2 weeks ago (2022-02-16 21:31:29 UTC) #12
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/16 21:31:28, nicoe wrote: > ...
11 months, 2 weeks ago (2022-02-16 23:13:03 UTC) #13
mrichez
Got this error when launching gtk client on linux with latest patch: File "/home/mrichez/Workspace/tryton/issues/issue_11214_volume_dimensions_package/tryton/tryton/gui/main.py", line ...
11 months, 2 weeks ago (2022-02-17 05:58:17 UTC) #14
nicoe
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/16 23:13:03, ced wrote: > ...
11 months, 2 weeks ago (2022-02-17 09:17:43 UTC) #15
nicoe
11 months, 2 weeks ago (2022-02-17 09:56:16 UTC) #16
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/370861002
11 months, 2 weeks ago (2022-02-17 09:58:36 UTC) #17
mrichez
No more error when launching but symbols are still truncated :( https://pasteboard.co/9smbo4vUe6h0.png
11 months, 2 weeks ago (2022-02-17 10:04:26 UTC) #18
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/17 09:17:43, nicoe wrote: > ...
11 months, 2 weeks ago (2022-02-17 10:08:51 UTC) #19
nicoe
11 months, 2 weeks ago (2022-02-17 10:30:12 UTC) #20
nicoe
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/17 10:08:51, ced wrote: > ...
11 months, 2 weeks ago (2022-02-17 10:33:36 UTC) #21
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/17 10:33:36, nicoe wrote: > ...
11 months, 2 weeks ago (2022-02-17 10:41:14 UTC) #22
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/370861002
11 months, 2 weeks ago (2022-02-17 11:02:35 UTC) #23
nicoe
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/02/17 10:41:14, ced wrote: > ...
10 months, 3 weeks ago (2022-03-14 18:15:11 UTC) #24
ced
https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/390071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode66 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:66: cell.set_property('text', ' ') On 2022/03/14 18:15:11, nicoe wrote: > ...
10 months, 3 weeks ago (2022-03-14 22:31:40 UTC) #25
nicoe
10 months ago (2022-04-05 16:38:51 UTC) #26
ced
https://codereview.tryton.org/370861002/diff/409071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/409071002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode52 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:52: def realized(func): I'm wondering if it will not be ...
10 months ago (2022-04-05 16:51:27 UTC) #27
nicoe
10 months ago (2022-04-05 17:00:54 UTC) #28
nicoe
10 months ago (2022-04-05 17:04:04 UTC) #29
reviewbot
https://codereview.tryton.org/370861002/diff/380721002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode62 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:62: undefined name 'column' https://codereview.tryton.org/370861002/diff/380721002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode62 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:62: undefined name 'cell' URL: https://codereview.tryton.org/370861002
10 months ago (2022-04-05 17:09:44 UTC) #30
ced
The title must be updated. https://codereview.tryton.org/370861002/diff/380721002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/370861002/diff/380721002/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode62 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:62: return func(self, column, cell, ...
10 months ago (2022-04-05 17:22:39 UTC) #31
nicoe
10 months ago (2022-04-06 07:41:36 UTC) #32
reviewbot
checks OK URL: https://codereview.tryton.org/370861002
10 months ago (2022-04-06 07:44:21 UTC) #33
ced
For me the title is still not corresponding to the change.
10 months ago (2022-04-06 07:56:42 UTC) #34
nicoe
On 2022/04/06 07:56:42, ced wrote: > For me the title is still not corresponding to ...
10 months ago (2022-04-06 09:58:13 UTC) #35
ced
LGTM
10 months ago (2022-04-06 11:07:46 UTC) #36
rietveld-bot_tryton.org
New changeset d415b76ceb89 by Nicolas Évrard in branch 'default': Request a column size recomputation on ...
10 months ago (2022-04-06 12:27:52 UTC) #37
rietveld-bot_tryton.org
New changeset d3ab8e59c06f by Nicolas Évrard in branch 'default': Request a column size recomputation on ...
10 months ago (2022-04-06 12:27:54 UTC) #38
rietveld-bot_tryton.org
9 months, 3 weeks ago (2022-04-14 22:01:09 UTC) #39
New changeset 1f1a5356caff by Nicolas Évrard in branch '6.2':
Request a column size recomputation on treeview realization
https://hg.tryton.org/tryton/rev/1f1a5356caff


New changeset e5fbd9092453 by Nicolas Évrard in branch '6.0':
Request a column size recomputation on treeview realization
https://hg.tryton.org/tryton/rev/e5fbd9092453


New changeset 48a7129d20ad by Nicolas Évrard in branch '5.0':
Request a column size recomputation on treeview realization
https://hg.tryton.org/tryton/rev/48a7129d20ad
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted