Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 37091002: trytond: Set admin password when TRYTONPASSFILE environment variable is set (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by pokoli
Modified:
6 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

This behaviour was wrongly removed in changeset 5ade83a210f0 issue7221

Patch Set 1 #

Total comments: 3

Patch Set 2 : Set password only in one place #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M trytond/admin.py View 1 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 11
pokoli
6 months, 1 week ago (2018-03-13 13:25:34 UTC) #1
reviewbot
https://codereview.tryton.org/37091002/diff/1/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
6 months, 1 week ago (2018-03-13 13:47:42 UTC) #2
ced
https://codereview.tryton.org/37091002/diff/1/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/37091002/diff/1/trytond/admin.py#newcode109 trytond/admin.py:109: admin.password = password should not this line moved out ...
6 months, 1 week ago (2018-03-13 14:50:28 UTC) #3
pokoli
https://codereview.tryton.org/37091002/diff/1/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/37091002/diff/1/trytond/admin.py#newcode109 trytond/admin.py:109: admin.password = password On 2018/03/13 14:50:28, ced wrote: > ...
6 months, 1 week ago (2018-03-13 15:01:47 UTC) #4
ced
https://codereview.tryton.org/37091002/diff/1/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/37091002/diff/1/trytond/admin.py#newcode109 trytond/admin.py:109: admin.password = password On 2018/03/13 15:01:46, pokoli wrote: > ...
6 months, 1 week ago (2018-03-13 15:30:12 UTC) #5
pokoli
Set password only in one place
6 months, 1 week ago (2018-03-14 08:56:46 UTC) #6
ced
https://codereview.tryton.org/37091002/diff/20001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/37091002/diff/20001/trytond/admin.py#newcode109 trytond/admin.py:109: if not options.reset_password: I do not find it is ...
6 months, 1 week ago (2018-03-14 09:03:59 UTC) #7
pokoli
https://codereview.tryton.org/37091002/diff/20001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/37091002/diff/20001/trytond/admin.py#newcode109 trytond/admin.py:109: if not options.reset_password: On 2018/03/14 09:03:59, ced wrote: > ...
6 months, 1 week ago (2018-03-14 09:12:20 UTC) #8
reviewbot
https://codereview.tryton.org/37091002/diff/20001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
6 months, 1 week ago (2018-03-14 09:22:44 UTC) #9
ced
LGTM
6 months, 1 week ago (2018-03-14 09:24:34 UTC) #10
rietveld-bot_tryton.org
6 months, 1 week ago (2018-03-16 10:56:41 UTC) #11
New changeset 3844209e2e5e by Sergi Almacellas Abellana in branch 'default':
Set admin password when TRYTONPASSFILE environment variable is set
http://hg.tryton.org/trytond/rev/3844209e2e5e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766