Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 371581002: tryton-env: Add remove_forbidden_chars in tools (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by ced
Modified:
8 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

tryton-env: Add remove_forbidden_chars in tools issue10684

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M modules/country/scripts/import_countries.py View 1 chunk +2 lines, -5 lines 0 comments Download
M modules/currency/scripts/import_currencies.py View 1 chunk +2 lines, -5 lines 0 comments Download
M modules/web_shop_vue_storefront/party.py View 3 chunks +5 lines, -3 lines 0 comments Download
M trytond/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/tools/misc.rst View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_tools.py View 2 chunks +13 lines, -1 line 0 comments Download
M trytond/trytond/tools/__init__.py View 2 chunks +3 lines, -2 lines 0 comments Download
M trytond/trytond/tools/misc.py View 1 chunk +10 lines, -0 lines 6 comments Download

Messages

Total messages: 13
ced
9 months ago (2021-08-25 09:38:56 UTC) #1
pokoli
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): I'm wondering if it makes sense to ...
9 months ago (2021-08-25 09:42:59 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/371581002
9 months ago (2021-08-25 09:43:52 UTC) #3
ced
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): On 2021/08/25 09:42:59, pokoli wrote: > I'm ...
9 months ago (2021-08-25 09:45:30 UTC) #4
pokoli
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): On 2021/08/25 09:45:30, ced wrote: > On ...
9 months ago (2021-08-25 09:50:21 UTC) #5
ced
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): On 2021/08/25 09:50:21, pokoli wrote: > On ...
9 months ago (2021-08-25 09:54:10 UTC) #6
pokoli
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): On 2021/08/25 09:54:10, ced wrote: > On ...
9 months ago (2021-08-25 10:18:28 UTC) #7
ced
https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py File trytond/trytond/tools/misc.py (right): https://codereview.tryton.org/371581002/diff/375261002/trytond/trytond/tools/misc.py#newcode277 trytond/trytond/tools/misc.py:277: def remove_forbidden_chars(value): On 2021/08/25 10:18:28, pokoli wrote: > On ...
9 months ago (2021-08-25 10:24:22 UTC) #8
rietveld-bot_tryton.org
New changeset f8dcec13ebe9 by Cédric Krier in branch 'default': Add remove_forbidden_chars in tools https://hg.tryton.org/modules/country/rev/f8dcec13ebe9
8 months, 2 weeks ago (2021-09-13 21:43:23 UTC) #9
rietveld-bot_tryton.org
New changeset 7e5a44176bd4 by Cédric Krier in branch 'default': Add remove_forbidden_chars in tools https://hg.tryton.org/modules/currency/rev/7e5a44176bd4
8 months, 2 weeks ago (2021-09-13 21:43:33 UTC) #10
rietveld-bot_tryton.org
New changeset 023ac0481f31 by Cédric Krier in branch 'default': Add remove_forbidden_chars in tools https://hg.tryton.org/modules/web_shop_vue_storefront/rev/023ac0481f31
8 months, 2 weeks ago (2021-09-13 21:43:39 UTC) #11
rietveld-bot_tryton.org
New changeset 738c1d725255 by Cédric Krier in branch 'default': Add remove_forbidden_chars in tools https://hg.tryton.org/trytond/rev/738c1d725255
8 months, 2 weeks ago (2021-09-13 21:43:41 UTC) #12
rietveld-bot_tryton.org
8 months, 2 weeks ago (2021-09-13 21:43:46 UTC) #13
New changeset 16818f91e73c by Cédric Krier in branch 'default':
Add remove_forbidden_chars in tools
https://hg.tryton.org/tryton-env/rev/16818f91e73c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted