Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1749)

Issue 37251002: account: Quantize to number of digits instead of rounding computed amount (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by ced
Modified:
6 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Rounding may change the result if currency rounding is not unitary. issue7284

Patch Set 1 #

Patch Set 2 : Wrong initial type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M account.py View 1 5 chunks +10 lines, -10 lines 0 comments Download
M move.py View 1 chunk +0 lines, -1 line 0 comments Download
M party.py View 2 chunks +2 lines, -9 lines 0 comments Download
M tax.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/scenario_account_reconciliation.rst View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ced
6 months ago (2018-04-15 17:10:40 UTC) #1
reviewbot
https://codereview.tryton.org/37251002/diff/1/account.py#newcode824 account.py:824: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
6 months ago (2018-04-15 17:24:37 UTC) #2
pokoli
LGTM
6 months ago (2018-04-16 08:33:08 UTC) #3
ced
Wrong initial type
6 months ago (2018-04-18 07:59:21 UTC) #4
rietveld-bot_tryton.org
6 months ago (2018-04-18 08:18:40 UTC) #5
New changeset 3de9de3f476c by Cédric Krier in branch 'default':
Quantize to number of digits instead of rounding computed amount
http://hg.tryton.org/modules/account/rev/3de9de3f476c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766