Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 374421002: tryton-env: Return rec_name RPC call promise when available in M2O field set and set_default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by nicoe
Modified:
3 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

tryton-env: Return rec_name RPC call promise when available in M2O field set and set_default issue11030

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix remarks #

Total comments: 1

Patch Set 3 : Remove trailing spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M sao/src/model.js View 1 2 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 15
nicoe
5 months, 2 weeks ago (2021-12-09 08:36:11 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/374421002
5 months, 2 weeks ago (2021-12-09 08:56:35 UTC) #2
ced
https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newcode1576 sao/src/model.js:1576: var promise = this.set(record, value); We use usually prm ...
5 months, 2 weeks ago (2021-12-09 08:56:50 UTC) #3
ced
ping
4 months, 3 weeks ago (2022-01-04 21:34:12 UTC) #4
nicoe
https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newcode1576 sao/src/model.js:1576: var promise = this.set(record, value); On 2021/12/09 08:56:50, ced ...
4 months, 1 week ago (2022-01-19 16:25:24 UTC) #5
nicoe
4 months, 1 week ago (2022-01-19 16:25:34 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/374421002
4 months, 1 week ago (2022-01-19 16:53:01 UTC) #7
ced
https://codereview.tryton.org/374421002/diff/380111002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/374421002/diff/380111002/sao/src/model.js#newcode2079 sao/src/model.js:2079: screen.display(); trailing spaces
4 months, 1 week ago (2022-01-19 16:58:15 UTC) #8
nicoe
4 months ago (2022-01-21 10:08:45 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/374421002
4 months ago (2022-01-21 10:18:00 UTC) #10
ced
LGTM
4 months ago (2022-01-21 13:31:20 UTC) #11
ced
On 2022/01/21 13:31:20, ced wrote: > LGTM ping
3 months, 3 weeks ago (2022-02-04 20:27:26 UTC) #12
rietveld-bot_tryton.org
New changeset 4585dcb48a1a by Nicolas Évrard in branch 'default': Return rec_name RPC call promise when ...
3 months, 2 weeks ago (2022-02-08 17:55:38 UTC) #13
rietveld-bot_tryton.org
New changeset c80be611a16f by Nicolas Évrard in branch 'default': Return rec_name RPC call promise when ...
3 months, 2 weeks ago (2022-02-08 17:55:41 UTC) #14
rietveld-bot_tryton.org
3 months ago (2022-02-26 10:48:50 UTC) #15
New changeset 1fa900154756 by Nicolas Évrard in branch '6.2':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/1fa900154756


New changeset d9b1352a9a5b by Nicolas Évrard in branch '6.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/d9b1352a9a5b


New changeset 5c064d99853e by Nicolas Évrard in branch '5.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/5c064d99853e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted