tryton-env: Return rec_name RPC call promise when available in M2O field set and set_default

tryton-env: Return rec_name RPC call promise when available in M2O field set and set_default

issue11030

[reviewbot, 2021-12-09 08:56:35]

flake8 OK
URL: https://codereview.tryton.org/374421002

[ced, 2021-12-09 08:56:50]

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:1576: var promise = this.set(record, value);
We use usually prm as name

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2063: var promise = undefined;
There is no point to initialize variable to undefined.

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2077: },
record.model.session).done(store_rec_name.bind(this)).done(
Maybe this should not be async.
It should not be a real problem as normally rec_name should always be provided.

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2088: return promise;
I do not see where such promise will be used.

[ced, 2022-01-04 21:34:12]

ping

[nicoe, 2022-01-19 16:25:24]

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:1576: var promise = this.set(record, value);
On 2021/12/09 08:56:50, ced wrote:
> We use usually prm as name

Done.

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2063: var promise = undefined;
On 2021/12/09 08:56:50, ced wrote:
> There is no point to initialize variable to undefined.

Done.

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2077: },
record.model.session).done(store_rec_name.bind(this)).done(
On 2021/12/09 08:56:50, ced wrote:
> Maybe this should not be async.
> It should not be a real problem as normally rec_name should always be
provided.

Done.

https://codereview.tryton.org/374421002/diff/377641003/sao/src/model.js#newco...
sao/src/model.js:2088: return promise;
On 2021/12/09 08:56:50, ced wrote:
> I do not see where such promise will be used.

Done.

[reviewbot, 2022-01-19 16:53:01]

checks OK
URL: https://codereview.tryton.org/374421002

[ced, 2022-01-19 16:58:15]

https://codereview.tryton.org/374421002/diff/380111002/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/374421002/diff/380111002/sao/src/model.js#newco...
sao/src/model.js:2079: screen.display();
trailing spaces

[reviewbot, 2022-01-21 10:18:00]

checks OK
URL: https://codereview.tryton.org/374421002

[ced, 2022-01-21 13:31:20]

LGTM

[ced, 2022-02-04 20:27:26]

On 2022/01/21 13:31:20, ced wrote:
> LGTM

ping

[rietveld-bot_tryton.org, 2022-02-08 17:55:38]

New changeset 4585dcb48a1a by Nicolas Évrard in branch 'default':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/4585dcb48a1a

[rietveld-bot_tryton.org, 2022-02-08 17:55:41]

New changeset c80be611a16f by Nicolas Évrard in branch 'default':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/tryton-env/rev/c80be611a16f

[rietveld-bot_tryton.org, 2022-02-26 10:48:50]

New changeset 1fa900154756 by Nicolas Évrard in branch '6.2':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/1fa900154756


New changeset d9b1352a9a5b by Nicolas Évrard in branch '6.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/d9b1352a9a5b


New changeset 5c064d99853e by Nicolas Évrard in branch '5.0':
Return rec_name RPC call promise when available in M2O field set and set_default
https://hg.tryton.org/sao/rev/5c064d99853e