Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 37581002: trytond: Add support for single record report (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by ced
Modified:
5 years, 5 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

A single report render each record separately and return them in a zip file. To ensure the uniqueness of the file in the zip, it uses the id of the record but also the record name to be user-friendly. issue6640

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix wording #

Total comments: 4

Patch Set 3 : Allow to execute report without records #

Patch Set 4 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/reports/index.rst View 1 2 3 2 chunks +10 lines, -6 lines 0 comments Download
M trytond/ir/action.py View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M trytond/ir/view/action_report_form.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/report/report.py View 1 2 3 3 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 14
ced
5 years, 6 months ago (2017-07-13 13:52:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/37581002
5 years, 6 months ago (2017-07-13 14:12:59 UTC) #2
pokoli
Maybe it's worth to add a test about calling single with multiple records. https://tryton-rietveld-hrd.appspot.com/37581002/diff/1/doc/topics/reports/index.rst File ...
5 years, 6 months ago (2017-07-27 13:30:27 UTC) #3
ced
On 2017/07/27 13:30:27, pokoli wrote: > Maybe it's worth to add a test about calling ...
5 years, 6 months ago (2017-07-28 07:33:48 UTC) #4
ced
https://tryton-rietveld-hrd.appspot.com/37581002/diff/1/doc/topics/reports/index.rst File doc/topics/reports/index.rst (right): https://tryton-rietveld-hrd.appspot.com/37581002/diff/1/doc/topics/reports/index.rst#newcode53 doc/topics/reports/index.rst:53: * ``single``: `True` if the template works for only ...
5 years, 6 months ago (2017-07-28 07:34:00 UTC) #5
ced
Fix wording
5 years, 6 months ago (2017-07-28 07:34:02 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/37581002
5 years, 6 months ago (2017-07-28 07:40:13 UTC) #7
pokoli
https://tryton-rietveld.appspot.com/37581002/diff/20001/trytond/report/report.py File trytond/report/report.py (right): https://tryton-rietveld.appspot.com/37581002/diff/20001/trytond/report/report.py#newcode150 trytond/report/report.py:150: records = None probably better to make records = ...
5 years, 6 months ago (2017-08-01 09:20:39 UTC) #8
ced
https://tryton-rietveld.appspot.com/37581002/diff/20001/trytond/report/report.py File trytond/report/report.py (right): https://tryton-rietveld.appspot.com/37581002/diff/20001/trytond/report/report.py#newcode150 trytond/report/report.py:150: records = None On 2017/08/01 09:20:39, pokoli wrote: > ...
5 years, 6 months ago (2017-08-01 14:01:51 UTC) #9
ced
Allow to execute report without records
5 years, 6 months ago (2017-08-01 14:02:11 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/37581002
5 years, 6 months ago (2017-08-01 14:05:59 UTC) #11
pokoli
LGTM
5 years, 6 months ago (2017-08-01 15:20:30 UTC) #12
ced
Update to tip
5 years, 5 months ago (2017-09-03 09:08:29 UTC) #13
rietveld-bot_tryton.org
5 years, 5 months ago (2017-09-03 09:14:17 UTC) #14
New changeset 0bd088a8474b by Cédric Krier in branch 'default':
Add support for single record report
http://hg.tryton.org/trytond/rev/0bd088a8474b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted