account_invoice: Warn all past payment terms at the same time

issue11058

[acaubet, 2021-12-15 15:47:29]

account_invoice: Fix singular expresion message

[reviewbot, 2021-12-15 15:56:00]

checks OK
URL: https://codereview.tryton.org/376221002

[pokoli, 2021-12-15 16:24:21]

https://codereview.tryton.org/376221002/diff/387521002/invoice.py
File invoice.py (right):

https://codereview.tryton.org/376221002/diff/387521002/invoice.py#newcode1023
invoice.py:1023: past_payment_term_dates = [lang.strftime(d) for d, _ in
term_lines if (
why calling strgtime? It's easier to just store the dates.

https://codereview.tryton.org/376221002/diff/387521002/invoice.py#newcode1032
invoice.py:1032: date=','.join(past_payment_term_dates)))
I think we can just show the first one as this is the current behaviour.

https://codereview.tryton.org/376221002/diff/387521002/message.xml
File message.xml (right):

https://codereview.tryton.org/376221002/diff/387521002/message.xml#newcode76
message.xml:76: <field name="text">The invoice "%(invoice)s" generates payment
dates ("%(date)s") in the past.</field>
We can not modify messages for backport (otherwise it won't be translated).

[acaubet, 2021-12-15 16:41:12]

Show message only for the minimum date

[reviewbot, 2021-12-15 17:07:07]

checks OK
URL: https://codereview.tryton.org/376221002

[ced, 2022-01-04 21:46:53]

https://codereview.tryton.org/376221002/diff/379861002/invoice.py
File invoice.py (right):

https://codereview.tryton.org/376221002/diff/379861002/invoice.py#newcode1023
invoice.py:1023: self.type == 'out' and d < today)]
This could be done in the term_lines loop.

[acaubet, 2022-01-24 14:38:42]

Use term_lines loop to check past dates

[reviewbot, 2022-01-24 15:09:46]

checks OK
URL: https://codereview.tryton.org/376221002

[ced, 2022-01-25 22:30:21]

LGTM

[rietveld-bot_tryton.org, 2022-01-25 22:33:55]

New changeset 02be5467be12 by Adrià Tarroja Caubet in branch 'default':
Warn all past payment terms at the same time
https://hg.tryton.org/modules/account_invoice/rev/02be5467be12

[rietveld-bot_tryton.org, 2022-02-07 22:34:54]

New changeset ca52edd2cc02 by Adrià Tarroja Caubet in branch '6.2':
Warn all past payment terms at the same time
https://hg.tryton.org/modules/account_invoice/rev/ca52edd2cc02


New changeset 28f7a05bf0f8 by Adrià Tarroja Caubet in branch '6.0':
Warn all past payment terms at the same time
https://hg.tryton.org/modules/account_invoice/rev/28f7a05bf0f8