Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 376221002: account_invoice: Warn all past payment terms at the same time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by acaubet
Modified:
3 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : account_invoice: Fix singular expresion message #

Total comments: 3

Patch Set 3 : Show message only for the minimum date #

Total comments: 1

Patch Set 4 : Use term_lines loop to check past dates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M invoice.py View 1 2 3 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 12
acaubet
5 months, 1 week ago (2021-12-15 15:34:16 UTC) #1
acaubet
account_invoice: Fix singular expresion message
5 months, 1 week ago (2021-12-15 15:47:29 UTC) #2
reviewbot
checks OK URL: https://codereview.tryton.org/376221002
5 months, 1 week ago (2021-12-15 15:56:00 UTC) #3
pokoli
https://codereview.tryton.org/376221002/diff/387521002/invoice.py File invoice.py (right): https://codereview.tryton.org/376221002/diff/387521002/invoice.py#newcode1023 invoice.py:1023: past_payment_term_dates = [lang.strftime(d) for d, _ in term_lines if ...
5 months, 1 week ago (2021-12-15 16:24:21 UTC) #4
acaubet
Show message only for the minimum date
5 months, 1 week ago (2021-12-15 16:41:12 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/376221002
5 months, 1 week ago (2021-12-15 17:07:07 UTC) #6
ced
https://codereview.tryton.org/376221002/diff/379861002/invoice.py File invoice.py (right): https://codereview.tryton.org/376221002/diff/379861002/invoice.py#newcode1023 invoice.py:1023: self.type == 'out' and d < today)] This could ...
4 months, 3 weeks ago (2022-01-04 21:46:53 UTC) #7
acaubet
Use term_lines loop to check past dates
4 months ago (2022-01-24 14:38:42 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/376221002
4 months ago (2022-01-24 15:09:46 UTC) #9
ced
LGTM
4 months ago (2022-01-25 22:30:21 UTC) #10
rietveld-bot_tryton.org
New changeset 02be5467be12 by Adrià Tarroja Caubet in branch 'default': Warn all past payment terms ...
4 months ago (2022-01-25 22:33:55 UTC) #11
rietveld-bot_tryton.org
3 months, 2 weeks ago (2022-02-07 22:34:54 UTC) #12
New changeset ca52edd2cc02 by Adrià Tarroja Caubet in branch '6.2':
Warn all past payment terms at the same time
https://hg.tryton.org/modules/account_invoice/rev/ca52edd2cc02


New changeset 28f7a05bf0f8 by Adrià Tarroja Caubet in branch '6.0':
Warn all past payment terms at the same time
https://hg.tryton.org/modules/account_invoice/rev/28f7a05bf0f8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted