tryton-env: Add rec_name searcher on reporting models

COLLABORATOR=sergi@koolpi.com
issue11263

[reviewbot, 2022-02-24 10:29:51]

checks OK
URL: https://codereview.tryton.org/376921002

[pokoli, 2022-02-24 13:14:57]

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py
File sale_reporting.py (right):

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:542: return [('id', 'in', Category.search(clause))]
you can use query=True of search method.

This avoids tryton to load all the instances in memory and executes the query
directly in the domain.

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:814: return [('id', 'in', Category.search(clause))]
same about query=True

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:927: return self.subdivision.rec_name
Here we are missing a rec_name searcher.

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:977: def search_rec_name(cls, name, clause):
This will fail if the record is a subdivision. 

I think we can remove the rec_name searcher for this model.

[ced, 2022-02-25 11:22:59]

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py
File sale_reporting.py (right):

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:456: 
It will be better to define a search_name here.

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:729: 
It will be better to define a search_name here.

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:970: 
Better to define search_rec_name here.

https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newc...
sale_reporting.py:977: def search_rec_name(cls, name, clause):
On 2022/02/24 13:14:57, pokoli wrote:
> This will fail if the record is a subdivision. 
> 
> I think we can remove the rec_name searcher for this model.

I agree as it will be difficult with shard ids.

[Davidoff, 2022-02-28 09:20:00]

Use query=True, add missing search_rec_name and search_name

[reviewbot, 2022-02-28 09:38:18]

checks OK
URL: https://codereview.tryton.org/376921002

[pokoli, 2022-02-28 10:02:29]

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py
File sale_reporting.py (right):

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:459: return [('name',) + tuple(clause[1:])]
I think this can not work as name is a functional field wihtout searcher.

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:543: def search_rec_name(cls, name, clause):
could you please put search_rec_name after get_rec_name?

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:546: breakpoint()
Please remove breakpoints

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:737: return [('name',) + tuple(clause[1:])]
idem about name beeing a functional field without searcher.

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:819: @classmethod
idem about grouping methods.

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:884: def search_rec_name(cls, name, clause):
why not setting on mixing? (also the get_rec_name)

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:939: def search_rec_name(cls, name, clause):
idem about setting on mixin.

https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newc...
sale_reporting.py:952: country = fields.Many2One('country.country', "Country")
I do not see where such field is used.

[Davidoff, 2022-02-28 11:36:41]

Set get_rec_name and search_rec_name on Mixin and call search_name from
search_rec_name where needed

[reviewbot, 2022-02-28 12:02:05]

checks OK
URL: https://codereview.tryton.org/376921002

[pokoli, 2022-03-01 09:01:15]

https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py
File sale_reporting.py (right):

https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py#newc...
sale_reporting.py:545: def search_rec_name(cls, name, clause):
Indeed it is better to just set the _rec_name attribute of the class [1] to use
the name field as rec_name. But as it defaults to 'name' I think this method is
not required.

Could you test and confirm? 

[1]
https://docs.tryton.org/projects/server/en/latest/ref/models/models.html?high...

https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py#newc...
sale_reporting.py:821: def search_rec_name(cls, name, clause):
idem about _rec_name

https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py#newc...
sale_reporting.py:862: return self.country.rec_name
it should not fail if country is empty. So better to use: 

self.country.rec_name if self.country else None

(as done in other models)

https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py#newc...
sale_reporting.py:916: return self.subdivision.rec_name
idem about empty value for subdivision

[Davidoff, 2022-03-01 10:31:59]

Use only search_name where possible and apply to stock_reporting

[reviewbot, 2022-03-01 10:40:29]

checks OK
URL: https://codereview.tryton.org/376921002

[ced, 2022-04-02 21:16:06]

https://codereview.tryton.org/376921002/diff/378431002/modules/sale/CHANGELOG
File modules/sale/CHANGELOG (right):

https://codereview.tryton.org/376921002/diff/378431002/modules/sale/CHANGELOG...
modules/sale/CHANGELOG:1: * Add rec_name searcher on reporting models
I would say:

Allow searching reporting by name

https://codereview.tryton.org/376921002/diff/378431002/modules/stock/CHANGELOG
File modules/stock/CHANGELOG (right):

https://codereview.tryton.org/376921002/diff/378431002/modules/stock/CHANGELO...
modules/stock/CHANGELOG:1: * Add rec_name searcher on reporting models
idem

[Davidoff, 2022-04-05 07:59:48]

Improve CHANGELOG entry

[reviewbot, 2022-04-05 08:15:34]

checks OK
URL: https://codereview.tryton.org/376921002

[acaubet, 2022-05-10 08:55:29]

LGTM