Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 376921002: tryton-env: Add rec_name searcher on reporting models

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Davidoff
Modified:
2 weeks, 3 days ago
Reviewers:
pokoli, acaubet, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue11263

Patch Set 1 #

Total comments: 8

Patch Set 2 : Use query=True, add missing search_rec_name and search_name #

Total comments: 8

Patch Set 3 : Set get_rec_name and search_rec_name on Mixin and call search_name from search_rec_name where needed #

Total comments: 4

Patch Set 4 : Use only search_name where possible and apply to stock_reporting #

Total comments: 2

Patch Set 5 : Improve CHANGELOG entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M modules/sale/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M modules/sale/sale_reporting.py View 1 2 3 4 12 chunks +46 lines, -8 lines 0 comments Download
M modules/stock/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/stock_reporting_margin.py View 1 2 3 4 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 16
Davidoff
3 months ago (2022-02-24 10:08:14 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/376921002
3 months ago (2022-02-24 10:29:51 UTC) #2
pokoli
https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py File sale_reporting.py (right): https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newcode542 sale_reporting.py:542: return [('id', 'in', Category.search(clause))] you can use query=True of ...
3 months ago (2022-02-24 13:14:57 UTC) #3
ced
https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py File sale_reporting.py (right): https://codereview.tryton.org/376921002/diff/391631002/sale_reporting.py#newcode456 sale_reporting.py:456: It will be better to define a search_name here. ...
3 months ago (2022-02-25 11:22:59 UTC) #4
Davidoff
Use query=True, add missing search_rec_name and search_name
2 months, 4 weeks ago (2022-02-28 09:20:00 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/376921002
2 months, 4 weeks ago (2022-02-28 09:38:18 UTC) #6
pokoli
https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py File sale_reporting.py (right): https://codereview.tryton.org/376921002/diff/366821002/sale_reporting.py#newcode459 sale_reporting.py:459: return [('name',) + tuple(clause[1:])] I think this can not ...
2 months, 4 weeks ago (2022-02-28 10:02:29 UTC) #7
Davidoff
Set get_rec_name and search_rec_name on Mixin and call search_name from search_rec_name where needed
2 months, 4 weeks ago (2022-02-28 11:36:41 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/376921002
2 months, 3 weeks ago (2022-02-28 12:02:05 UTC) #9
pokoli
https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py File sale_reporting.py (right): https://codereview.tryton.org/376921002/diff/384561002/sale_reporting.py#newcode545 sale_reporting.py:545: def search_rec_name(cls, name, clause): Indeed it is better to ...
2 months, 3 weeks ago (2022-03-01 09:01:15 UTC) #10
Davidoff
Use only search_name where possible and apply to stock_reporting
2 months, 3 weeks ago (2022-03-01 10:31:59 UTC) #11
reviewbot
checks OK URL: https://codereview.tryton.org/376921002
2 months, 3 weeks ago (2022-03-01 10:40:29 UTC) #12
ced
https://codereview.tryton.org/376921002/diff/378431002/modules/sale/CHANGELOG File modules/sale/CHANGELOG (right): https://codereview.tryton.org/376921002/diff/378431002/modules/sale/CHANGELOG#newcode1 modules/sale/CHANGELOG:1: * Add rec_name searcher on reporting models I would ...
1 month, 3 weeks ago (2022-04-02 21:16:06 UTC) #13
Davidoff
Improve CHANGELOG entry
1 month, 3 weeks ago (2022-04-05 07:59:48 UTC) #14
reviewbot
checks OK URL: https://codereview.tryton.org/376921002
1 month, 3 weeks ago (2022-04-05 08:15:34 UTC) #15
acaubet
2 weeks, 3 days ago (2022-05-10 08:55:29 UTC) #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted