Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(848)

Issue 37861002: stock: Hide expected_quantity for non saved inventory lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by mrichez
Modified:
2 days, 4 hours ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : adding scenario and tests on inventory location and date #

Total comments: 10

Patch Set 3 : apply last remarks #

Patch Set 4 : Hide expected_quantity for non saved inventory lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M inventory.py View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16
mrichez
2 weeks, 1 day ago (2017-11-30 08:43:49 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/37861002
2 weeks, 1 day ago (2017-11-30 08:59:13 UTC) #2
pokoli
Could you please add a test on the scenario_stock_inventory which ensures the value is correctly ...
2 weeks, 1 day ago (2017-11-30 09:29:40 UTC) #3
mrichez
https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py File inventory.py (right): https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py#newcode347 inventory.py:347: Product = pool.get('product.product') On 2017/11/30 09:29:39, pokoli wrote: > ...
2 weeks, 1 day ago (2017-11-30 10:35:53 UTC) #4
pokoli
https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py File inventory.py (right): https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py#newcode347 inventory.py:347: Product = pool.get('product.product') On 2017/11/30 10:35:53, mrichez wrote: > ...
2 weeks, 1 day ago (2017-11-30 10:45:20 UTC) #5
mrichez
On 2017/11/30 10:45:20, pokoli wrote: > https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py > File inventory.py (right): > > https://tryton-rietveld-hrd.appspot.com/37861002/diff/1/inventory.py#newcode347 > ...
2 weeks, 1 day ago (2017-11-30 11:05:40 UTC) #6
mrichez
adding scenario and tests on inventory location and date
2 weeks, 1 day ago (2017-11-30 12:19:26 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/37861002
2 weeks, 1 day ago (2017-11-30 12:27:08 UTC) #8
pokoli
https://codereview.tryton.org/37861002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/37861002/diff/20001/inventory.py#newcode352 inventory.py:352: if self.product: this can be tested on the previous ...
2 weeks, 1 day ago (2017-11-30 12:31:21 UTC) #9
mrichez
https://tryton-rietveld-hrd.appspot.com/37861002/diff/20001/inventory.py File inventory.py (right): https://tryton-rietveld-hrd.appspot.com/37861002/diff/20001/inventory.py#newcode352 inventory.py:352: if self.product: On 2017/11/30 12:31:21, pokoli wrote: > this ...
2 weeks, 1 day ago (2017-11-30 14:21:16 UTC) #10
mrichez
apply last remarks
2 weeks, 1 day ago (2017-11-30 14:21:26 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/37861002
2 weeks, 1 day ago (2017-11-30 14:37:23 UTC) #12
mrichez
Hide expected_quantity for non saved records
1 week, 3 days ago (2017-12-05 14:20:45 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/37861002
1 week, 3 days ago (2017-12-05 14:48:41 UTC) #14
ced
LGTM
2 days, 4 hours ago (2017-12-13 17:19:41 UTC) #15
rietveld-bot_tryton.org
2 days, 4 hours ago (2017-12-13 17:23:01 UTC) #16
New changeset e548935cb214 by Maxime Richez in branch 'default':
Hide expected_quantity for non saved inventory lines
http://hg.tryton.org/modules/stock/rev/e548935cb214
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922