Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 380021002: sale_point: Add wizard to ask for the sale point when opening the 'POS Sales' menu entry

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Davidoff
Modified:
4 months, 3 weeks ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue10948

Patch Set 1 #

Total comments: 13

Patch Set 2 : Use directly point instead of point.id, improve wizard naming and change menuitem id and name #

Total comments: 5

Patch Set 3 : Rename SelectSalePoint to POSOpen and remove action keyword #

Total comments: 7

Patch Set 4 : Improve code order, do not change menuitem id and remove question image from view #

Patch Set 5 : Improve code order, do not change menuitem id and remove question image from view #

Patch Set 6 : Sort imports correctly #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -4 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M sale.py View 1 2 3 4 5 2 chunks +33 lines, -2 lines 2 comments Download
M sale.xml View 1 2 3 2 chunks +15 lines, -2 lines 2 comments Download
A view/sale_point_open_start_form.xml View 1 2 3 4 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 17
Davidoff
1 year ago (2022-01-04 12:17:48 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/380021002
1 year ago (2022-01-04 12:23:02 UTC) #2
pokoli
https://codereview.tryton.org/380021002/diff/376391003/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/380021002/diff/376391003/CHANGELOG#newcode1 CHANGELOG:1: * Add wizard to ask for the sale point ...
1 year ago (2022-01-04 12:48:17 UTC) #3
Davidoff
https://codereview.tryton.org/380021002/diff/376391003/sale.py File sale.py (right): https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1364 sale.py:1364: def default_date(cls): On 2022/01/04 12:48:17, pokoli wrote: > wwhere ...
1 year ago (2022-01-07 10:06:47 UTC) #4
Davidoff
Use directly point instead of point.id, improve wizard naming and change menuitem id and name
1 year ago (2022-01-07 11:33:07 UTC) #5
Davidoff
Use directly point instead of point.id, improve wizard naming and change menuitem id and name
1 year ago (2022-01-07 11:33:49 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/380021002
1 year ago (2022-01-07 11:46:33 UTC) #7
ced
https://codereview.tryton.org/380021002/diff/377991003/sale.py File sale.py (right): https://codereview.tryton.org/380021002/diff/377991003/sale.py#newcode1361 sale.py:1361: help="If empty all sale points are used.") Probably better: ...
1 year ago (2022-01-21 16:12:29 UTC) #8
Davidoff
Rename SelectSalePoint to POSOpen and remove action keyword
11 months, 3 weeks ago (2022-02-14 12:14:57 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/380021002
11 months, 3 weeks ago (2022-02-14 12:20:44 UTC) #10
ced
https://codereview.tryton.org/380021002/diff/387951002/sale.py File sale.py (right): https://codereview.tryton.org/380021002/diff/387951002/sale.py#newcode23 sale.py:23: from trytond.wizard.wizard import StateAction Should be imported from trytond.wizard ...
10 months, 1 week ago (2022-03-29 21:55:57 UTC) #11
Davidoff
Improve code order, do not change menuitem id and remove question image from view
10 months, 1 week ago (2022-03-30 10:52:01 UTC) #12
Davidoff
Improve code order, do not change menuitem id and remove question image from view
10 months, 1 week ago (2022-03-30 10:52:54 UTC) #13
reviewbot
ERROR: /tmp/reviewbot-revt0__w/sale.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/380021002
10 months, 1 week ago (2022-03-30 11:02:59 UTC) #14
Davidoff
Sort imports correctly
10 months, 1 week ago (2022-03-30 11:10:35 UTC) #15
reviewbot
checks OK URL: https://codereview.tryton.org/380021002
10 months, 1 week ago (2022-03-30 11:33:43 UTC) #16
ced
4 months, 3 weeks ago (2022-09-10 07:54:08 UTC) #17
The same wizard should also added for cash session.

https://codereview.tryton.org/380021002/diff/390421002/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/390421002/sale.py#newcode712
sale.py:712: 
I think this is the place where the wizard should be defined.

https://codereview.tryton.org/380021002/diff/390421002/sale.py#newcode1372
sale.py:1372: Button("Continue", 'open_', 'tryton-ok', default=True),
Maybe "Open"

https://codereview.tryton.org/380021002/diff/390421002/sale.xml
File sale.xml (right):

https://codereview.tryton.org/380021002/diff/390421002/sale.xml#newcode104
sale.xml:104: <record model="ir.ui.view" id="sale_point_open_start_view_form">
Why not define the view just above the wizard definition?

https://codereview.tryton.org/380021002/diff/390421002/sale.xml#newcode244
sale.xml:244: 
I think this is the place where wizard and view should be defined.

https://codereview.tryton.org/380021002/diff/390421002/view/sale_point_open_s...
File view/sale_point_open_start_form.xml (right):

https://codereview.tryton.org/380021002/diff/390421002/view/sale_point_open_s...
view/sale_point_open_start_form.xml:5: <group col="2" xexpand="1"
id="select_sale_point">
There is not point to add a group
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted