sale_point: Add wizard to ask for the sale point when opening the 'POS Sales' menu entry

COLLABORATOR=sergi@koolpi.com
issue10948

[reviewbot, 2022-01-04 12:23:02]

checks OK
URL: https://codereview.tryton.org/380021002

[pokoli, 2022-01-04 12:48:17]

https://codereview.tryton.org/380021002/diff/376391003/CHANGELOG
File CHANGELOG (right):

https://codereview.tryton.org/380021002/diff/376391003/CHANGELOG#newcode1
CHANGELOG:1: * Add wizard to ask for the sale point when opening the "POS Sales"
menu entry
There is no need for "Add wizard to..." just tlak about then change "Ask for.."

https://codereview.tryton.org/380021002/diff/376391003/CHANGELOG#newcode1
CHANGELOG:1: * Add wizard to ask for the sale point when opening the "POS Sales"
menu entry
is not better if we write just: "When opening POS Sales"?

https://codereview.tryton.org/380021002/diff/376391003/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1356
sale.py:1356: "Select Sale Point"
The docstring should make it clear that this is the "Start" model and not the
wizard.

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1364
sale.py:1364: def default_date(cls):
wwhere it is used?

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1383
sale.py:1383: action['pyson_domain'] = \
We prefer to use ( instead of \ but you can just break after encode.

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1384
sale.py:1384: PYSONEncoder().encode([('point.id', '=', self.start.point.id)])
There is no need to do 'point.id' you can use directly 'point'

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1387
sale.py:1387: def transition_open_(self):
this is not needed.

https://codereview.tryton.org/380021002/diff/376391003/sale.xml
File sale.xml (right):

https://codereview.tryton.org/380021002/diff/376391003/sale.xml#newcode121
sale.xml:121: <field name="name">POS Sales</field>
I think the wizard should be named "Select sale point"

https://codereview.tryton.org/380021002/diff/376391003/sale.xml#newcode168
sale.xml:168: id="menu_sale_form"
and the menuitem should have a "POS Sales" name to keep the current one instead
of the one defined in the action.

https://codereview.tryton.org/380021002/diff/376391003/sale.xml#newcode168
sale.xml:168: id="menu_sale_form"
also we should use a diferent id so we force a new record to be created and we
ensure that the values are properly updated on all databases.

https://codereview.tryton.org/380021002/diff/376391003/view/select_sale_point...
File view/select_sale_point_start_form.xml (right):

https://codereview.tryton.org/380021002/diff/376391003/view/select_sale_point...
view/select_sale_point_start_form.xml:7: <label string="Select sale point"
id="create"/>
id="create" does not have coherence with the string.

https://codereview.tryton.org/380021002/diff/376391003/view/select_sale_point...
view/select_sale_point_start_form.xml:7: <label string="Select sale point"
id="create"/>
Why using a diferent string instead of the field name?

[Davidoff, 2022-01-07 10:06:47]

https://codereview.tryton.org/380021002/diff/376391003/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/376391003/sale.py#newcode1364
sale.py:1364: def default_date(cls):
On 2022/01/04 12:48:17, pokoli wrote:
> wwhere it is used?

Sorry, it's not used. It was from another wizard that I used as an example to
get started and I forgot to remove it.

[Davidoff, 2022-01-07 11:33:07]

Use directly point instead of point.id, improve wizard naming and change
menuitem id and name

[Davidoff, 2022-01-07 11:33:49]

Use directly point instead of point.id, improve wizard naming and change
menuitem id and name

[reviewbot, 2022-01-07 11:46:33]

checks OK
URL: https://codereview.tryton.org/380021002

[ced, 2022-01-21 16:12:29]

https://codereview.tryton.org/380021002/diff/377991003/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/377991003/sale.py#newcode1361
sale.py:1361: help="If empty all sale points are used.")
Probably better:

Leave empty for all sale points.

https://codereview.tryton.org/380021002/diff/377991003/sale.py#newcode1364
sale.py:1364: class SelectSalePoint(Wizard):
I would name it just: POSOpen

https://codereview.tryton.org/380021002/diff/377991003/sale.py#newcode1366
sale.py:1366: __name__ = 'sale.point.select_sale_point'
I think it is better named: sale.point.open

https://codereview.tryton.org/380021002/diff/377991003/sale.xml
File sale.xml (right):

https://codereview.tryton.org/380021002/diff/377991003/sale.xml#newcode121
sale.xml:121: <field name="name">Select sale point</field>
Open Sale Point

https://codereview.tryton.org/380021002/diff/377991003/sale.xml#newcode126
sale.xml:126: <field name="model">sale.point,-1</field>
I do not see the point to have such action on sale point.

[Davidoff, 2022-02-14 12:14:57]

Rename SelectSalePoint to POSOpen and remove action keyword

[reviewbot, 2022-02-14 12:20:44]

checks OK
URL: https://codereview.tryton.org/380021002

[ced, 2022-03-29 21:55:57]

https://codereview.tryton.org/380021002/diff/387951002/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/387951002/sale.py#newcode23
sale.py:23: from trytond.wizard.wizard import StateAction
Should be imported from trytond.wizard

https://codereview.tryton.org/380021002/diff/387951002/sale.py#newcode1362
sale.py:1362: class POSOpenStart(ModelView):
I prefer that we define model for wizard after the wizard as it is more logical
on reading.

https://codereview.tryton.org/380021002/diff/387951002/sale.xml
File sale.xml (right):

https://codereview.tryton.org/380021002/diff/387951002/sale.xml#newcode103
sale.xml:103: 
I think this is the best place to add the view record.

https://codereview.tryton.org/380021002/diff/387951002/sale.xml#newcode124
sale.xml:124: <record model="ir.ui.view" id="sale_point_open_start_view_form">
Better to add an empty line as records are not related.

https://codereview.tryton.org/380021002/diff/387951002/sale.xml#newcode158
sale.xml:158: 
It will be better to create wizard record here.

https://codereview.tryton.org/380021002/diff/387951002/sale.xml#newcode164
sale.xml:164: id="menu_sale_point_open"
I do not think we need to change the id.

https://codereview.tryton.org/380021002/diff/387951002/view/sale_point_open_s...
File view/sale_point_open_start_form.xml (right):

https://codereview.tryton.org/380021002/diff/387951002/view/sale_point_open_s...
view/sale_point_open_start_form.xml:5: <image name="tryton-question" xexpand="0"
xfill="0"/>
I do not think we need to raise so much attention with a question.

[Davidoff, 2022-03-30 10:52:01]

Improve code order, do not change menuitem id and remove question image from
view

[Davidoff, 2022-03-30 10:52:54]

Improve code order, do not change menuitem id and remove question image from
view

[reviewbot, 2022-03-30 11:02:59]

ERROR: /tmp/reviewbot-revt0__w/sale.py Imports are incorrectly sorted and/or
formatted.

URL: https://codereview.tryton.org/380021002

[Davidoff, 2022-03-30 11:10:35]

Sort imports correctly

[reviewbot, 2022-03-30 11:33:43]

checks OK
URL: https://codereview.tryton.org/380021002

[ced, 2022-09-10 07:54:08]

The same wizard should also added for cash session.

https://codereview.tryton.org/380021002/diff/390421002/sale.py
File sale.py (right):

https://codereview.tryton.org/380021002/diff/390421002/sale.py#newcode712
sale.py:712: 
I think this is the place where the wizard should be defined.

https://codereview.tryton.org/380021002/diff/390421002/sale.py#newcode1372
sale.py:1372: Button("Continue", 'open_', 'tryton-ok', default=True),
Maybe "Open"

https://codereview.tryton.org/380021002/diff/390421002/sale.xml
File sale.xml (right):

https://codereview.tryton.org/380021002/diff/390421002/sale.xml#newcode104
sale.xml:104: <record model="ir.ui.view" id="sale_point_open_start_view_form">
Why not define the view just above the wizard definition?

https://codereview.tryton.org/380021002/diff/390421002/sale.xml#newcode244
sale.xml:244: 
I think this is the place where wizard and view should be defined.

https://codereview.tryton.org/380021002/diff/390421002/view/sale_point_open_s...
File view/sale_point_open_start_form.xml (right):

https://codereview.tryton.org/380021002/diff/390421002/view/sale_point_open_s...
view/sale_point_open_start_form.xml:5: <group col="2" xexpand="1"
id="select_sale_point">
There is not point to add a group