tryton-env: Add delivery note report in sale_supply_drop_shipment

COLLABORATOR=sergi@koolpi.com
issue11159

[pokoli, 2022-01-21 10:53:05]

https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/sale.xml (right):

https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/sale.xml:32: <record model="ir.action.report"
id="report_delivery_note_drop">
I think this should be included on stock.xml (as the model is defined there).

[reviewbot, 2022-01-21 10:54:50]

https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.py:606:
expected 2 blank lines, found 1


URL: https://codereview.tryton.org/380141002

[Davidoff, 2022-01-21 11:01:09]

Move xml content from sale to stock

[Davidoff, 2022-01-21 11:03:05]

Add missing blank line before class declaration

[reviewbot, 2022-01-21 11:21:54]

checks OK
URL: https://codereview.tryton.org/380141002

[ced, 2022-03-29 21:36:31]

https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/stock.xml (right):

https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:286: <field
name="report_name">stock.shipment.out.delivery_note</field>
I'm wondering if the report should not be renamed as:
stock.shipment.delivery_note.
This will ensure that we notice that it is used by many models.

https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:287: <field
name="report">stock/delivery_note.fodt</field>
There is a problem with the translation because currently trytond will create a
translation for this report and this module.
I think we must first improve trytond, maybe by skipping to translate report if
the path is not in the module of the record.

https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:290:
id="report_delivery_note_drop_keyword">
wrong indentation but mainly it does not need to be on a newline.

https://codereview.tryton.org/380141002/diff/384151002/modules/stock/delivery...
File modules/stock/delivery_note.fodt (right):

https://codereview.tryton.org/380141002/diff/384151002/modules/stock/delivery...
modules/stock/delivery_note.fodt:475: <text:p
text:style-name="P11"><text:placeholder text:placeholder-type="text">&lt;for
each=&quot;move in shipment.report_moves&quot;&gt;</text:placeholder></text:p>
It will be better to just edit this line.

[Davidoff, 2022-03-31 11:30:43]

Rename report, skip translation and edit just necessary line in report

[reviewbot, 2022-03-31 11:40:01]

checks OK
URL: https://codereview.tryton.org/380141002

[ced, 2022-03-31 11:46:23]

On 2022/03/31 11:30:43, Davidoff wrote:
> skip translation

Could you create a new issue and review with just this new feature.

[Davidoff, 2022-03-31 11:51:02]

Revert skip translation to make it in a new issue

[reviewbot, 2022-03-31 12:00:08]

checks OK
URL: https://codereview.tryton.org/380141002

[acaubet, 2022-05-10 08:58:52]

LGTM

[ced, 2022-09-10 08:04:52]

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/stock.py (right):

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.py:632: (m.origin_name for m in
self.moves))))
For me it will be against the goal to put the purchase order origin on the
delivery note.

I think we must have two origins fields.

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/stock.xml (right):

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:283: <record
model="ir.action.report" id="report_delivery_note_drop">
The convention would be to name it: report_shipment_drop_delivery_note

https://codereview.tryton.org/380141002/diff/378581002/modules/stock/shipment.py
File modules/stock/shipment.py (right):

https://codereview.tryton.org/380141002/diff/378581002/modules/stock/shipment...
modules/stock/shipment.py:1594: def report_moves(self):
I think it is better to name it: delivery_note_moves
because we can have other reports that use other moves.

[ced, 2022-09-10 08:10:51]

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/stock.xml (right):

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:283: <record
model="ir.action.report" id="report_delivery_note_drop">
No need for a new report action see https://bugs.tryton.org/issue11358#msg77968