Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 380141002: tryton-env: Add delivery note report in sale_supply_drop_shipment

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Davidoff
Modified:
4 months, 3 weeks ago
Reviewers:
pokoli, acaubet, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue11159

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move xml content from sale to stock #

Patch Set 3 : Add missing blank line before class declaration #

Total comments: 4

Patch Set 4 : Rename report, skip translation and edit just necessary line in report #

Patch Set 5 : Revert skip translation to make it in a new issue #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M modules/sale_supply_drop_shipment/CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M modules/sale_supply_drop_shipment/stock.py View 1 2 3 2 chunks +9 lines, -0 lines 1 comment Download
M modules/sale_supply_drop_shipment/stock.xml View 1 2 3 1 chunk +12 lines, -0 lines 2 comments Download
M modules/stock/delivery_note.fodt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M modules/stock/shipment.py View 1 2 3 2 chunks +5 lines, -1 line 1 comment Download
M modules/stock/shipment.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15
Davidoff
1 year ago (2022-01-21 10:47:43 UTC) #1
pokoli
https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_drop_shipment/sale.xml File modules/sale_supply_drop_shipment/sale.xml (right): https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_drop_shipment/sale.xml#newcode32 modules/sale_supply_drop_shipment/sale.xml:32: <record model="ir.action.report" id="report_delivery_note_drop"> I think this should be included ...
1 year ago (2022-01-21 10:53:05 UTC) #2
reviewbot
https://codereview.tryton.org/380141002/diff/389751002/modules/sale_supply_drop_shipment/stock.py#newcode606 modules/sale_supply_drop_shipment/stock.py:606: expected 2 blank lines, found 1 URL: https://codereview.tryton.org/380141002
1 year ago (2022-01-21 10:54:50 UTC) #3
Davidoff
Move xml content from sale to stock
1 year ago (2022-01-21 11:01:09 UTC) #4
Davidoff
Add missing blank line before class declaration
1 year ago (2022-01-21 11:03:05 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/380141002
1 year ago (2022-01-21 11:21:54 UTC) #6
ced
https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_drop_shipment/stock.xml File modules/sale_supply_drop_shipment/stock.xml (right): https://codereview.tryton.org/380141002/diff/384151002/modules/sale_supply_drop_shipment/stock.xml#newcode286 modules/sale_supply_drop_shipment/stock.xml:286: <field name="report_name">stock.shipment.out.delivery_note</field> I'm wondering if the report should not ...
10 months, 1 week ago (2022-03-29 21:36:31 UTC) #7
Davidoff
Rename report, skip translation and edit just necessary line in report
10 months, 1 week ago (2022-03-31 11:30:43 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/380141002
10 months, 1 week ago (2022-03-31 11:40:01 UTC) #9
ced
On 2022/03/31 11:30:43, Davidoff wrote: > skip translation Could you create a new issue and ...
10 months, 1 week ago (2022-03-31 11:46:23 UTC) #10
Davidoff
Revert skip translation to make it in a new issue
10 months, 1 week ago (2022-03-31 11:51:02 UTC) #11
reviewbot
checks OK URL: https://codereview.tryton.org/380141002
10 months, 1 week ago (2022-03-31 12:00:08 UTC) #12
acaubet
LGTM
8 months, 3 weeks ago (2022-05-10 08:58:52 UTC) #13
ced
https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_drop_shipment/stock.py File modules/sale_supply_drop_shipment/stock.py (right): https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_drop_shipment/stock.py#newcode632 modules/sale_supply_drop_shipment/stock.py:632: (m.origin_name for m in self.moves)))) For me it will ...
4 months, 3 weeks ago (2022-09-10 08:04:52 UTC) #14
ced
4 months, 3 weeks ago (2022-09-10 08:10:51 UTC) #15
https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
File modules/sale_supply_drop_shipment/stock.xml (right):

https://codereview.tryton.org/380141002/diff/378581002/modules/sale_supply_dr...
modules/sale_supply_drop_shipment/stock.xml:283: <record
model="ir.action.report" id="report_delivery_note_drop">
No need for a new report action see https://bugs.tryton.org/issue11358#msg77968
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted