Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 38161002: account: Ensure None are before 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 3 hours ago by ced
Modified:
2 days, 8 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The next index must point to the next value and not a None value which are skipped. issue7350

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M account.py View 2 chunks +5 lines, -2 lines 3 comments Download

Messages

Total messages: 6
ced
5 days, 3 hours ago (2018-04-14 21:19:19 UTC) #1
reviewbot
https://codereview.tryton.org/38161002/diff/1/account.py#newcode823 account.py:823: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
5 days, 3 hours ago (2018-04-14 21:26:12 UTC) #2
pokoli
https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get the ...
3 days, 16 hours ago (2018-04-16 08:12:41 UTC) #3
ced
https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get the ...
3 days, 16 hours ago (2018-04-16 08:44:11 UTC) #4
pokoli
LGTM https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get ...
3 days, 15 hours ago (2018-04-16 09:36:31 UTC) #5
rietveld-bot_tryton.org
2 days, 8 hours ago (2018-04-17 15:56:04 UTC) #6
New changeset 2ed70fd9affa by Cédric Krier in branch 'default':
Ensure None are before 0
http://hg.tryton.org/modules/account/rev/2ed70fd9affa
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922