Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 38161002: account: Ensure None are before 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ced
Modified:
2 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The next index must point to the next value and not a None value which are skipped. issue7350

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M account.py View 2 chunks +5 lines, -2 lines 3 comments Download

Messages

Total messages: 7
ced
3 months, 1 week ago (2018-04-14 21:19:19 UTC) #1
reviewbot
https://codereview.tryton.org/38161002/diff/1/account.py#newcode823 account.py:823: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
3 months, 1 week ago (2018-04-14 21:26:12 UTC) #2
pokoli
https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get the ...
3 months, 1 week ago (2018-04-16 08:12:41 UTC) #3
ced
https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get the ...
3 months, 1 week ago (2018-04-16 08:44:11 UTC) #4
pokoli
LGTM https://codereview.tryton.org/38161002/diff/1/account.py File account.py (right): https://codereview.tryton.org/38161002/diff/1/account.py#newcode2014 account.py:2014: # Ensure None are before 0 to get ...
3 months, 1 week ago (2018-04-16 09:36:31 UTC) #5
rietveld-bot_tryton.org
New changeset 2ed70fd9affa by Cédric Krier in branch 'default': Ensure None are before 0 http://hg.tryton.org/modules/account/rev/2ed70fd9affa
3 months ago (2018-04-17 15:56:04 UTC) #6
rietveld-bot_tryton.org
2 months, 3 weeks ago (2018-04-26 19:05:55 UTC) #7
New changeset a862552db316 by Cédric Krier in branch '4.6':
Ensure None are before 0
http://hg.tryton.org/modules/account/rev/a862552db316


New changeset a73ff767623e by Cédric Krier in branch '4.4':
Ensure None are before 0
http://hg.tryton.org/modules/account/rev/a73ff767623e


New changeset 9c460296b351 by Cédric Krier in branch '4.2':
Ensure None are before 0
http://hg.tryton.org/modules/account/rev/9c460296b351


New changeset 1cb459cd471e by Cédric Krier in branch '4.0':
Ensure None are before 0
http://hg.tryton.org/modules/account/rev/1cb459cd471e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69