Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 382061002: proteus: Allow to append, extend and remove by ids

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by Davidoff
Modified:
1 week, 4 days ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue11083

Patch Set 1 #

Patch Set 2 : Update test to use ids on append, extend and remove #

Total comments: 7

Patch Set 3 : Update to tip #

Patch Set 4 : Use get_config(), SelfModel -> Target, assert all values are int, not convert to list and keep test… #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M proteus/__init__.py View 1 2 3 3 chunks +9 lines, -1 line 1 comment Download
M proteus/tests/test_model.py View 1 2 3 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 11
Davidoff
5 months, 2 weeks ago (2022-02-28 08:37:57 UTC) #1
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/382061002
5 months, 2 weeks ago (2022-02-28 08:40:33 UTC) #2
pokoli
I think it will be good to update the test to use such feature so ...
5 months, 2 weeks ago (2022-03-01 09:03:48 UTC) #3
Davidoff
Update test to use ids on append, extend and remove
5 months, 1 week ago (2022-03-08 12:51:43 UTC) #4
reviewbot
patch is not applicable URL: https://codereview.tryton.org/382061002
5 months, 1 week ago (2022-03-08 13:02:36 UTC) #5
Davidoff
Update to tip
5 months, 1 week ago (2022-03-09 08:14:50 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/382061002
5 months, 1 week ago (2022-03-09 08:33:01 UTC) #7
ced
https://codereview.tryton.org/382061002/diff/378461002/proteus/__init__.py File proteus/__init__.py (right): https://codereview.tryton.org/382061002/diff/378461002/proteus/__init__.py#newcode579 proteus/__init__.py:579: SelfModel = Model.get(self.model_name) Better named Target. https://codereview.tryton.org/382061002/diff/378461002/proteus/__init__.py#newcode579 proteus/__init__.py:579: SelfModel ...
4 months, 2 weeks ago (2022-04-03 12:00:26 UTC) #8
Davidoff
Use get_config(), SelfModel -> Target, assert all values are int, not convert to list and ...
4 months, 1 week ago (2022-04-05 07:51:47 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/382061002
4 months, 1 week ago (2022-04-05 08:13:45 UTC) #10
ced
1 week, 4 days ago (2022-08-05 07:47:53 UTC) #11
https://codereview.tryton.org/382061002/diff/356311002/proteus/__init__.py
File proteus/__init__.py (right):

https://codereview.tryton.org/382061002/diff/356311002/proteus/__init__.py#ne...
proteus/__init__.py:579: Target = Model.get(self.model_name,
proteus.config.get_config())
The problem is that the current config may not be the config to which the
ModelList is attached to.
So it must use the config of the parent. I think if there is no parent we can
not support ids.

https://codereview.tryton.org/382061002/diff/356311002/proteus/tests/test_mod...
File proteus/tests/test_model.py (right):

https://codereview.tryton.org/382061002/diff/356311002/proteus/tests/test_mod...
proteus/tests/test_model.py:355: test.groups.extend(group_ids)
We still need to check that extending with instance is working.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted