Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 382201002: tryton-env: Remove migrations previous to 5.0

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by acaubet
Modified:
1 month, 3 weeks ago
Reviewers:
reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove imported but unused #

Patch Set 3 : Update to tip #

Patch Set 4 : Include trytond migrations #

Patch Set 5 : Update CHANGELOG #

Patch Set 6 : Fix CHANGELOG patching #

Patch Set 7 : Remove not used variables #

Patch Set 8 : Add Transaction import #

Patch Set 9 : Update to tip, remove migrations from 5.0 #

Patch Set 10 : Add missing migrations from trytond #

Patch Set 11 : Remove imported but unused #

Patch Set 12 : Do not remove migrations from 5.0 #

Patch Set 13 : Add rejected patch #

Patch Set 14 : Remove migrations missed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2523 lines) Patch
M modules/account/configuration.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -16 lines 0 comments Download
M modules/account/journal.py View 1 2 3 4 5 6 7 8 4 chunks +0 lines, -28 lines 0 comments Download
M modules/account/move.py View 1 2 3 4 5 6 7 8 3 chunks +1 line, -35 lines 0 comments Download
M modules/account/move_template.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M modules/account/party.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -20 lines 0 comments Download
M modules/account_asset/account.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/account_asset/asset.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M modules/account_asset/product.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -22 lines 0 comments Download
M modules/account_be/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M modules/account_be/account.py View 2 chunks +0 lines, -26 lines 0 comments Download
M modules/account_credit_limit/party.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/account_dunning/dunning.py View 1 2 3 4 5 6 7 8 3 chunks +1 line, -35 lines 0 comments Download
M modules/account_dunning/party.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M modules/account_fr/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/account_fr/account.py View 2 chunks +0 lines, -61 lines 0 comments Download
M modules/account_invoice/account.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -81 lines 0 comments Download
M modules/account_invoice/invoice.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +0 lines, -81 lines 0 comments Download
M modules/account_invoice/party.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M modules/account_invoice/payment_term.py View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +0 lines, -38 lines 0 comments Download
M modules/account_payment/account.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/account_payment/payment.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M modules/account_payment_sepa/account.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/account_payment_sepa/party.py View 2 chunks +0 lines, -25 lines 0 comments Download
M modules/account_payment_sepa/payment.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -21 lines 0 comments Download
M modules/account_payment_stripe/payment.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -14 lines 0 comments Download
M modules/account_product/product.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/account_statement/account.py View 2 chunks +0 lines, -35 lines 0 comments Download
M modules/account_statement/journal.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -23 lines 0 comments Download
M modules/account_statement/statement.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -10 lines 0 comments Download
M modules/account_stock_anglo_saxon/product.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -21 lines 0 comments Download
M modules/account_stock_continental/product.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -28 lines 0 comments Download
M modules/account_stock_landed_cost/account.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -25 lines 0 comments Download
M modules/analytic_account/account.py View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +1 line, -63 lines 0 comments Download
M modules/analytic_account/line.py View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +0 lines, -19 lines 0 comments Download
M modules/company/party.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -36 lines 0 comments Download
M modules/country/country.py View 1 chunk +0 lines, -9 lines 0 comments Download
M modules/currency/currency.py View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M modules/customs/product.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -22 lines 0 comments Download
M modules/party/address.py View 1 2 3 4 5 6 7 8 3 chunks +1 line, -16 lines 0 comments Download
M modules/party/category.py View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M modules/party/configuration.py View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -28 lines 0 comments Download
M modules/party/party.py View 1 2 3 4 5 6 7 8 5 chunks +1 line, -69 lines 0 comments Download
M modules/product/configuration.py View 1 2 3 2 chunks +0 lines, -20 lines 0 comments Download
M modules/product/product.py View 1 2 3 4 5 6 7 8 12 6 chunks +1 line, -116 lines 0 comments Download
M modules/production/configuration.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/production/production.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -15 lines 0 comments Download
M modules/project/work.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -76 lines 0 comments Download
M modules/project_plan/allocation.py View 1 chunk +0 lines, -9 lines 0 comments Download
M modules/purchase/configuration.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -37 lines 0 comments Download
M modules/purchase/product.py View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +0 lines, -32 lines 0 comments Download
M modules/purchase/purchase.py View 1 2 3 4 5 6 7 8 3 chunks +1 line, -54 lines 0 comments Download
M modules/purchase/stock.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -33 lines 0 comments Download
M modules/purchase_request/purchase_request.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -52 lines 0 comments Download
M modules/purchase_requisition/purchase.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale/configuration.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -37 lines 0 comments Download
M modules/sale/product.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -24 lines 0 comments Download
M modules/sale/sale.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale_complaint/complaint.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -11 lines 0 comments Download
M modules/sale_complaint/sale.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale_extra/sale.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -27 lines 0 comments Download
M modules/sale_invoice_grouping/party.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M modules/sale_opportunity/configuration.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale_opportunity/opportunity.py View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -41 lines 0 comments Download
M modules/sale_price_list/party.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale_shipment_cost/sale.py View 1 2 3 2 chunks +0 lines, -20 lines 0 comments Download
M modules/sale_shipment_grouping/party.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M modules/sale_subscription/subscription.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -18 lines 0 comments Download
M modules/sale_supply_drop_shipment/purchase.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -19 lines 0 comments Download
M modules/sale_supply_drop_shipment/sale.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M modules/sale_supply_drop_shipment/stock.py View 1 2 3 4 5 6 7 8 5 chunks +1 line, -85 lines 0 comments Download
M modules/stock/configuration.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -37 lines 0 comments Download
M modules/stock/inventory.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -30 lines 0 comments Download
M modules/stock/location.py View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -19 lines 0 comments Download
M modules/stock/move.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/shipment.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +0 lines, -35 lines 0 comments Download
M modules/stock_package/stock.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -20 lines 0 comments Download
M modules/stock_package_shipping/stock.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -17 lines 0 comments Download
M modules/stock_supply/order_point.py View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -22 lines 0 comments Download
M modules/timesheet/line.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -34 lines 0 comments Download
M modules/timesheet/work.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -39 lines 0 comments Download
M modules/timesheet_cost/timesheet.py View 2 chunks +1 line, -31 lines 0 comments Download
M modules/web_user/user.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -12 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/backend/sqlite/table.py View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
M trytond/trytond/ir/action.py View 1 2 3 4 5 6 7 8 10 11 3 chunks +0 lines, -39 lines 0 comments Download
M trytond/trytond/ir/attachment.py View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
M trytond/trytond/ir/model.py View 1 2 3 4 5 6 7 8 2 chunks +1 line, -20 lines 0 comments Download
M trytond/trytond/ir/module.py View 1 2 3 10 11 3 chunks +0 lines, -61 lines 0 comments Download
M trytond/trytond/ir/translation.py View 1 2 3 4 5 6 10 11 2 chunks +0 lines, -9 lines 0 comments Download
M trytond/trytond/ir/trigger.py View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M trytond/trytond/modules/__init__.py View 1 2 3 2 chunks +0 lines, -18 lines 0 comments Download
M trytond/trytond/res/user.py View 1 2 3 4 5 6 7 8 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 24
acaubet
4 months, 3 weeks ago (2022-03-21 16:21:18 UTC) #1
acaubet
Remove imported but unused
4 months, 3 weeks ago (2022-03-21 16:28:27 UTC) #2
reviewbot
patch is not applicable URL: https://codereview.tryton.org/382201002
4 months, 3 weeks ago (2022-03-21 16:29:23 UTC) #3
acaubet
Update to tip
4 months, 3 weeks ago (2022-03-21 16:32:24 UTC) #4
reviewbot
patch is not applicable URL: https://codereview.tryton.org/382201002
4 months, 3 weeks ago (2022-03-21 17:07:20 UTC) #5
acaubet
Include trytond migrations
4 months, 3 weeks ago (2022-03-22 11:19:49 UTC) #6
acaubet
Update CHANGELOG
4 months, 3 weeks ago (2022-03-22 11:25:31 UTC) #7
acaubet
Fix CHANGELOG patching
4 months, 3 weeks ago (2022-03-22 11:30:21 UTC) #8
reviewbot
https://codereview.tryton.org/382201002/diff/386251002/modules/purchase/product.py#newcode308 modules/purchase/product.py:308: local variable 'transaction' is assigned to but never used https://codereview.tryton.org/382201002/diff/386251002/trytond/trytond/ir/translation.py#newcode80 trytond/trytond/ir/translation.py:80: local variable ...
4 months, 3 weeks ago (2022-03-22 11:34:51 UTC) #9
acaubet
Remove not used variables
4 months, 3 weeks ago (2022-03-22 11:41:17 UTC) #10
reviewbot
https://codereview.tryton.org/382201002/diff/380581003/modules/purchase/product.py#newcode318 modules/purchase/product.py:318: undefined name 'Transaction' URL: https://codereview.tryton.org/382201002
4 months, 3 weeks ago (2022-03-22 12:05:28 UTC) #11
acaubet
Add Transaction import
4 months, 3 weeks ago (2022-03-22 12:30:13 UTC) #12
reviewbot
checks OK URL: https://codereview.tryton.org/382201002
4 months, 3 weeks ago (2022-03-22 13:09:49 UTC) #13
acaubet
Update to tip, remove migrations from 5.0
2 months, 4 weeks ago (2022-05-16 10:46:21 UTC) #14
reviewbot
https://codereview.tryton.org/382201002/diff/441101003/modules/account_invoice/party.py#newcode4 modules/account_invoice/party.py:4: 'trytond.model.ModelView' imported but unused https://codereview.tryton.org/382201002/diff/441101003/modules/stock_supply_day/purchase.py#newcode6 modules/stock_supply_day/purchase.py:6: 'trytond.pool.Pool' imported but unused URL: https://codereview.tryton.org/382201002
2 months, 4 weeks ago (2022-05-16 10:49:25 UTC) #15
acaubet
Add missing migrations from trytond
2 months, 4 weeks ago (2022-05-16 10:53:43 UTC) #16
acaubet
Remove imported but unused
2 months, 4 weeks ago (2022-05-16 10:59:59 UTC) #17
reviewbot
https://codereview.tryton.org/382201002/diff/439131003/modules/account_invoice/party.py#newcode4 modules/account_invoice/party.py:4: 'trytond.model.ModelView' imported but unused URL: https://codereview.tryton.org/382201002
2 months, 4 weeks ago (2022-05-16 11:18:46 UTC) #18
acaubet
Do not remove migrations from 5.0
2 months, 2 weeks ago (2022-05-30 15:01:41 UTC) #19
reviewbot
https://codereview.tryton.org/382201002/diff/437121003/modules/account_invoice/party.py#newcode4 modules/account_invoice/party.py:4: 'trytond.model.ModelView' imported but unused URL: https://codereview.tryton.org/382201002
2 months, 2 weeks ago (2022-05-30 15:04:56 UTC) #20
acaubet
Add rejected patch
2 months, 2 weeks ago (2022-05-30 15:06:30 UTC) #21
acaubet
Remove migrations missed
2 months, 2 weeks ago (2022-05-30 15:32:47 UTC) #22
reviewbot
https://codereview.tryton.org/382201002/diff/427271003/modules/account_invoice/party.py#newcode4 modules/account_invoice/party.py:4: 'trytond.model.ModelView' imported but unused URL: https://codereview.tryton.org/382201002
2 months, 2 weeks ago (2022-05-30 15:35:37 UTC) #23
acaubet
1 month, 3 weeks ago (2022-06-20 08:35:29 UTC) #24
On 2022/05/30 15:35:37, reviewbot wrote:
>
https://codereview.tryton.org/382201002/diff/427271003/modules/account_invoic...
> modules/account_invoice/party.py:4:
> 'trytond.model.ModelView' imported but unused
> 
> 
> URL: https://codereview.tryton.org/382201002

I have some dubts:
- Should I fix this import warning from reviewbot? (it's not related to my
change)
- Should I remove migrate_property if it's no longer used after the patch?
https://hg.tryton.org/trytond/file/f2445b194ca4/trytond/tools/multivalue.py#l13
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted