trytond: Add a default static route for each module

COLLABORATOR=sergi@koolpi.com
issue8957

[reviewbot, 2021-10-25 11:26:07]

flake8 OK
URL: https://codereview.tryton.org/383441002

[pokoli, 2021-10-25 11:26:59]

Missing changelog entry

https://codereview.tryton.org/383441002/diff/350881002/trytond/ir/routes.py
File trytond/ir/routes.py (right):

https://codereview.tryton.org/383441002/diff/350881002/trytond/ir/routes.py#n...
trytond/ir/routes.py:8: import os
we group import into three diferent topics: 

- python language imports
- external libraries
- Own imports (trytond.*)

Could you please follow this convention? 
Also please sort imports in alphabetical order (including first import ... and
latter from ... import ...)

[Davidoff, 2021-10-25 11:37:46]

Follow import convention and add changelog entry

[reviewbot, 2021-10-25 11:53:07]

flake8 OK
URL: https://codereview.tryton.org/383441002

[pokoli, 2021-11-25 10:17:51]

https://codereview.tryton.org/383441002/diff/350891002/CHANGELOG
File CHANGELOG (right):

https://codereview.tryton.org/383441002/diff/350891002/CHANGELOG#newcode1
CHANGELOG:1: * Add a default static route for each module
Should be updated as 6.2 is released now

https://codereview.tryton.org/383441002/diff/350891002/trytond/ir/routes.py
File trytond/ir/routes.py (right):

https://codereview.tryton.org/383441002/diff/350891002/trytond/ir/routes.py#n...
trytond/ir/routes.py:314: return fp.read()
I think you should return a Reponse with the right mimetype (like done in
avatars). 

You can use the mimetype library [1] for determining the right mimetype based on
the filename.

[1] https://docs.python.org/3/library/mimetypes.html

[Davidoff, 2021-11-25 12:22:21]

Return a Response with the right mimetype and update CHANGELOG

[reviewbot, 2021-11-25 12:30:34]

flake8 OK
URL: https://codereview.tryton.org/383441002

[pokoli, 2021-12-27 11:07:19]

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py
File trytond/ir/routes.py (right):

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#n...
trytond/ir/routes.py:312: @app.route('/static/modules/<module>/<file>')
I think there is no need to include modules in the route name. It can just be: 

'/static/<module>/<file>'

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#n...
trytond/ir/routes.py:315: with file_open(os.path.join(module, 'static', file),
mode='rb') as fp:
better to define a path variable: 

file_path = os.path.join(...)

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#n...
trytond/ir/routes.py:316: value = fp.read()
no need to save a value variable. Just call read when needed.

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#n...
trytond/ir/routes.py:317: type = mimetypes.guess_type(os.path.join(module,
'static', file))
you can use: 

type, _ = 

so the second argument is ignored

https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#n...
trytond/ir/routes.py:318: response = Response(value, mimetype=type[0])
no need to save a response variable. It can be returned directly.

[Davidoff, 2021-12-30 11:01:31]

Remove modules from the route name, define path variable and do not save
unnecessary variables.

[reviewbot, 2021-12-30 11:19:29]

ERROR: /tmp/reviewbot-kwnst6l6/trytond/ir/routes.py Imports are incorrectly
sorted and/or formatted.

URL: https://codereview.tryton.org/383441002

[Davidoff, 2021-12-30 11:31:55]

Sort imports correctly

[reviewbot, 2021-12-30 11:50:43]

checks OK
URL: https://codereview.tryton.org/383441002

[pokoli, 2022-03-01 09:28:15]

could you update it to tip?

[Davidoff, 2022-03-01 10:55:59]

Update to tip

[reviewbot, 2022-03-01 11:02:03]

checks OK
URL: https://codereview.tryton.org/383441002

[Davidoff, 2022-04-06 10:51:26]

Update to tip

[pokoli, 2022-04-06 10:58:12]

LGTM

[reviewbot, 2022-04-06 11:14:13]

checks OK
URL: https://codereview.tryton.org/383441002

[acaubet, 2022-05-10 08:53:16]

https://codereview.tryton.org/383441002/diff/384911002/trytond/ir/routes.py
File trytond/ir/routes.py (right):

https://codereview.tryton.org/383441002/diff/384911002/trytond/ir/routes.py#n...
trytond/ir/routes.py:315: file_path = os.path.join(module, 'static', file)
I do not think that this code prevent path traversal security issue.