Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 383441002: trytond: Add a default static route for each module

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by Davidoff
Modified:
2 weeks, 3 days ago
Reviewers:
pokoli, acaubet, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue8957

Patch Set 1 #

Total comments: 1

Patch Set 2 : Follow import convention and add changelog entry #

Total comments: 2

Patch Set 3 : Return a Response with the right mimetype and update CHANGELOG #

Total comments: 5

Patch Set 4 : Remove modules from the route name, define path variable and do not save unnecessary variables. #

Patch Set 5 : Sort imports correctly #

Patch Set 6 : Update to tip #

Patch Set 7 : Update to tip #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/routes.py View 1 2 3 4 3 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 20
Davidoff
7 months ago (2021-10-25 11:21:56 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/383441002
7 months ago (2021-10-25 11:26:07 UTC) #2
pokoli
Missing changelog entry https://codereview.tryton.org/383441002/diff/350881002/trytond/ir/routes.py File trytond/ir/routes.py (right): https://codereview.tryton.org/383441002/diff/350881002/trytond/ir/routes.py#newcode8 trytond/ir/routes.py:8: import os we group import into ...
7 months ago (2021-10-25 11:26:59 UTC) #3
Davidoff
Follow import convention and add changelog entry
7 months ago (2021-10-25 11:37:46 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/383441002
7 months ago (2021-10-25 11:53:07 UTC) #5
pokoli
https://codereview.tryton.org/383441002/diff/350891002/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/383441002/diff/350891002/CHANGELOG#newcode1 CHANGELOG:1: * Add a default static route for each module ...
6 months ago (2021-11-25 10:17:51 UTC) #6
Davidoff
Return a Response with the right mimetype and update CHANGELOG
6 months ago (2021-11-25 12:22:21 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/383441002
6 months ago (2021-11-25 12:30:34 UTC) #8
pokoli
https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py File trytond/ir/routes.py (right): https://codereview.tryton.org/383441002/diff/374291002/trytond/ir/routes.py#newcode312 trytond/ir/routes.py:312: @app.route('/static/modules/<module>/<file>') I think there is no need to include ...
5 months ago (2021-12-27 11:07:19 UTC) #9
Davidoff
Remove modules from the route name, define path variable and do not save unnecessary variables.
4 months, 4 weeks ago (2021-12-30 11:01:31 UTC) #10
reviewbot
ERROR: /tmp/reviewbot-kwnst6l6/trytond/ir/routes.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/383441002
4 months, 4 weeks ago (2021-12-30 11:19:29 UTC) #11
Davidoff
Sort imports correctly
4 months, 4 weeks ago (2021-12-30 11:31:55 UTC) #12
reviewbot
checks OK URL: https://codereview.tryton.org/383441002
4 months, 4 weeks ago (2021-12-30 11:50:43 UTC) #13
pokoli
could you update it to tip?
2 months, 3 weeks ago (2022-03-01 09:28:15 UTC) #14
Davidoff
Update to tip
2 months, 3 weeks ago (2022-03-01 10:55:59 UTC) #15
reviewbot
checks OK URL: https://codereview.tryton.org/383441002
2 months, 3 weeks ago (2022-03-01 11:02:03 UTC) #16
Davidoff
Update to tip
1 month, 3 weeks ago (2022-04-06 10:51:26 UTC) #17
pokoli
LGTM
1 month, 3 weeks ago (2022-04-06 10:58:12 UTC) #18
reviewbot
checks OK URL: https://codereview.tryton.org/383441002
1 month, 3 weeks ago (2022-04-06 11:14:13 UTC) #19
acaubet
2 weeks, 3 days ago (2022-05-10 08:53:16 UTC) #20
https://codereview.tryton.org/383441002/diff/384911002/trytond/ir/routes.py
File trytond/ir/routes.py (right):

https://codereview.tryton.org/383441002/diff/384911002/trytond/ir/routes.py#n...
trytond/ir/routes.py:315: file_path = os.path.join(module, 'static', file)
I do not think that this code prevent path traversal security issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted