Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 38401002: trytond: Add flexible active and remove active_test

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by pokoli
Modified:
22 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't remove user context on validate #

Patch Set 3 : -n #

Patch Set 4 : Remove active field for all list views #

Patch Set 5 : Remove active_name and keep active_test #

Patch Set 6 : Do not set active fields on views #

Total comments: 2

Patch Set 7 : Remove empty line and add test for model without active #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/view/action_act_window_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/action_act_window_view_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/action_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/action_report_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/action_url_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/action_wizard_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/cron_list.xml View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/lang_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/model_button_click_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/sequence_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/trigger_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/ir/view/ui_menu_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/model/modelview.py View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M trytond/res/view/user_list.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M trytond/tests/__init__.py View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M trytond/tests/modelview.py View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M trytond/tests/test_modelview.py View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15
pokoli
7 months, 3 weeks ago (2017-06-06 14:37:11 UTC) #1
reviewbot
https://codereview.tryton.org/38401002/diff/1/trytond/tests/__init__.py#newcode5 trytond/tests/__init__.py:5: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/38401002/diff/1/trytond/tests/__init__.py#newcode6 trytond/tests/__init__.py:6: ...
7 months, 3 weeks ago (2017-06-06 14:39:52 UTC) #2
ced
https://tryton-rietveld.appspot.com/38401002/diff/1/trytond/model/modelstorage.py File trytond/model/modelstorage.py (left): https://tryton-rietveld.appspot.com/38401002/diff/1/trytond/model/modelstorage.py#oldcode980 trytond/model/modelstorage.py:980: with Transaction().set_context(ctx_pref): Why removing?
7 months, 3 weeks ago (2017-06-06 21:02:09 UTC) #3
pokoli
Don't remove user context on validate
7 months, 3 weeks ago (2017-06-07 11:07:32 UTC) #4
reviewbot
https://codereview.tryton.org/38401002/diff/20001/trytond/tests/__init__.py#newcode5 trytond/tests/__init__.py:5: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/38401002/diff/20001/trytond/tests/__init__.py#newcode6 trytond/tests/__init__.py:6: ...
7 months, 2 weeks ago (2017-06-07 11:33:39 UTC) #5
pokoli
-n
7 months, 2 weeks ago (2017-06-08 09:20:01 UTC) #6
pokoli
Remove active field for all list views
7 months, 2 weeks ago (2017-06-08 09:21:21 UTC) #7
reviewbot
patch is not applicable URL: https://codereview.tryton.org/38401002
7 months, 2 weeks ago (2017-06-08 09:34:36 UTC) #8
pokoli
Remove active_name and keep active_test
1 month ago (2017-12-20 16:35:54 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/38401002
1 month ago (2017-12-20 16:44:52 UTC) #10
pokoli
Do not set active fields on views
1 month ago (2017-12-21 09:32:19 UTC) #11
reviewbot
https://codereview.tryton.org/38401002/diff/90001/trytond/tests/__init__.py#newcode11 trytond/tests/__init__.py:11: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/38401002/diff/90001/trytond/tests/__init__.py#newcode12 trytond/tests/__init__.py:12: ...
1 month ago (2017-12-21 09:48:42 UTC) #12
ced
https://codereview.tryton.org/38401002/diff/90001/trytond/model/modelview.py File trytond/model/modelview.py (left): https://codereview.tryton.org/38401002/diff/90001/trytond/model/modelview.py#oldcode427 trytond/model/modelview.py:427: not for this patch https://codereview.tryton.org/38401002/diff/90001/trytond/tests/test_modelview.py File trytond/tests/test_modelview.py (right): https://codereview.tryton.org/38401002/diff/90001/trytond/tests/test_modelview.py#newcode316 ...
2 weeks ago (2018-01-09 18:12:26 UTC) #13
pokoli
Remove empty line and add test for model without active
22 hours, 7 minutes ago (2018-01-23 13:00:14 UTC) #14
reviewbot
22 hours ago (2018-01-23 13:07:13 UTC) #15
https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:11:
F403 'from test import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:12:
F403 'from model import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:13:
F403 'from modelview import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:14:
F403 'from mptt import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:15:
F403 'from import_data import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:16:
F403 'from export_data import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:17:
F403 'from trigger import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:18:
F403 'from access import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:19:
F403 'from wizard import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:20:
F403 'from workflow import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:21:
F403 'from copy_ import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:22:
F403 'from history import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:23:
F403 'from field_context import *' used; unable to detect undefined names

https://codereview.tryton.org/38401002/diff/110001/trytond/model/modelview.py...
trytond/model/modelview.py:449:
E303 too many blank lines (2)

URL: https://codereview.tryton.org/38401002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922