Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(853)

Issue 38711002: marketing_email: WIP

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by ced
Modified:
2 weeks, 1 day ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Make token required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1662 lines, -0 lines) Patch
A .drone.yml View 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +14 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +29 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +20 lines, -0 lines 0 comments Download
A doc/index.rst View 1 chunk +2 lines, -0 lines 0 comments Download
A email_subscribe.html View 1 chunk +42 lines, -0 lines 0 comments Download
A email_unsubscribe.html View 1 chunk +42 lines, -0 lines 0 comments Download
A marketing.py View 1 1 chunk +281 lines, -0 lines 0 comments Download
A marketing.xml View 1 chunk +134 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +128 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/test_marketing_email.py View 1 chunk +122 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 chunk +9 lines, -0 lines 0 comments Download
A view/email_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/email_list.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/email_list_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/email_list_list.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9
ced
2 months, 3 weeks ago (2017-09-19 17:23:10 UTC) #1
reviewbot
https://codereview.tryton.org/38711002/diff/1/setup.py#newcode93 setup.py:93: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38711002/diff/1/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months, 3 weeks ago (2017-09-19 17:50:01 UTC) #2
pokoli
2 months, 3 weeks ago (2017-09-20 11:42:31 UTC) #3
pokoli
https://tryton-rietveld.appspot.com/38711002/diff/1/marketing.py File marketing.py (right): https://tryton-rietveld.appspot.com/38711002/diff/1/marketing.py#newcode135 marketing.py:135: for token in tokens: why not calling with a ...
2 weeks, 2 days ago (2017-11-29 11:59:56 UTC) #4
ced
https://codereview.tryton.org/38711002/diff/1/marketing.py File marketing.py (right): https://codereview.tryton.org/38711002/diff/1/marketing.py#newcode135 marketing.py:135: for token in tokens: On 2017/11/29 11:59:56, pokoli wrote: ...
2 weeks, 2 days ago (2017-11-29 14:12:20 UTC) #5
pokoli
https://codereview.tryton.org/38711002/diff/1/marketing.py File marketing.py (right): https://codereview.tryton.org/38711002/diff/1/marketing.py#newcode135 marketing.py:135: for token in tokens: On 2017/11/29 14:12:20, ced wrote: ...
2 weeks, 2 days ago (2017-11-29 14:33:46 UTC) #6
ced
https://codereview.tryton.org/38711002/diff/1/marketing.py File marketing.py (right): https://codereview.tryton.org/38711002/diff/1/marketing.py#newcode135 marketing.py:135: for token in tokens: On 2017/11/29 14:33:46, pokoli wrote: ...
2 weeks, 2 days ago (2017-11-29 15:13:06 UTC) #7
ced
Make token required
2 weeks, 1 day ago (2017-11-30 14:17:21 UTC) #8
reviewbot
2 weeks, 1 day ago (2017-11-30 14:37:18 UTC) #9
https://codereview.tryton.org/38711002/diff/20001/setup.py#newcode93
setup.py:93:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/38711002/diff/20001/tests/__init__.py#newcode5
tests/__init__.py:5:
E501 line too long (80 > 79 characters)

URL: https://codereview.tryton.org/38711002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922