Issue 387641002: sale_complaint: Require sequence configuration for complaint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 387641002: sale_complaint: Require sequence configuration for complaint (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 months ago by acaubet

Modified:
3 months, 3 weeks ago

Reviewers:
raimonesteve, reviewbot, rietveld-bot, ced, udono

Visibility:
Public.

More Reviews

Patch Set 2 : Set complaint_sequence as required #

Created: 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sale.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

reviewbot

ERROR: /tmp/reviewbot-1frpb6es/complaint.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/387641002

5 months ago (2021-12-28 09:11:54 UTC) #2

raimonesteve

https://codereview.tryton.org/387641002/diff/393251002/complaint.py File complaint.py (right): https://codereview.tryton.org/387641002/diff/393251002/complaint.py#newcode267 complaint.py:267: config_value = config.get_multivalue( replace "config_value" to "complaint_sequence" ?

4 months, 4 weeks ago (2021-12-29 09:32:06 UTC) #4

udono

On 2021/12/28 09:39:49, ced wrote: > For me the complaint_sequence must be required instead. For ...

4 months, 4 weeks ago (2021-12-29 22:47:18 UTC) #5

rietveld-bot_tryton.org

3 months, 3 weeks ago (2022-02-04 20:32:16 UTC) #9

New changeset e13b8b7a07b8 by Adrià Tarroja Caubet in branch 'default':
Require sequence configuration for complaint
https://hg.tryton.org/modules/sale_complaint/rev/e13b8b7a07b8

Expand All Messages | Collapse All Messages