Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 387641002: sale_complaint: Require sequence configuration for complaint (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by acaubet
Modified:
3 months, 3 weeks ago
Reviewers:
raimonesteve, reviewbot, rietveld-bot, ced, udono
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Set complaint_sequence as required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sale.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9
acaubet
5 months ago (2021-12-28 09:08:59 UTC) #1
reviewbot
ERROR: /tmp/reviewbot-1frpb6es/complaint.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/387641002
5 months ago (2021-12-28 09:11:54 UTC) #2
ced
For me the complaint_sequence must be required instead.
5 months ago (2021-12-28 09:39:49 UTC) #3
raimonesteve
https://codereview.tryton.org/387641002/diff/393251002/complaint.py File complaint.py (right): https://codereview.tryton.org/387641002/diff/393251002/complaint.py#newcode267 complaint.py:267: config_value = config.get_multivalue( replace "config_value" to "complaint_sequence" ?
4 months, 4 weeks ago (2021-12-29 09:32:06 UTC) #4
udono
On 2021/12/28 09:39:49, ced wrote: > For me the complaint_sequence must be required instead. For ...
4 months, 4 weeks ago (2021-12-29 22:47:18 UTC) #5
acaubet
Set complaint_sequence as required
4 months ago (2022-01-24 14:43:09 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/387641002
4 months ago (2022-01-24 15:09:50 UTC) #7
ced
LGTM
3 months, 3 weeks ago (2022-02-04 20:31:19 UTC) #8
rietveld-bot_tryton.org
3 months, 3 weeks ago (2022-02-04 20:32:16 UTC) #9
New changeset e13b8b7a07b8 by AdriĆ  Tarroja Caubet in branch 'default':
Require sequence configuration for complaint
https://hg.tryton.org/modules/sale_complaint/rev/e13b8b7a07b8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted