Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

Issue 38821002: sale_promotion_coupon: Initial commit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by ced
Modified:
1 month ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add search test #

Patch Set 3 : Avoid not null being null #

Patch Set 4 : Correctly delete coupons on sale canceled #

Patch Set 5 : Update to 3.7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1535 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +14 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +29 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +22 lines, -0 lines 0 comments Download
A doc/index.rst View 1 chunk +18 lines, -0 lines 0 comments Download
A sale.py View 1 2 3 1 chunk +236 lines, -0 lines 0 comments Download
A sale.xml View 1 chunk +72 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 1 chunk +126 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/scenario_sale_promotion_coupon.rst View 1 2 3 1 chunk +122 lines, -0 lines 0 comments Download
A tests/test_sale_promotion_coupon.py View 1 chunk +28 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A view/coupon_form.xml View 1 chunk +14 lines, -0 lines 0 comments Download
A view/coupon_list.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/coupon_number_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/coupon_number_list.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/promotion_form.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/sale_form.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11
ced
3 months, 3 weeks ago (2017-10-04 13:52:49 UTC) #1
reviewbot
https://codereview.tryton.org/38821002/diff/1/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38821002/diff/1/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 3 weeks ago (2017-10-04 14:08:16 UTC) #2
ced
Add search test
3 months, 2 weeks ago (2017-10-11 12:44:37 UTC) #3
reviewbot
https://codereview.tryton.org/38821002/diff/20001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38821002/diff/20001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 2 weeks ago (2017-10-11 12:46:14 UTC) #4
ced
Avoid not null being null
3 months, 2 weeks ago (2017-10-11 12:50:17 UTC) #5
reviewbot
https://codereview.tryton.org/38821002/diff/40001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38821002/diff/40001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 2 weeks ago (2017-10-11 13:14:07 UTC) #6
ced
Correctly delete coupons on sale canceled
1 month, 3 weeks ago (2017-12-01 10:34:44 UTC) #7
reviewbot
https://codereview.tryton.org/38821002/diff/60001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38821002/diff/60001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
1 month, 3 weeks ago (2017-12-01 10:56:18 UTC) #8
ced
Update to 3.7
1 month ago (2017-12-20 18:00:04 UTC) #9
rietveld-bot_tryton.org
New changeset ea6d4fd5a7e8 by Cédric Krier in branch 'default': Initial commit http://hg.tryton.org/modules/sale_promotion_coupon/rev/ea6d4fd5a7e8
1 month ago (2017-12-20 18:04:25 UTC) #10
reviewbot
1 month ago (2017-12-20 18:10:04 UTC) #11
patch is not applicable
URL: https://codereview.tryton.org/38821002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922