Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 38831002: relatorio: Remove soft-page-break

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by ced
Modified:
2 weeks ago
Reviewers:
nicoe, reviewbot
Visibility:
Public.

Description

bug38

Patch Set 1 #

Patch Set 2 : Fix use-soft-page-breaks #

Total comments: 5

Patch Set 3 : Do not remove text tag but just the attribute #

Patch Set 4 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -2 lines) Patch
M CHANGES View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M relatorio/templates/opendocument.py View 1 2 3 chunks +32 lines, -0 lines 0 comments Download
M relatorio/tests/test_odt.py View 3 chunks +75 lines, -2 lines 0 comments Download

Messages

Total messages: 13
ced
2 weeks, 4 days ago (2017-10-04 21:56:02 UTC) #1
ced
Fix use-soft-page-breaks
2 weeks, 4 days ago (2017-10-04 22:06:36 UTC) #2
ced
ping @nicoe
2 weeks, 4 days ago (2017-10-04 22:07:29 UTC) #3
reviewbot
https://codereview.tryton.org/38831002/diff/20001/relatorio/tests/test_odt.py#newcode129 relatorio/tests/test_odt.py:129: E501 line too long (135 > 79 characters) https://codereview.tryton.org/38831002/diff/20001/relatorio/tests/test_odt.py#newcode156 relatorio/tests/test_odt.py:156: E501 line too ...
2 weeks, 4 days ago (2017-10-04 22:08:00 UTC) #4
nicoe
https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py File relatorio/templates/opendocument.py (right): https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py#newcode225 relatorio/templates/opendocument.py:225: previous.tail += node.tail Shouldn't it be ' ' + ...
2 weeks, 3 days ago (2017-10-05 10:57:38 UTC) #5
nicoe
https://codereview.tryton.org/38831002/diff/20001/relatorio/tests/test_odt.py File relatorio/tests/test_odt.py (right): https://codereview.tryton.org/38831002/diff/20001/relatorio/tests/test_odt.py#newcode378 relatorio/tests/test_odt.py:378: b'''<parent>texttail</parent>''') I am not sure about this test if ...
2 weeks, 3 days ago (2017-10-05 10:59:04 UTC) #6
ced
https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py File relatorio/templates/opendocument.py (right): https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py#newcode225 relatorio/templates/opendocument.py:225: previous.tail += node.tail On 2017/10/05 10:57:38, nicoe wrote: > ...
2 weeks, 3 days ago (2017-10-05 11:17:43 UTC) #7
ced
Do not remove text tag but just the attribute
2 weeks, 3 days ago (2017-10-05 22:00:37 UTC) #8
reviewbot
https://codereview.tryton.org/38831002/diff/30001/relatorio/tests/test_odt.py#newcode129 relatorio/tests/test_odt.py:129: E501 line too long (135 > 79 characters) https://codereview.tryton.org/38831002/diff/30001/relatorio/tests/test_odt.py#newcode156 relatorio/tests/test_odt.py:156: E501 line too ...
2 weeks, 3 days ago (2017-10-05 22:17:34 UTC) #9
nicoe
https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py File relatorio/templates/opendocument.py (right): https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py#newcode225 relatorio/templates/opendocument.py:225: previous.tail += node.tail On 2017/10/05 11:17:42, ced wrote: > ...
2 weeks, 2 days ago (2017-10-06 08:25:26 UTC) #10
ced
On 2017/10/06 08:25:26, nicoe wrote: > https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py > File relatorio/templates/opendocument.py (right): > > https://codereview.tryton.org/38831002/diff/20001/relatorio/templates/opendocument.py#newcode225 > ...
2 weeks, 2 days ago (2017-10-06 08:37:47 UTC) #11
ced
Update to tip
2 weeks ago (2017-10-08 16:00:57 UTC) #12
reviewbot
2 weeks ago (2017-10-08 16:07:04 UTC) #13
https://codereview.tryton.org/38831002/diff/50001/relatorio/tests/test_odt.py...
relatorio/tests/test_odt.py:129:
E501 line too long (135 > 79 characters)

https://codereview.tryton.org/38831002/diff/50001/relatorio/tests/test_odt.py...
relatorio/tests/test_odt.py:156:
E501 line too long (125 > 79 characters)

https://codereview.tryton.org/38831002/diff/50001/relatorio/tests/test_odt.py...
relatorio/tests/test_odt.py:173:
E501 line too long (127 > 79 characters)

https://codereview.tryton.org/38831002/diff/50001/relatorio/tests/test_odt.py...
relatorio/tests/test_odt.py:234:
E501 line too long (107 > 79 characters)

URL: https://codereview.tryton.org/38831002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842