Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 38931002: stock: Do not delete inventory line of inactive product (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by albert
Modified:
23 hours, 12 minutes ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

On the first run, inactive products with stock quantity are created, so we must not delete them on the second call. issue6931

Patch Set 1 #

Patch Set 2 : Remove active check for products #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M inventory.py View 1 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 10
albert
3 months, 2 weeks ago (2017-11-10 23:57:37 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/38931002
3 months, 2 weeks ago (2017-11-10 23:58:55 UTC) #2
albert
3 months, 2 weeks ago (2017-11-11 00:01:40 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/38931002
3 months, 2 weeks ago (2017-11-11 00:31:53 UTC) #4
pokoli
https://codereview.tryton.org/38931002/diff/20001/inventory.py File inventory.py (right): https://codereview.tryton.org/38931002/diff/20001/inventory.py#newcode230 inventory.py:230: if not (line.product.type == 'goods' Indeed, I think it's ...
3 months, 2 weeks ago (2017-11-13 08:22:12 UTC) #5
pokoli
Missing issue_id on description
3 months, 2 weeks ago (2017-11-13 08:23:05 UTC) #6
ced
I find the title not descriptive. I would go with something like: "Do not delete ...
3 months, 1 week ago (2017-11-16 10:06:18 UTC) #7
ced
LGTM as I update the description myself.
1 week, 5 days ago (2018-02-13 18:25:53 UTC) #8
rietveld-bot_tryton.org
New changeset 7078f9a653db by Albert Cervera i Areny in branch 'default': Do not delete inventory ...
1 week, 5 days ago (2018-02-13 18:26:32 UTC) #9
rietveld-bot_tryton.org
23 hours, 12 minutes ago (2018-02-24 23:59:05 UTC) #10
New changeset 07ebc783b700 by Albert Cervera i Areny in branch '4.6':
Do not delete inventory line of inactive product
http://hg.tryton.org/modules/stock/rev/07ebc783b700


New changeset 01a8cefa0e1b by Albert Cervera i Areny in branch '4.4':
Do not delete inventory line of inactive product
http://hg.tryton.org/modules/stock/rev/01a8cefa0e1b


New changeset e00444f40580 by Albert Cervera i Areny in branch '4.2':
Do not delete inventory line of inactive product
http://hg.tryton.org/modules/stock/rev/e00444f40580


New changeset 74c14fb5c975 by Albert Cervera i Areny in branch '4.0':
Do not delete inventory line of inactive product
http://hg.tryton.org/modules/stock/rev/74c14fb5c975


New changeset d5cb31e65d2e by Albert Cervera i Areny in branch '3.8':
Do not delete inventory line of inactive product
http://hg.tryton.org/modules/stock/rev/d5cb31e65d2e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922