Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 389711002: sao 6.2: Propagate changed status to parent on instance button activation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by nicoe
Modified:
4 months, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

sao 6.2: Propagate changed status to parent on instance button activation issue11145

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use a loop instead of a recursive function #

Total comments: 2

Patch Set 3 : Call group.changed() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/screen.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13
nicoe
5 months, 2 weeks ago (2022-01-18 13:30:27 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/389711002
5 months, 2 weeks ago (2022-01-18 13:56:53 UTC) #2
ced
https://codereview.tryton.org/389711002/diff/397101002/src/model.js File src/model.js (right): https://codereview.tryton.org/389711002/diff/397101002/src/model.js#newcode1489 src/model.js:1489: _set_modified: function() { I prefer to not create new ...
5 months, 1 week ago (2022-01-24 20:56:09 UTC) #3
nicoe
5 months, 1 week ago (2022-01-25 08:22:43 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/389711002
5 months, 1 week ago (2022-01-25 08:43:21 UTC) #5
ced
https://codereview.tryton.org/389711002/diff/381791002/src/screen.js File src/screen.js (right): https://codereview.tryton.org/389711002/diff/381791002/src/screen.js#newcode1993 src/screen.js:1993: } Is it not enough to just do: record.group.changed()
5 months, 1 week ago (2022-01-25 08:58:44 UTC) #6
nicoe
5 months, 1 week ago (2022-01-25 12:09:50 UTC) #7
nicoe
https://codereview.tryton.org/389711002/diff/381791002/src/screen.js File src/screen.js (right): https://codereview.tryton.org/389711002/diff/381791002/src/screen.js#newcode1993 src/screen.js:1993: } On 2022/01/25 08:58:44, ced wrote: > Is it ...
5 months, 1 week ago (2022-01-25 12:10:09 UTC) #8
ced
LGTM
5 months, 1 week ago (2022-01-25 12:14:21 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/389711002
5 months, 1 week ago (2022-01-25 12:15:42 UTC) #10
rietveld-bot_tryton.org
New changeset a5bef51d8277 by Nicolas Évrard in branch '6.2': Propagate changed status to parent on ...
5 months ago (2022-02-03 15:22:28 UTC) #11
rietveld-bot_tryton.org
New changeset 4b5e6140185e by Nicolas Évrard in branch '6.2': Propagate changed status to parent on ...
5 months ago (2022-02-03 15:27:45 UTC) #12
rietveld-bot_tryton.org
4 months, 3 weeks ago (2022-02-07 22:36:47 UTC) #13
New changeset 903aa15f4295 by Nicolas Évrard in branch '6.0':
Propagate changed status to parent on instance button activation
https://hg.tryton.org/sao/rev/903aa15f4295


New changeset 28e326b81486 by Nicolas Évrard in branch '5.0':
Propagate changed status to parent on instance button activation
https://hg.tryton.org/sao/rev/28e326b81486
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted