Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(857)

Issue 38991002: sale: Add a wizard to modify sale header after the filling lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by nicoe
Modified:
12 hours, 5 minutes ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Add button and depends #

Total comments: 14

Patch Set 3 : Use sale.sale as ModelView and add tests #

Total comments: 8

Patch Set 4 : Fix comment, simplify wizard and fix view #

Total comments: 6

Patch Set 5 : Show button only if lines is filled #

Patch Set 6 : Move button #

Total comments: 4

Patch Set 7 : Improve scenario #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -3 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sale.py View 1 2 3 4 5 6 6 chunks +95 lines, -3 lines 0 comments Download
M sale.xml View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A tests/scenario_sale_modify_header.rst View 1 2 3 4 5 6 1 chunk +87 lines, -0 lines 0 comments Download
M tests/test_sale.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A view/modify_header_form.xml View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M view/sale_form.xml View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 32
nicoe
2 weeks, 4 days ago (2017-11-27 17:48:44 UTC) #1
reviewbot
https://codereview.tryton.org/38991002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from sale import *' used; unable to detect undefined names https://codereview.tryton.org/38991002/diff/1/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 4 days ago (2017-11-27 18:01:08 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py File sale.py (right): https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py#newcode1813 sale.py:1813: PARTY_RELATED_FIELDS = { probably it will be better to ...
2 weeks, 3 days ago (2017-11-28 08:49:35 UTC) #3
pokoli
https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py File sale.py (right): https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py#newcode1813 sale.py:1813: PARTY_RELATED_FIELDS = { On 2017/11/28 08:49:35, pokoli wrote: > ...
2 weeks, 3 days ago (2017-11-28 08:51:06 UTC) #4
nicoe
https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py File sale.py (right): https://tryton-rietveld-hrd.appspot.com/38991002/diff/1/sale.py#newcode1876 sale.py:1876: sale.save() On 2017/11/28 08:49:35, pokoli wrote: > probably better ...
2 weeks, 3 days ago (2017-11-28 09:53:31 UTC) #5
nicoe
Add button and depends
2 weeks, 3 days ago (2017-11-28 09:57:39 UTC) #6
reviewbot
https://codereview.tryton.org/38991002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from sale import *' used; unable to detect undefined names https://codereview.tryton.org/38991002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 3 days ago (2017-11-28 10:05:11 UTC) #7
ced
https://codereview.tryton.org/38991002/diff/20001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/20001/sale.py#newcode1807 sale.py:1807: __name__ = 'sale.change_party' I think the name should be ...
2 weeks, 3 days ago (2017-11-28 12:00:05 UTC) #8
nicoe
Use sale.sale as ModelView and add tests
4 days, 4 hours ago (2017-12-11 16:55:20 UTC) #9
nicoe
https://codereview.tryton.org/38991002/diff/20001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/20001/sale.py#newcode1807 sale.py:1807: __name__ = 'sale.change_party' On 2017/11/28 12:00:04, ced wrote: > ...
4 days, 4 hours ago (2017-12-11 16:56:49 UTC) #10
ced
https://codereview.tryton.org/38991002/diff/20001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/20001/sale.py#newcode1807 sale.py:1807: __name__ = 'sale.change_party' On 2017/12/11 16:56:49, nicoe wrote: > ...
4 days, 4 hours ago (2017-12-11 17:05:23 UTC) #11
reviewbot
https://codereview.tryton.org/38991002/diff/30001/__init__.py#newcode5 __init__.py:5: F403 'from sale import *' used; unable to detect undefined names https://codereview.tryton.org/38991002/diff/30001/__init__.py#newcode6 __init__.py:6: ...
4 days, 4 hours ago (2017-12-11 17:18:16 UTC) #12
nicoe
https://codereview.tryton.org/38991002/diff/20001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/20001/sale.py#newcode1807 sale.py:1807: __name__ = 'sale.change_party' On 2017/12/11 17:05:23, ced wrote: > ...
4 days, 4 hours ago (2017-12-11 17:20:21 UTC) #13
ced
https://codereview.tryton.org/38991002/diff/20001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/20001/sale.py#newcode1807 sale.py:1807: __name__ = 'sale.change_party' On 2017/12/11 17:20:21, nicoe wrote: > ...
4 days, 4 hours ago (2017-12-11 17:24:18 UTC) #14
pokoli
Test scenario is not correctly uploaded. Could you please re-upload? https://codereview.tryton.org/38991002/diff/30001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/30001/sale.py#newcode1834 ...
3 days, 12 hours ago (2017-12-12 09:21:08 UTC) #15
pokoli
https://codereview.tryton.org/38991002/diff/30001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/30001/sale.py#newcode1859 sale.py:1859: with Transaction().set_context(modify_wizard=True): why is this required? I don't see ...
3 days, 12 hours ago (2017-12-12 09:22:30 UTC) #16
ced
https://codereview.tryton.org/38991002/diff/30001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/30001/sale.py#newcode1840 sale.py:1840: Button("Apply Modifications", 'apply_modifications', 'tryton-ok', As the title is "Modify", ...
1 day, 6 hours ago (2017-12-14 15:21:05 UTC) #17
ced
https://codereview.tryton.org/38991002/diff/30001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/30001/sale.py#newcode1859 sale.py:1859: with Transaction().set_context(modify_wizard=True): On 2017/12/12 09:22:30, pokoli wrote: > why ...
1 day, 6 hours ago (2017-12-14 15:22:04 UTC) #18
ced
https://codereview.tryton.org/38991002/diff/30001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/30001/sale.py#newcode1859 sale.py:1859: with Transaction().set_context(modify_wizard=True): On 2017/12/14 15:22:04, ced wrote: > On ...
1 day, 5 hours ago (2017-12-14 15:30:21 UTC) #19
ced
Fix comment, simplify wizard and fix view
1 day, 4 hours ago (2017-12-14 17:16:01 UTC) #20
ced
Show button only if lines is filled
1 day, 3 hours ago (2017-12-14 17:41:25 UTC) #21
reviewbot
https://codereview.tryton.org/38991002/diff/70001/__init__.py#newcode5 __init__.py:5: F403 'from sale import *' used; unable to detect undefined names https://codereview.tryton.org/38991002/diff/70001/__init__.py#newcode6 __init__.py:6: ...
1 day, 3 hours ago (2017-12-14 17:48:08 UTC) #22
nicoe
https://codereview.tryton.org/38991002/diff/50001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/50001/sale.py#newcode1833 sale.py:1833: class ModifyHeaderStateView(StateView): Putting the code on execute was the ...
1 day, 3 hours ago (2017-12-14 17:48:14 UTC) #23
ced
https://codereview.tryton.org/38991002/diff/50001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/50001/sale.py#newcode1833 sale.py:1833: class ModifyHeaderStateView(StateView): On 2017/12/14 17:48:13, nicoe wrote: > Putting ...
1 day, 3 hours ago (2017-12-14 17:55:45 UTC) #24
ced
Move button
1 day, 3 hours ago (2017-12-14 17:55:50 UTC) #25
reviewbot
https://codereview.tryton.org/38991002/diff/90001/__init__.py#newcode5 __init__.py:5: F403 'from sale import *' used; unable to detect undefined names https://codereview.tryton.org/38991002/diff/90001/__init__.py#newcode6 __init__.py:6: ...
1 day, 3 hours ago (2017-12-14 18:15:19 UTC) #26
pokoli
https://codereview.tryton.org/38991002/diff/90001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/90001/sale.py#newcode1848 sale.py:1848: with Transaction().set_context(modify_header=True): I will prefer to add the context ...
13 hours, 3 minutes ago (2017-12-15 08:23:33 UTC) #27
ced
https://codereview.tryton.org/38991002/diff/90001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/90001/sale.py#newcode1848 sale.py:1848: with Transaction().set_context(modify_header=True): On 2017/12/15 08:23:33, pokoli wrote: > I ...
12 hours, 44 minutes ago (2017-12-15 08:42:52 UTC) #28
ced
Improve scenario
12 hours, 33 minutes ago (2017-12-15 08:53:36 UTC) #29
pokoli
https://codereview.tryton.org/38991002/diff/90001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/90001/sale.py#newcode1848 sale.py:1848: with Transaction().set_context(modify_header=True): On 2017/12/15 08:42:52, ced wrote: > On ...
12 hours, 29 minutes ago (2017-12-15 08:57:24 UTC) #30
ced
https://codereview.tryton.org/38991002/diff/90001/sale.py File sale.py (right): https://codereview.tryton.org/38991002/diff/90001/sale.py#newcode1848 sale.py:1848: with Transaction().set_context(modify_header=True): On 2017/12/15 08:57:24, pokoli wrote: > On ...
12 hours, 11 minutes ago (2017-12-15 09:16:09 UTC) #31
reviewbot
12 hours, 5 minutes ago (2017-12-15 09:21:57 UTC) #32
https://codereview.tryton.org/38991002/diff/110001/__init__.py#newcode5
__init__.py:5:
F403 'from sale import *' used; unable to detect undefined names

https://codereview.tryton.org/38991002/diff/110001/__init__.py#newcode6
__init__.py:6:
F403 'from product import *' used; unable to detect undefined names

https://codereview.tryton.org/38991002/diff/110001/__init__.py#newcode7
__init__.py:7:
F403 'from stock import *' used; unable to detect undefined names

https://codereview.tryton.org/38991002/diff/110001/__init__.py#newcode8
__init__.py:8:
F403 'from configuration import *' used; unable to detect undefined names

https://codereview.tryton.org/38991002/diff/110001/__init__.py#newcode9
__init__.py:9:
F403 'from invoice import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/38991002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922