Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 39031002: account: Hide party required for non deferral accounts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 1 week ago by pokoli
Modified:
8 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add domain #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M account.py View 1 2 chunks +16 lines, -4 lines 4 comments Download

Messages

Total messages: 11
pokoli
10 months, 1 week ago (2017-12-11 16:58:22 UTC) #1
reviewbot
https://codereview.tryton.org/39031002/diff/1/account.py#newcode728 account.py:728: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
10 months, 1 week ago (2017-12-11 17:18:14 UTC) #2
ced
Hiding is not enough. I think a domain could add the necessary constraint.
10 months, 1 week ago (2017-12-13 17:15:35 UTC) #3
pokoli
Add domain
10 months, 1 week ago (2017-12-14 08:40:32 UTC) #4
reviewbot
https://codereview.tryton.org/39031002/diff/20001/account.py#newcode740 account.py:740: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
10 months, 1 week ago (2017-12-14 08:46:51 UTC) #5
ced
https://codereview.tryton.org/39031002/diff/20001/account.py File account.py (right): https://codereview.tryton.org/39031002/diff/20001/account.py#newcode346 account.py:346: 'invisible': (Eval('kind') == 'view') | ~Eval('deferral', False), For me, ...
10 months ago (2017-12-17 23:30:41 UTC) #6
pokoli
https://codereview.tryton.org/39031002/diff/20001/account.py File account.py (right): https://codereview.tryton.org/39031002/diff/20001/account.py#newcode346 account.py:346: 'invisible': (Eval('kind') == 'view') | ~Eval('deferral', False), On 2017/12/17 ...
10 months ago (2017-12-18 08:43:11 UTC) #7
ced
https://codereview.tryton.org/39031002/diff/20001/account.py File account.py (right): https://codereview.tryton.org/39031002/diff/20001/account.py#newcode346 account.py:346: 'invisible': (Eval('kind') == 'view') | ~Eval('deferral', False), On 2017/12/18 ...
10 months ago (2017-12-18 09:19:58 UTC) #8
ced
https://codereview.tryton.org/39031002/diff/20001/account.py File account.py (right): https://codereview.tryton.org/39031002/diff/20001/account.py#newcode346 account.py:346: 'invisible': (Eval('kind') == 'view') | ~Eval('deferral', False), On 2017/12/18 ...
8 months, 1 week ago (2018-02-11 00:18:59 UTC) #9
ced
LGTM, let create an issue to improve the client behavior to unhide invalid fields.
8 months ago (2018-02-13 17:59:27 UTC) #10
rietveld-bot_tryton.org
8 months ago (2018-02-15 10:15:12 UTC) #11
New changeset 2fd123681718 by Sergi Almacellas Abellana in branch 'default':
Hide party required for non deferral accounts
http://hg.tryton.org/modules/account/rev/2fd123681718
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766