Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 391151002: tryton-env: Add purchase_blanket_agreement and sale_blanket_agreement modules

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by mrichez
Modified:
2 weeks, 1 day ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

tryton-env: Add purchase_blanket_agreement and sale_blanket_agreement modules issue10962

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Merge both modules in the same issue, remove domain on unit #

Total comments: 38

Patch Set 4 : Apply Pokoli's remarks #

Total comments: 50

Patch Set 5 : Apply Ced's remarks #

Patch Set 6 : Add product_supplier and product_customer #

Patch Set 7 : Update to tip and test secondary unit #

Patch Set 8 : Fix import order #

Patch Set 9 : Update to tip and fix wrong depends #

Patch Set 10 : Update to tip #

Patch Set 11 : Update to tip #

Total comments: 290

Patch Set 12 : Apply remarks #

Patch Set 13 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5617 lines, -3 lines) Patch
M .hgsub View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/.drone.yml View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/COPYRIGHT View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/LICENSE View 1 2 3 4 1 chunk +674 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/MANIFEST.in View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/README.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +24 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/doc/conf.py View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/exceptions.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +12 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/message.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/product.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +34 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/purchase.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +857 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/purchase.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +236 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/setup.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +160 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tests/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tests/scenario_purchase_blanket_agreement.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +126 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +12 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tests/test_scenario.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tox.ini View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +16 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/tryton.cfg View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/configuration_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/create_purchase_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/create_purchase_line_tree.xml View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/product_list_agreement_line.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_blanket_agreement_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +52 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_blanket_agreement_line_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +25 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_blanket_agreement_line_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +14 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_blanket_agreement_line_tree_sequence.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +14 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_blanket_agreement_list.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download
A modules/purchase_blanket_agreement/view/purchase_line_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M modules/purchase_secondary_unit/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M modules/purchase_secondary_unit/purchase.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +102 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tests/scenario_purchase_blanket_agreement.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +141 lines, -0 lines 0 comments Download
M modules/purchase_secondary_unit/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -1 line 0 comments Download
M modules/purchase_secondary_unit/tryton.cfg View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_blanket_agreement/.drone.yml View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/.flake8 View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/COPYRIGHT View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/LICENSE View 1 2 3 4 1 chunk +674 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/MANIFEST.in View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/README.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_blanket_agreement/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +24 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/doc/conf.py View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/exceptions.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/message.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/product.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +34 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/sale.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +794 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/sale.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +236 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/setup.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +159 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tests/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tests/scenario_sale_blanket_agreement.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +127 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tests/test_scenario.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tox.ini View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/tryton.cfg View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +14 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/configuration_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/create_sale_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/create_sale_line_tree.xml View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/product_list_agreement_line.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_blanket_agreement_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +52 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_blanket_agreement_line_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +24 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_blanket_agreement_line_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_blanket_agreement_line_tree_sequence.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_blanket_agreement_list.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download
A modules/sale_blanket_agreement/view/sale_line_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_product_customer/__init__.py View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M modules/sale_product_customer/sale.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +64 lines, -0 lines 0 comments Download
M modules/sale_product_customer/sale.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +18 lines, -0 lines 0 comments Download
M modules/sale_product_customer/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M modules/sale_product_customer/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_blanket_agreement_line_form.xml View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_blanket_agreement_line_tree.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_product_customer/view/sale_blanket_agreement_line_tree_sequence.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +8 lines, -0 lines 0 comments Download
M modules/sale_secondary_unit/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_secondary_unit/sale.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +102 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tests/scenario_sale_blanket_agreement.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +141 lines, -0 lines 0 comments Download
M modules/sale_secondary_unit/tests/test_module.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M modules/sale_secondary_unit/tryton.cfg View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M readthedocs/purchase.rst View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M readthedocs/sale.rst View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 33
mrichez
7 months, 2 weeks ago (2021-11-17 13:53:47 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 2 weeks ago (2021-11-17 13:58:18 UTC) #2
mrichez
7 months, 2 weeks ago (2021-11-17 15:10:27 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 2 weeks ago (2021-11-17 15:22:16 UTC) #4
mrichez
7 months, 2 weeks ago (2021-11-19 14:43:59 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 2 weeks ago (2021-11-19 14:52:06 UTC) #6
pokoli
https://codereview.tryton.org/391151002/diff/370261002/modules/purchase_blanket_order/blanket_order.py File modules/purchase_blanket_order/blanket_order.py (right): https://codereview.tryton.org/391151002/diff/370261002/modules/purchase_blanket_order/blanket_order.py#newcode19 modules/purchase_blanket_order/blanket_order.py:19: 'Purchase blanket order' blanket -> Blanket https://codereview.tryton.org/391151002/diff/370261002/modules/purchase_blanket_order/blanket_order.py#newcode61 modules/purchase_blanket_order/blanket_order.py:61: 'readonly': ...
7 months, 2 weeks ago (2021-11-23 09:09:45 UTC) #7
mrichez
https://codereview.tryton.org/391151002/diff/370261002/modules/purchase_blanket_order/blanket_order.py File modules/purchase_blanket_order/blanket_order.py (right): https://codereview.tryton.org/391151002/diff/370261002/modules/purchase_blanket_order/blanket_order.py#newcode19 modules/purchase_blanket_order/blanket_order.py:19: 'Purchase blanket order' On 2021/11/23 09:09:44, pokoli wrote: > ...
7 months, 2 weeks ago (2021-11-23 17:13:15 UTC) #8
mrichez
7 months, 2 weeks ago (2021-11-23 17:14:56 UTC) #9
mrichez
7 months, 2 weeks ago (2021-11-23 17:17:54 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 2 weeks ago (2021-11-23 17:27:31 UTC) #11
ced
https://codereview.tryton.org/391151002/diff/383651075/modules/purchase_blanket_order/blanket_order.py File modules/purchase_blanket_order/blanket_order.py (right): https://codereview.tryton.org/391151002/diff/383651075/modules/purchase_blanket_order/blanket_order.py#newcode23 modules/purchase_blanket_order/blanket_order.py:23: __name__ = 'purchase.blanket_order' I think I would name it: ...
7 months, 1 week ago (2021-11-24 12:23:17 UTC) #12
mrichez
https://codereview.tryton.org/391151002/diff/383651075/modules/purchase_blanket_order/blanket_order.py File modules/purchase_blanket_order/blanket_order.py (right): https://codereview.tryton.org/391151002/diff/383651075/modules/purchase_blanket_order/blanket_order.py#newcode23 modules/purchase_blanket_order/blanket_order.py:23: __name__ = 'purchase.blanket_order' On 2021/11/24 12:23:16, ced wrote: > ...
7 months, 1 week ago (2021-11-30 09:48:13 UTC) #13
mrichez
7 months, 1 week ago (2021-11-30 09:50:12 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 1 week ago (2021-11-30 10:01:40 UTC) #15
mrichez
7 months, 1 week ago (2021-11-30 15:52:24 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/391151002
7 months, 1 week ago (2021-11-30 16:01:33 UTC) #17
mrichez
6 months, 3 weeks ago (2021-12-15 14:38:10 UTC) #18
reviewbot
ERROR: /tmp/reviewbot-2zzsen8g/modules/purchase_blanket_agreement/__init__.py Imports are incorrectly sorted and/or formatted. ERROR: /tmp/reviewbot-2zzsen8g/modules/purchase_blanket_agreement/configuration.py Imports are incorrectly sorted and/or ...
6 months, 3 weeks ago (2021-12-15 15:07:24 UTC) #19
mrichez
6 months, 3 weeks ago (2021-12-16 07:59:59 UTC) #20
reviewbot
checks OK URL: https://codereview.tryton.org/391151002
6 months, 3 weeks ago (2021-12-16 08:32:03 UTC) #21
mrichez
5 months, 2 weeks ago (2022-01-18 15:19:56 UTC) #22
reviewbot
checks OK URL: https://codereview.tryton.org/391151002
5 months, 2 weeks ago (2022-01-18 15:54:41 UTC) #23
mrichez
4 months, 3 weeks ago (2022-02-14 14:37:07 UTC) #24
reviewbot
checks OK URL: https://codereview.tryton.org/391151002
4 months, 3 weeks ago (2022-02-14 14:53:06 UTC) #25
mrichez
3 months, 2 weeks ago (2022-03-18 15:52:09 UTC) #26
reviewbot
checks OK URL: https://codereview.tryton.org/391151002
3 months, 2 weeks ago (2022-03-18 16:09:15 UTC) #27
ced
I reviewed only the purchase part but normally my comments should apply also on the ...
3 months, 1 week ago (2022-03-30 12:17:57 UTC) #28
mrichez
https://codereview.tryton.org/391151002/diff/380561002/.hgsubstate File .hgsubstate (right): https://codereview.tryton.org/391151002/diff/380561002/.hgsubstate#newcode1 .hgsubstate:1: 1ddf373597a28566f47b8817cc3edce96fd0b446 modules/account On 2022/03/30 12:17:49, ced wrote: > This ...
2 months ago (2022-05-04 09:17:12 UTC) #29
mrichez
2 months ago (2022-05-04 09:24:57 UTC) #30
reviewbot
https://codereview.tryton.org/391151002/diff/435081003/modules/purchase_blanket_agreement/purchase.py#newcode395 modules/purchase_blanket_agreement/purchase.py:395: continuation line missing indentation or outdented https://codereview.tryton.org/391151002/diff/435081003/modules/purchase_blanket_agreement/purchase.py#newcode406 modules/purchase_blanket_agreement/purchase.py:406: continuation line missing indentation or ...
2 months ago (2022-05-04 10:00:55 UTC) #31
mrichez
2 weeks, 1 day ago (2022-06-20 13:30:55 UTC) #32
reviewbot
2 weeks, 1 day ago (2022-06-20 13:41:44 UTC) #33
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted