Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(378)

Issue 39171002: trytond: Simplify API for Session (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ced
Modified:
2 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

- Allow to extend session management with a domain - Let security manage the logging - Let check differentiate expired session and session that does not exist issue7134

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update to tip and delete in a bunch #

Total comments: 3

Patch Set 3 : Use cls instead of Session #

Patch Set 4 : Update to tip #

Patch Set 5 : Fix context on user_id Request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -35 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/session.py View 1 2 1 chunk +40 lines, -7 lines 0 comments Download
M trytond/protocols/dispatcher.py View 1 2 chunks +1 line, -7 lines 0 comments Download
M trytond/protocols/wrappers.py View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M trytond/security.py View 1 5 chunks +38 lines, -19 lines 0 comments Download

Messages

Total messages: 14
ced
3 months ago (2018-02-13 15:06:52 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39171002
3 months ago (2018-02-13 15:16:44 UTC) #2
pokoli
https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py File trytond/ir/session.py (right): https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py#newcode83 trytond/ir/session.py:83: domain or [], Won't be easier to include the ...
3 months ago (2018-02-19 09:35:00 UTC) #3
ced
https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py File trytond/ir/session.py (right): https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py#newcode83 trytond/ir/session.py:83: domain or [], On 2018/02/19 09:35:00, pokoli wrote: > ...
3 months ago (2018-02-19 09:50:30 UTC) #4
pokoli
https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py File trytond/ir/session.py (right): https://codereview.tryton.org/39171002/diff/1/trytond/ir/session.py#newcode74 trytond/ir/session.py:74: Check user key and delete old one. delete old ...
3 months ago (2018-02-19 10:27:42 UTC) #5
ced
Update to tip and delete in a bunch
3 months ago (2018-02-19 10:52:18 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/39171002
3 months ago (2018-02-19 11:15:26 UTC) #7
pokoli
https://codereview.tryton.org/39171002/diff/20001/trytond/ir/session.py File trytond/ir/session.py (right): https://codereview.tryton.org/39171002/diff/20001/trytond/ir/session.py#newcode53 trytond/ir/session.py:53: session, = Session.create([values]) I think we should use cls ...
2 months, 4 weeks ago (2018-02-20 15:01:33 UTC) #8
ced
Use cls instead of Session
2 months, 4 weeks ago (2018-02-20 15:13:07 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/39171002
2 months, 4 weeks ago (2018-02-20 15:13:26 UTC) #10
pokoli
LGTM
2 months, 4 weeks ago (2018-02-20 16:50:58 UTC) #11
ced
Update to tip
2 months, 2 weeks ago (2018-03-06 23:25:05 UTC) #12
ced
Fix context on user_id Request
2 months, 2 weeks ago (2018-03-06 23:29:55 UTC) #13
rietveld-bot_tryton.org
2 months, 2 weeks ago (2018-03-06 23:34:18 UTC) #14
New changeset efd461cecc78 by Cédric Krier in branch 'default':
Simplify API for Session
http://hg.tryton.org/trytond/rev/efd461cecc78
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922