Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(866)

Issue 39181002: trytond: Ensure to put back the connection with a try/finally (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by ced
Modified:
11 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

This prevents to leak connection in the ThreadedConnectionPool of psycopg2. issue7137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M trytond/backend/postgresql/database.py View 2 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 5
ced
1 year ago (2018-02-14 12:35:47 UTC) #1
reviewbot
https://codereview.tryton.org/39181002/diff/1/trytond/backend/postgresql/database.py#newcode238 trytond/backend/postgresql/database.py:238: E127 continuation line over-indented for visual indent https://codereview.tryton.org/39181002/diff/1/trytond/backend/postgresql/database.py#newcode399 trytond/backend/postgresql/database.py:399: E131 continuation line unaligned ...
1 year ago (2018-02-14 12:53:50 UTC) #2
pokoli
LGTM
1 year ago (2018-02-14 13:32:44 UTC) #3
rietveld-bot_tryton.org
New changeset 607cf6e87aa4 by Cédric Krier in branch 'default': Ensure to put back the connection ...
12 months ago (2018-02-19 18:11:36 UTC) #4
rietveld-bot_tryton.org
11 months, 3 weeks ago (2018-02-25 00:10:21 UTC) #5
New changeset 1b7a79203daf by Cédric Krier in branch '4.6':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/1b7a79203daf


New changeset e29a8825249e by Cédric Krier in branch '4.4':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/e29a8825249e


New changeset 871064b6c772 by Cédric Krier in branch '4.2':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/871064b6c772


New changeset 9a8e0f3346f7 by Cédric Krier in branch '4.0':
Ensure to put back the connection with a try/finally
http://hg.tryton.org/trytond/rev/9a8e0f3346f7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766