Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 39221002: account: Test if parent_line account is set when computing tax line company (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by pokoli
Modified:
3 months, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tax.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
pokoli
4 months ago (2018-03-13 09:35:00 UTC) #1
reviewbot
https://codereview.tryton.org/39221002/diff/1/tax.py#newcode213 tax.py:213: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
4 months ago (2018-03-13 09:51:53 UTC) #2
ced
LGTM
4 months ago (2018-03-13 23:06:54 UTC) #3
rietveld-bot_tryton.org
New changeset 7a30bd3dc2bf by Sergi Almacellas Abellana in branch 'default': Test if parent_line account is ...
4 months ago (2018-03-14 11:49:46 UTC) #4
rietveld-bot_tryton.org
3 months, 3 weeks ago (2018-03-25 00:44:27 UTC) #5
New changeset 72dc354ecdad by Sergi Almacellas Abellana in branch '4.6':
Test if parent_line account is set when computing tax line company
http://hg.tryton.org/modules/account/rev/72dc354ecdad


New changeset 4678375da4fa by Sergi Almacellas Abellana in branch '4.4':
Test if parent_line account is set when computing tax line company
http://hg.tryton.org/modules/account/rev/4678375da4fa


New changeset 33daf0f68336 by Sergi Almacellas Abellana in branch '4.2':
Test if parent_line account is set when computing tax line company
http://hg.tryton.org/modules/account/rev/33daf0f68336


New changeset 8cf95441fc12 by Sergi Almacellas Abellana in branch '4.0':
Test if parent_line account is set when computing tax line company
http://hg.tryton.org/modules/account/rev/8cf95441fc12


New changeset ef3ed3ef50a9 by Sergi Almacellas Abellana in branch '3.8':
Test if parent_line account is set when computing tax line company
http://hg.tryton.org/modules/account/rev/ef3ed3ef50a9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69