Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 39221003: sao: Add support of expand attribute on group tag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by nicoe
Modified:
6 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Synchronize with tryton implementation #

Total comments: 17

Patch Set 3 : Use panel #

Patch Set 4 : remove useless css #

Total comments: 14

Patch Set 5 : fix remarks #

Total comments: 8

Patch Set 6 : remove useless attributes #

Total comments: 2

Patch Set 7 : fix if expression #

Total comments: 5

Patch Set 8 : use appendTo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/view/form.js View 1 2 3 4 5 6 7 5 chunks +75 lines, -5 lines 1 comment Download

Messages

Total messages: 32
nicoe
6 months, 1 week ago (2018-03-13 13:05:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months, 1 week ago (2018-03-13 13:13:09 UTC) #2
nicoe
Synchronize with tryton implementation
6 months, 1 week ago (2018-03-16 13:52:15 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months, 1 week ago (2018-03-16 14:16:00 UTC) #4
ced
https://codereview.tryton.org/39221003/diff/20001/src/sao.less File src/sao.less (right): https://codereview.tryton.org/39221003/diff/20001/src/sao.less#newcode412 src/sao.less:412: span.caret-left { Why duplicate .caret style from bootstrap? https://codereview.tryton.org/39221003/diff/20001/src/view/form.js ...
6 months ago (2018-03-19 13:15:40 UTC) #5
nicoe
Use panel
6 months ago (2018-03-21 11:41:21 UTC) #6
nicoe
https://codereview.tryton.org/39221003/diff/20001/src/sao.less File src/sao.less (right): https://codereview.tryton.org/39221003/diff/20001/src/sao.less#newcode412 src/sao.less:412: span.caret-left { On 2018/03/19 13:15:40, ced wrote: > Why ...
6 months ago (2018-03-21 11:41:31 UTC) #7
nicoe
remove useless css
6 months ago (2018-03-21 11:42:22 UTC) #8
ced
https://codereview.tryton.org/39221003/diff/20001/src/sao.less File src/sao.less (right): https://codereview.tryton.org/39221003/diff/20001/src/sao.less#newcode412 src/sao.less:412: span.caret-left { On 2018/03/21 11:41:31, nicoe wrote: > On ...
6 months ago (2018-03-21 11:52:38 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months ago (2018-03-21 11:53:44 UTC) #10
ced
https://codereview.tryton.org/39221003/diff/60001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/60001/src/view/form.js#newcode875 src/view/form.js:875: var title = jQuery('<h4/>', { I do not think ...
6 months ago (2018-03-21 12:01:37 UTC) #11
nicoe
fix remarks
6 months ago (2018-03-21 16:22:15 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months ago (2018-03-21 16:50:46 UTC) #13
nicoe
https://codereview.tryton.org/39221003/diff/60001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/60001/src/view/form.js#newcode875 src/view/form.js:875: var title = jQuery('<h4/>', { On 2018/03/21 12:01:37, ced ...
6 months ago (2018-03-21 16:56:22 UTC) #14
ced
https://codereview.tryton.org/39221003/diff/60001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/60001/src/view/form.js#newcode875 src/view/form.js:875: var title = jQuery('<h4/>', { On 2018/03/21 16:56:21, nicoe ...
6 months ago (2018-03-21 17:13:02 UTC) #15
nicoe
https://codereview.tryton.org/39221003/diff/60001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/60001/src/view/form.js#newcode875 src/view/form.js:875: var title = jQuery('<h4/>', { On 2018/03/21 17:13:02, ced ...
6 months ago (2018-03-21 17:20:43 UTC) #16
ced
https://codereview.tryton.org/39221003/diff/80001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/80001/src/view/form.js#newcode869 src/view/form.js:869: this.container = jQuery('<div/>', { I find it confusing to ...
6 months ago (2018-03-21 17:21:21 UTC) #17
nicoe
remove useless attributes
6 months ago (2018-03-21 18:24:44 UTC) #18
nicoe
https://codereview.tryton.org/39221003/diff/80001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/80001/src/view/form.js#newcode869 src/view/form.js:869: this.container = jQuery('<div/>', { On 2018/03/21 17:21:21, ced wrote: ...
6 months ago (2018-03-21 18:25:03 UTC) #19
ced
https://codereview.tryton.org/39221003/diff/40002/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/40002/src/view/form.js#newcode891 src/view/form.js:891: if (attributes.string !== undefined) { Why not: if(attributes.string)
6 months ago (2018-03-21 18:39:57 UTC) #20
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months ago (2018-03-21 18:45:25 UTC) #21
nicoe
https://codereview.tryton.org/39221003/diff/40002/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/40002/src/view/form.js#newcode891 src/view/form.js:891: if (attributes.string !== undefined) { On 2018/03/21 18:39:57, ced ...
6 months ago (2018-03-22 10:16:38 UTC) #22
nicoe
fix if expression
6 months ago (2018-03-22 10:18:12 UTC) #23
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months ago (2018-03-22 10:22:35 UTC) #24
ced
https://codereview.tryton.org/39221003/diff/110001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/110001/src/view/form.js#newcode892 src/view/form.js:892: link.append(attributes.string); It is safer to use .text https://codereview.tryton.org/39221003/diff/110001/src/view/form.js#newcode896 src/view/form.js:896: ...
6 months ago (2018-03-22 10:33:53 UTC) #25
nicoe
https://codereview.tryton.org/39221003/diff/110001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/110001/src/view/form.js#newcode892 src/view/form.js:892: link.append(attributes.string); On 2018/03/22 10:33:52, ced wrote: > It is ...
6 months ago (2018-03-22 13:09:48 UTC) #26
ced
https://codereview.tryton.org/39221003/diff/110001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/110001/src/view/form.js#newcode892 src/view/form.js:892: link.append(attributes.string); On 2018/03/22 13:09:48, nicoe wrote: > On 2018/03/22 ...
6 months ago (2018-03-22 13:42:41 UTC) #27
nicoe
use appendTo
6 months ago (2018-03-23 14:54:54 UTC) #28
nicoe
https://codereview.tryton.org/39221003/diff/110001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/110001/src/view/form.js#newcode896 src/view/form.js:896: this.el.append(this.collapsible); On 2018/03/22 10:33:52, ced wrote: > Why not ...
6 months ago (2018-03-23 14:54:57 UTC) #29
reviewbot
flake8 OK URL: https://codereview.tryton.org/39221003
6 months ago (2018-03-23 14:55:02 UTC) #30
ced
https://codereview.tryton.org/39221003/diff/130001/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39221003/diff/130001/src/view/form.js#newcode883 src/view/form.js:883: link.append(jQuery('<span/>', { It will render better if it was ...
6 months ago (2018-03-23 15:15:07 UTC) #31
rietveld-bot_tryton.org
6 months ago (2018-03-23 15:27:57 UTC) #32
New changeset a49b5c65ac01 by Nicolas ?vrard in branch 'default':
Add support of expand attribute on group tag
http://hg.tryton.org/sao/rev/a49b5c65ac01
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766