Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 39231002: commission: Add help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by pokoli
Modified:
1 month, 1 week ago
Reviewers:
dave, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7233

Patch Set 1 #

Total comments: 16

Patch Set 2 : Fix ced's comments #

Total comments: 30

Patch Set 3 : Update with suggested improvements #

Total comments: 3

Patch Set 4 : Update based on comments #

Total comments: 13

Patch Set 5 : Improve help text from comments #

Patch Set 6 : Update to tip #

Patch Set 7 : Avoid pay and improve help text #

Patch Set 8 : Make the use of the word 'the' consistent #

Total comments: 12

Patch Set 9 : Use 'a' instead of 'the' where appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -21 lines) Patch
M commission.py View 1 2 3 4 5 6 7 8 6 chunks +35 lines, -16 lines 0 comments Download
M invoice.py View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M product.py View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M sale.py View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 28
pokoli
1 year ago (2018-03-19 10:02:59 UTC) #1
reviewbot
https://codereview.tryton.org/39231002/diff/1/commission.py#newcode335 commission.py:335: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/1/commission.py#newcode346 commission.py:346: E731 ...
1 year ago (2018-03-19 10:20:13 UTC) #2
ced
https://codereview.tryton.org/39231002/diff/1/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/1/commission.py#newcode32 commission.py:32: help="The party identified by this agent.") It sounds weird. ...
10 months, 2 weeks ago (2018-05-09 08:35:03 UTC) #3
pokoli
Fix ced's comments
3 months, 4 weeks ago (2018-11-22 15:03:31 UTC) #4
reviewbot
https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode340 commission.py:340: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode351 commission.py:351: E731 ...
3 months, 4 weeks ago (2018-11-22 15:15:20 UTC) #5
ced
https://codereview.tryton.org/39231002/diff/20001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode38 commission.py:38: help="Make the agent belong to the company.") I think ...
3 months, 3 weeks ago (2018-11-26 21:52:40 UTC) #6
dave
These are a few suggestions to consider. Am I right in thinking that the agent ...
3 months ago (2018-12-14 22:15:13 UTC) #7
dave
Update with suggested improvements
3 months ago (2018-12-18 16:01:26 UTC) #8
reviewbot
https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode347 commission.py:347: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode358 commission.py:358: E731 ...
3 months ago (2018-12-18 16:06:11 UTC) #9
pokoli
https://codereview.tryton.org/39231002/diff/40001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode32 commission.py:32: help="The party that is an agent for, or principal ...
3 months ago (2018-12-20 13:27:39 UTC) #10
dave
Update based on comments
3 months ago (2018-12-20 15:24:54 UTC) #11
dave
https://codereview.tryton.org/39231002/diff/40001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode32 commission.py:32: help="The party that is an agent for, or principal ...
3 months ago (2018-12-20 15:25:32 UTC) #12
reviewbot
https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode347 commission.py:347: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode358 commission.py:358: E731 ...
3 months ago (2018-12-20 15:44:20 UTC) #13
ced
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode32 commission.py:32: help="The party that the commission is calculated for.") should ...
2 months, 4 weeks ago (2018-12-21 17:52:18 UTC) #14
dave
Improve help text from comments
2 months, 1 week ago (2019-01-07 20:35:47 UTC) #15
dave
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode32 commission.py:32: help="The party that the commission is calculated for.") On ...
2 months, 1 week ago (2019-01-07 20:35:59 UTC) #16
reviewbot
https://codereview.tryton.org/39231002/diff/80001/commission.py#newcode340 commission.py:340: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/80001/commission.py#newcode351 commission.py:351: E731 ...
2 months, 1 week ago (2019-01-07 20:37:49 UTC) #17
ced
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode128 commission.py:128: "commission.") On 2019/01/07 20:35:59, dave wrote: > On 2018/12/21 ...
1 month, 1 week ago (2019-02-06 18:41:42 UTC) #18
dave
Avoid pay and improve help text
1 month, 1 week ago (2019-02-06 20:01:43 UTC) #19
dave
Update to tip
1 month, 1 week ago (2019-02-06 20:07:26 UTC) #20
dave
Avoid pay and improve help text
1 month, 1 week ago (2019-02-06 20:08:44 UTC) #21
dave
Make the use of the word 'the' consistent
1 month, 1 week ago (2019-02-06 20:13:05 UTC) #22
reviewbot
https://codereview.tryton.org/39231002/diff/160001/commission.py#newcode338 commission.py:338: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/160001/commission.py#newcode349 commission.py:349: E731 ...
1 month, 1 week ago (2019-02-06 20:15:10 UTC) #23
dave
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode128 commission.py:128: "commission.") On 2019/02/06 18:41:42, ced wrote: > On 2019/01/07 ...
1 month, 1 week ago (2019-02-06 20:16:38 UTC) #24
ced
https://codereview.tryton.org/39231002/diff/160001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/160001/commission.py#newcode257 commission.py:257: help="The invoice line that shows the commission.") I do ...
1 month, 1 week ago (2019-02-06 21:43:10 UTC) #25
dave
Use 'a' instead of 'the' where appropriate
1 month, 1 week ago (2019-02-07 21:46:43 UTC) #26
dave
https://codereview.tryton.org/39231002/diff/160001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/160001/commission.py#newcode257 commission.py:257: help="The invoice line that shows the commission.") On 2019/02/06 ...
1 month, 1 week ago (2019-02-07 21:47:51 UTC) #27
reviewbot
1 month, 1 week ago (2019-02-07 22:10:30 UTC) #28
https://codereview.tryton.org/39231002/diff/180001/commission.py#newcode337
commission.py:337:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/39231002/diff/180001/commission.py#newcode348
commission.py:348:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/39231002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766