Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 39231002: commission: Add help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 1 week ago by pokoli
Modified:
2 weeks ago
Reviewers:
dave, ced, reviewbot
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7233

Patch Set 1 #

Total comments: 16

Patch Set 2 : Fix ced's comments #

Total comments: 30

Patch Set 3 : Update with suggested improvements #

Total comments: 3

Patch Set 4 : Update based on comments #

Total comments: 11

Patch Set 5 : Improve help text from comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -22 lines) Patch
M commission.py View 1 2 3 4 6 chunks +39 lines, -17 lines 0 comments Download
M invoice.py View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M product.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M sale.py View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17
pokoli
10 months, 1 week ago (2018-03-19 10:02:59 UTC) #1
reviewbot
https://codereview.tryton.org/39231002/diff/1/commission.py#newcode335 commission.py:335: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/1/commission.py#newcode346 commission.py:346: E731 ...
10 months, 1 week ago (2018-03-19 10:20:13 UTC) #2
ced
https://codereview.tryton.org/39231002/diff/1/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/1/commission.py#newcode32 commission.py:32: help="The party identified by this agent.") It sounds weird. ...
8 months, 2 weeks ago (2018-05-09 08:35:03 UTC) #3
pokoli
Fix ced's comments
2 months ago (2018-11-22 15:03:31 UTC) #4
reviewbot
https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode340 commission.py:340: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode351 commission.py:351: E731 ...
2 months ago (2018-11-22 15:15:20 UTC) #5
ced
https://codereview.tryton.org/39231002/diff/20001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/20001/commission.py#newcode38 commission.py:38: help="Make the agent belong to the company.") I think ...
1 month, 3 weeks ago (2018-11-26 21:52:40 UTC) #6
dave
These are a few suggestions to consider. Am I right in thinking that the agent ...
1 month, 1 week ago (2018-12-14 22:15:13 UTC) #7
dave
Update with suggested improvements
1 month ago (2018-12-18 16:01:26 UTC) #8
reviewbot
https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode347 commission.py:347: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode358 commission.py:358: E731 ...
1 month ago (2018-12-18 16:06:11 UTC) #9
pokoli
https://codereview.tryton.org/39231002/diff/40001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode32 commission.py:32: help="The party that is an agent for, or principal ...
1 month ago (2018-12-20 13:27:39 UTC) #10
dave
Update based on comments
1 month ago (2018-12-20 15:24:54 UTC) #11
dave
https://codereview.tryton.org/39231002/diff/40001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/40001/commission.py#newcode32 commission.py:32: help="The party that is an agent for, or principal ...
1 month ago (2018-12-20 15:25:32 UTC) #12
reviewbot
https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode347 commission.py:347: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode358 commission.py:358: E731 ...
1 month ago (2018-12-20 15:44:20 UTC) #13
ced
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode32 commission.py:32: help="The party that the commission is calculated for.") should ...
1 month ago (2018-12-21 17:52:18 UTC) #14
dave
Improve help text from comments
2 weeks ago (2019-01-07 20:35:47 UTC) #15
dave
https://codereview.tryton.org/39231002/diff/60001/commission.py File commission.py (right): https://codereview.tryton.org/39231002/diff/60001/commission.py#newcode32 commission.py:32: help="The party that the commission is calculated for.") On ...
2 weeks ago (2019-01-07 20:35:59 UTC) #16
reviewbot
2 weeks ago (2019-01-07 20:37:49 UTC) #17
https://codereview.tryton.org/39231002/diff/80001/commission.py#newcode340
commission.py:340:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/39231002/diff/80001/commission.py#newcode351
commission.py:351:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/39231002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766