Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 39531002: web_user: Add web user application

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 months ago by pokoli
Modified:
3 months, 4 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing imports #

Total comments: 4

Patch Set 3 : Reuse most of user_application code #

Patch Set 4 : Update to latest trytond review and add changelog #

Patch Set 5 : Remove test application #

Total comments: 1

Patch Set 6 : Update to tip and register route depending on configuration value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -2 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 2 chunks +4 lines, -0 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A routes.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
M user.py View 1 2 3 4 5 3 chunks +12 lines, -2 lines 0 comments Download
M user.xml View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
A view/user_application_form.xml View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A view/user_application_list.xml View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M view/user_form.xml View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A wrappers.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14
pokoli
12 months ago (2017-07-19 10:56:17 UTC) #1
reviewbot
https://codereview.tryton.org/39531002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from user import *' used; unable to detect undefined names https://codereview.tryton.org/39531002/diff/1/wrappers.py#newcode43 wrappers.py:43: ...
12 months ago (2017-07-19 11:05:29 UTC) #2
pokoli
Add missing imports
12 months ago (2017-07-19 11:30:13 UTC) #3
reviewbot
https://codereview.tryton.org/39531002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from user import *' used; unable to detect undefined names URL: https://codereview.tryton.org/39531002
12 months ago (2017-07-19 11:32:20 UTC) #4
ced
https://tryton-rietveld.appspot.com/39531002/diff/20001/routes.py File routes.py (right): https://tryton-rietveld.appspot.com/39531002/diff/20001/routes.py#newcode21 routes.py:21: def user_application(request, pool): This method is identical to the ...
10 months ago (2017-09-12 19:10:56 UTC) #5
pokoli
Reuse most of user_application code
9 months, 4 weeks ago (2017-09-20 14:00:44 UTC) #6
reviewbot
patch is not applicable URL: https://codereview.tryton.org/39531002
9 months, 4 weeks ago (2017-09-20 14:21:31 UTC) #7
pokoli
Update to latest trytond review and add changelog
8 months ago (2017-11-13 11:32:52 UTC) #8
reviewbot
https://codereview.tryton.org/39531002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from user import *' used; unable to detect undefined names URL: https://codereview.tryton.org/39531002
8 months ago (2017-11-13 11:33:56 UTC) #9
pokoli
Remove test application
5 months, 3 weeks ago (2018-01-23 16:28:46 UTC) #10
reviewbot
https://codereview.tryton.org/39531002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from user import *' used; unable to detect undefined names URL: https://codereview.tryton.org/39531002
5 months, 3 weeks ago (2018-01-23 16:45:58 UTC) #11
ced
https://codereview.tryton.org/39531002/diff/80001/routes.py File routes.py (right): https://codereview.tryton.org/39531002/diff/80001/routes.py#newcode14 routes.py:14: '/<database_name>/web_user/application/', methods=['POST', 'DELETE']) I'm wondering if the route should ...
4 months, 1 week ago (2018-03-10 18:37:50 UTC) #12
pokoli
Update to tip and register route depending on configuration value
3 months, 4 weeks ago (2018-03-19 09:38:26 UTC) #13
reviewbot
3 months, 4 weeks ago (2018-03-19 09:47:01 UTC) #14
https://codereview.tryton.org/39531002/diff/100001/__init__.py#newcode5
__init__.py:5:
F403 'from user import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/39531002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69