Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(458)

Issue 397551005: tryton-env: Accrue and allocate rounding errors when rounding taxes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 3 weeks ago by nicoe
Modified:
1 month, 1 week ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Round on line taxes only when rounding per line + better residual rounding #

Total comments: 18

Patch Set 3 : Use copy_sign + split tests + reverse on round() #

Patch Set 4 : Update to tip #

Patch Set 5 : Update to tip #

Patch Set 6 : Update to tip #

Patch Set 7 : Update to tip #

Total comments: 10

Patch Set 8 : Change names and add test for opposite rounding #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -7 lines) Patch
M modules/account/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M modules/account/tax.py View 1 2 3 4 5 6 7 4 chunks +20 lines, -3 lines 0 comments Download
M modules/account/tests/test_module.py View 1 2 3 4 5 6 7 2 chunks +160 lines, -1 line 0 comments Download
M modules/currency/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M modules/currency/currency.py View 1 2 3 4 5 6 7 3 chunks +16 lines, -2 lines 1 comment Download
M modules/currency/tests/test_module.py View 1 2 3 4 5 6 7 2 chunks +24 lines, -1 line 3 comments Download

Messages

Total messages: 27
nicoe
10 months, 3 weeks ago (2022-03-16 16:43:33 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
10 months, 3 weeks ago (2022-03-16 17:03:10 UTC) #2
nicoe
10 months, 1 week ago (2022-03-25 14:30:18 UTC) #3
reviewbot
ERROR: /tmp/reviewbot-u4zcidf3/modules/account/tests/test_account.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/397551005
10 months, 1 week ago (2022-03-25 14:37:20 UTC) #4
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG File modules/account/CHANGELOG (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG#newcode1 modules/account/CHANGELOG:1: * Accrue and allocate rounding errors when there is ...
10 months, 1 week ago (2022-03-25 14:49:36 UTC) #5
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 14:49:35, ced wrote: > Maybe we ...
10 months, 1 week ago (2022-03-25 18:53:28 UTC) #6
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 18:53:28, nicoe wrote: > On 2022/03/25 ...
10 months, 1 week ago (2022-03-25 20:21:56 UTC) #7
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 20:21:56, ced wrote: > On 2022/03/25 ...
10 months, 1 week ago (2022-03-26 08:27:01 UTC) #8
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 08:27:01, nicoe wrote: > On 2022/03/25 ...
10 months, 1 week ago (2022-03-26 09:50:37 UTC) #9
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 09:50:36, ced wrote: > On 2022/03/26 ...
10 months, 1 week ago (2022-03-26 10:47:51 UTC) #10
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 09:50:36, ced wrote: > On 2022/03/26 ...
10 months, 1 week ago (2022-03-26 11:29:53 UTC) #11
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG File modules/account/CHANGELOG (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG#newcode1 modules/account/CHANGELOG:1: * Accrue and allocate rounding errors when there is ...
10 months, 1 week ago (2022-03-28 12:58:04 UTC) #12
nicoe
10 months, 1 week ago (2022-03-28 13:11:00 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
10 months, 1 week ago (2022-03-28 13:42:55 UTC) #14
nicoe
9 months, 3 weeks ago (2022-04-12 14:36:56 UTC) #15
nicoe
9 months, 3 weeks ago (2022-04-12 14:47:06 UTC) #16
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
9 months, 3 weeks ago (2022-04-12 15:00:47 UTC) #17
nicoe
8 months, 3 weeks ago (2022-05-13 23:19:31 UTC) #18
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
8 months, 3 weeks ago (2022-05-13 23:25:07 UTC) #19
nicoe
7 months, 2 weeks ago (2022-06-21 02:00:47 UTC) #20
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
7 months, 2 weeks ago (2022-06-21 02:06:49 UTC) #21
ced
It will be good to have tests about opposite rounding. https://codereview.tryton.org/397551005/diff/423431009/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/423431009/modules/account/tax.py#newcode1179 ...
5 months ago (2022-08-31 11:53:05 UTC) #22
nicoe
https://codereview.tryton.org/397551005/diff/423431009/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/423431009/modules/account/tax.py#newcode1179 modules/account/tax.py:1179: residual_amount = 0 On 2022/08/31 11:53:05, ced wrote: > ...
3 months, 3 weeks ago (2022-10-09 17:54:15 UTC) #23
nicoe
3 months, 3 weeks ago (2022-10-09 17:57:39 UTC) #24
reviewbot
https://codereview.tryton.org/397551005/diff/424061003/modules/currency/tests/test_module.py#newcode166 modules/currency/tests/test_module.py:166: too many blank lines (2) URL: https://codereview.tryton.org/397551005
3 months, 3 weeks ago (2022-10-09 18:02:22 UTC) #25
ced
https://codereview.tryton.org/397551005/diff/424061003/modules/currency/currency.py File modules/currency/currency.py (right): https://codereview.tryton.org/397551005/diff/424061003/modules/currency/currency.py#newcode171 modules/currency/currency.py:171: rounding = ROUNDING_REVERSES[rounding] For consistency it should be opposite ...
3 months, 3 weeks ago (2022-10-09 22:16:19 UTC) #26
ced
1 month, 1 week ago (2022-12-26 12:02:33 UTC) #27

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted