Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 397551005: tryton-env: Accrue and allocate rounding errors when rounding taxes

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by nicoe
Modified:
1 week, 6 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Round on line taxes only when rounding per line + better residual rounding #

Total comments: 18

Patch Set 3 : Use copy_sign + split tests + reverse on round() #

Patch Set 4 : Update to tip #

Patch Set 5 : Update to tip #

Patch Set 6 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -6 lines) Patch
M modules/account/CHANGELOG View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account/tax.py View 1 2 3 4 chunks +20 lines, -3 lines 0 comments Download
M modules/account/tests/test_module.py View 1 2 3 4 5 2 chunks +151 lines, -1 line 0 comments Download
M modules/currency/CHANGELOG View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M modules/currency/currency.py View 1 2 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 19
nicoe
2 months, 1 week ago (2022-03-16 16:43:33 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
2 months, 1 week ago (2022-03-16 17:03:10 UTC) #2
nicoe
2 months ago (2022-03-25 14:30:18 UTC) #3
reviewbot
ERROR: /tmp/reviewbot-u4zcidf3/modules/account/tests/test_account.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/397551005
2 months ago (2022-03-25 14:37:20 UTC) #4
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG File modules/account/CHANGELOG (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG#newcode1 modules/account/CHANGELOG:1: * Accrue and allocate rounding errors when there is ...
2 months ago (2022-03-25 14:49:36 UTC) #5
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 14:49:35, ced wrote: > Maybe we ...
2 months ago (2022-03-25 18:53:28 UTC) #6
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 18:53:28, nicoe wrote: > On 2022/03/25 ...
2 months ago (2022-03-25 20:21:56 UTC) #7
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/25 20:21:56, ced wrote: > On 2022/03/25 ...
2 months ago (2022-03-26 08:27:01 UTC) #8
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 08:27:01, nicoe wrote: > On 2022/03/25 ...
2 months ago (2022-03-26 09:50:37 UTC) #9
ced
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 09:50:36, ced wrote: > On 2022/03/26 ...
2 months ago (2022-03-26 10:47:51 UTC) #10
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py File modules/account/tax.py (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/tax.py#newcode1198 modules/account/tax.py:1198: }[self.currency.round.__defaults__[0]] On 2022/03/26 09:50:36, ced wrote: > On 2022/03/26 ...
2 months ago (2022-03-26 11:29:53 UTC) #11
nicoe
https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG File modules/account/CHANGELOG (right): https://codereview.tryton.org/397551005/diff/397651003/modules/account/CHANGELOG#newcode1 modules/account/CHANGELOG:1: * Accrue and allocate rounding errors when there is ...
1 month, 4 weeks ago (2022-03-28 12:58:04 UTC) #12
nicoe
1 month, 4 weeks ago (2022-03-28 13:11:00 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
1 month, 4 weeks ago (2022-03-28 13:42:55 UTC) #14
nicoe
1 month, 2 weeks ago (2022-04-12 14:36:56 UTC) #15
nicoe
1 month, 2 weeks ago (2022-04-12 14:47:06 UTC) #16
reviewbot
checks OK URL: https://codereview.tryton.org/397551005
1 month, 2 weeks ago (2022-04-12 15:00:47 UTC) #17
nicoe
1 week, 6 days ago (2022-05-13 23:19:31 UTC) #18
reviewbot
1 week, 6 days ago (2022-05-13 23:25:07 UTC) #19
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted